Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 17 May 2018 16:59:57 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Sandipan Das <sandipan@linux.vnet.ibm.com>
Cc:     jolsa@redhat.com, linux-kernel@vger.kernel.org,
        ravi.bangoria@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] perf script: Show virtual addresses instead of
 offsets
Message-ID: <20180517195957.GD18538@kernel.org>
References: <20180517063326.6319-1-sandipan@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180517063326.6319-1-sandipan@linux.vnet.ibm.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, May 17, 2018 at 12:03:25PM +0530, Sandipan Das escreveu:
> When perf data is recorded with the call-graph option enabled,
> the callchain shown by perf script shows the binary offsets of
> the symbols as the ip. This is incorrect for kernel symbols as
> the ip values are always off by a fixed offset depending on the
> architecture. If the offsets from the start of the symbols are
> printed, they are also incorrect for both kernel and userspace
> symbols.
> 
> Without the call-graph option, the callchain shows the virtual
> addresses of the symbols rather than their binary offsets. The
> offsets printed in this case are also correct.
> 
> This fixes the inconsistency in perf script's output.

Thanks, tested and applied,

- Arnaldo