Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp3718989imm; Thu, 17 May 2018 13:31:50 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoylI+WxQrnxGWJ6ji9HzoHBrn00SiqYN7OZJa/PEnqpSNrUY/DQcBZdhETV6qzkMIlWk3j X-Received: by 2002:a17:902:e8:: with SMTP id a95-v6mr6583257pla.274.1526589110888; Thu, 17 May 2018 13:31:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526589110; cv=none; d=google.com; s=arc-20160816; b=RwCw6KDXusL17bVbkdmHJN884+CXAsUawpSEjV6dJ7dCi0WSakKcjtiNOB7JZxIyxs OW+xIr+Z82c1ngp27Iq+h9GrCq7zm+cp768kb1QDuT53efmmDTcfkM+3KaBgvZEu2dDR yaK6yFW7cwccc5zcPLISitdgBx1qDyLUj4rI4cnufU8RLg9vSqSOhBwxAjkZuFuFqs77 xLfPkFaZ+Itay2r54LAZ/+6+CfGtUVedmb1ITo2vN+yPjE20CmjVXKDA3YR2KdfqRluE DkLttC3nZgu14LNLwsP/ZkF5l2t+EH0LZuAcsQk4jNePoi1omyo+nvJ8C1MOevEsHoDZ 8rzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=0R5cF9F4/I3Krbq3XG0WWtcVaAAfi1VL0By3z9i30uE=; b=TSVkgB7+rHXuxAU+MnUw6+dLkh5ElhoPPOg1oAJt3n3lgw2UmuSHBdAYOOcl1bHpZM dCmA/pOfxOl2qV1iuMBhzIOOkmRcaKzzRo51WqCW+EfPBkKYZCqliwEG+mZPJqtVIBYR 3vliHI64t6lNNOBuwAGZyL7KRzOWVt3u0fELYp+PMXsubBgAjigEMnb+z6U6Vn8V2MsI wHhIeIQNmZqZHK/3/lUx9yPzN068ZRb4TMNibz9gAhnitUhNuR220/NPuIK9+8nBPhY2 OFMPgvH784wdBPFnaar3wlbuAgu2UpYZbOMvftHwgRfLd87Tlz0yCShXeOTtPWFdIC9A 0r7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12-v6si4386467pgo.272.2018.05.17.13.31.35; Thu, 17 May 2018 13:31:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbeEQUbQ (ORCPT + 99 others); Thu, 17 May 2018 16:31:16 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbeEQUbP (ORCPT ); Thu, 17 May 2018 16:31:15 -0400 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 73A7114168980; Thu, 17 May 2018 13:31:14 -0700 (PDT) Date: Thu, 17 May 2018 16:31:13 -0400 (EDT) Message-Id: <20180517.163113.2110198960037727630.davem@davemloft.net> To: andrea.greco.gapmilano@gmail.com Cc: tobin@apporbit.com, a.greco@4sigma.it, m.grzeschik@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version From: David Miller In-Reply-To: <20180517130529.2684-1-andrea.greco.gapmilano@gmail.com> References: <20180517130529.2684-1-andrea.greco.gapmilano@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 May 2018 13:31:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrea Greco Date: Thu, 17 May 2018 15:05:29 +0200 > + /* Will be set by userspace during if setup */ > + dev->dev_addr[0] = 0; Hmmm... really? Also, every error path from this point forward will leak 'dev'.