Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be
 static
To:     Roger Quadros <rogerq@ti.com>,
        kbuild test robot <fengguang.wu@intel.com>
Cc:     kbuild-all@01.org, Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <8c0c7001-550f-7b4d-33fd-47b3812d5c14@samsung.com>
Date:   Fri, 18 May 2018 09:47:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
        Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <50b8c19d-563d-660c-9cf1-134c64062ba8@ti.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <201805180059.3X1bJsDZ%fengguang.wu@intel.com>
        <CGME20180517160655epcas3p2b8e0c7aa08f2138882a84b5e2b7b291a@epcas3p2.samsung.com>
        <20180517160641.GA55289@lkp-ib03>
        <8b363802-50f5-1da0-0879-fe8d38231f5e@samsung.com>
        <50b8c19d-563d-660c-9cf1-134c64062ba8@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 18.05.2018 09:38, Roger Quadros wrote:
> On 18/05/18 08:39, Andrzej Hajda wrote:
>> On 17.05.2018 18:06, kbuild test robot wrote:
>>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>>> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>> It should be static of course, my bad.
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
> I don't think we accept patches from robots, yet :)

What do you mean by 'we'? In case of whole kernel it is not true:

$ git log --author='kbuild test robot <fengguang.wu@intel.com>'
--oneline | wc -l
183

Regards
Andrzej

>
>>  --
>> Regards
>> Andrzej
>>
>>> ---
>>>  drd.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>>> index 2706824..218371f 100644
>>> --- a/drivers/usb/dwc3/drd.c
>>> +++ b/drivers/usb/dwc3/drd.c
>>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>>  	return NOTIFY_DONE;
>>>  }
>>>  
>>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>>  {
>>>  	struct device *dev = dwc->dev;
>>>  	struct device_node *np_phy, *np_conn;
>>>
>>>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>