Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4302515imm; Fri, 18 May 2018 02:52:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpWKRtz3tCo1M2EAEH9mVk99vOubML+9UalMjpbYK95TRzQb6PwFWSGv5cLFEBhp66OuqE8 X-Received: by 2002:a63:9401:: with SMTP id m1-v6mr6938860pge.140.1526637145587; Fri, 18 May 2018 02:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526637145; cv=none; d=google.com; s=arc-20160816; b=yomb1YBAhV4Ia/W3A/2w5NcNzQUn1Z6xCNtG3OGDQvjMPuRm56V9HkeAdApMnlUs29 jAoErwFP/Rwa5Niy7QkkMscs093RAoIPYhca3YmhxKZh6h/fyYET4kEytPCHRq9yOloA hvUoyF/GxX+eiN5C3PcMWeUlmLH3rwnyA7ghw6OAOK+h4qzcdMH1OvInYlM9e1qByHak /Ja5SIA12nNOI9zRaa5UDtqO06evJCd3pryT1iX1jHZg4st6lNAmBiB6FypZn23pmc0l Rx8mT0NQTJXQYY7QyEZScnVy/z7ymH7U0KtauHvyapwo61ra77lzaz+k8qOsT57ArCPm Huog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=6oS3lXacaKpWNA94Hw9b0Lqm0xYiVihFAbET3pNJmSU=; b=b3s3d3U2b4h69W2xmpwPxvQYCBpEocENameMYIgj/4J7c/nRXBo55pggZ0bgswCd+j 2UzqeDsK/NeCgnrQfmgPNMRn7LIfW9qEGG8kSFoD3TZt3TvxpJo6/3M0KBN39gdNRZFO +GWWnt2T8MDmeJ0TX3xmLxSQApPrlQX2UH0w41MuhbdQ15X1VqAjj/+UQBDLgjQ5M3P6 B3ntwokvxdECIke+TXffnP24qI+wIRGjoceRZirZ9016zK4FJdpSTvdYwGvcwwqir834 l1+jNoPnXPm4tbIMKOjDI5IXpiK3jh3HxJeyn2RrMF23cQ0T7rl4+PBSHSsKrDMLFe8/ 5ORg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TduorCir; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11-v6si7083062plr.165.2018.05.18.02.52.11; Fri, 18 May 2018 02:52:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TduorCir; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbeERJvW (ORCPT + 99 others); Fri, 18 May 2018 05:51:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:55618 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbeERJvT (ORCPT ); Fri, 18 May 2018 05:51:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6oS3lXacaKpWNA94Hw9b0Lqm0xYiVihFAbET3pNJmSU=; b=TduorCirabXx65EBEk8QjEaSE G+NMlei60DtgtCXBGA1bFiQfv+B+faIAw336rpha1pr4jqLR1G+x3FkRlO0Cn/GtVvWE69le3aHPK mKb5UzSVPdM//xciFN+IQiuRMco0TRuivV30JXlu/9wtenUuxA7nTlMEU0cuborHuyT/AOaGEcgiw 5/sk1+mh+U0qewqllnrZVUNpNB/Tjre0vnA95s7HzrDBItYho003uJf7u7JkB3p+OUpGp5kQNeLj9 t31Z6bnmCrvDmERCjGRpuTgp6Jg/VP177IGUBcaIFwKe5QXSGIcCzfEVMqAOJ5LlQ6/8Zdx0xvX+t 5L/1cqvmA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJc2S-0002YH-TY; Fri, 18 May 2018 09:51:05 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8098E2029F86E; Fri, 18 May 2018 11:51:02 +0200 (CEST) Date: Fri, 18 May 2018 11:51:02 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Dave Chinner , darrick.wong@oracle.com, tytso@mit.edu, linux-btrfs@vger.kernel.org, clm@fb.com, jbacik@fb.com, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH 03/10] locking: bring back lglocks Message-ID: <20180518095102.GE12217@hirez.programming.kicks-ass.net> References: <20180518074918.13816-1-kent.overstreet@gmail.com> <20180518074918.13816-7-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180518074918.13816-7-kent.overstreet@gmail.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 03:49:04AM -0400, Kent Overstreet wrote: > bcachefs makes use of them - also, add a proper lg_lock_init() Why?! lglocks are horrid things, we got rid of them for a reason. They have terrifying worst case preemption off latencies. Why can't you use something like per-cpu rwsems?