Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4322761imm; Fri, 18 May 2018 03:13:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpHkH+b9Q53eoUouxEo2WI65vG3gU/0GQ8wYu2C8ke+X5qt++R+ZlX2Q2p5qybH597H8AvD X-Received: by 2002:a17:902:850a:: with SMTP id bj10-v6mr8673061plb.239.1526638405184; Fri, 18 May 2018 03:13:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526638405; cv=none; d=google.com; s=arc-20160816; b=yD2YtT9lF6MpMFO7Zl0CHlikZN3Uc1ZFC4vT6QE5iZOBr8sbpNe8kCDwjxFocUN0Wy VGnaAMai7q8vNj4dl43Uvmp9rq3kVKBAMcN+SsfAT8hv8+a4bNqiMRQDf9QyXxwV5KuX sWO9Nyq6pmy9a0VRB3QFUk0xASi6GXzuFhsjXcoseTUhNBMQ3JmtNwKh4jQuu8pgzmIp uu/DbWr3BNw+nWBY2qYFPUQ6v/1DecFa6bqRr9Ix5S8/uqU4ObSVUjb37im9XPX9OwEh 8DElQhZIryQBskmQpci80hym+meiSsaWFa2UOXA9x+7L3XrMqE4uOwrA9NOzvijHCr8D e2uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=j125VgVBhQPAw89F9piw5xI4N7lnjGyAmiFPBqHlfk0=; b=QQrvROVfGhhIz/fxbI87PfIR0I7c0aUma9ESGGSvK+VDVuxjLuQWIfccmy++qu4qC0 prBcwaKT9Re+lnIEVSFhQU31TUOHzbGmxiF0ikorU0I+3H7lqIWB1IVVJXtSxCObl4dZ 3/3hex9NEHVNN0LnXvU8rDO9ddU+5tAxbyDJ6ARHJJJr0zXyol96T4vnbf2UgljK0DGV Awman5y005n1PRoiD1gCYWQi53vfWiSKICvlyHamRrBCuSe3zkY5flDn/SnnzdH8VSQJ atP1LTmKwbSimn/ad24PZ84CWLo4bXKgzp3BO/5dRrdthnOjzGQGCLx0yv3xv6exvLer 7oVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r63-v6si6964546plb.366.2018.05.18.03.13.10; Fri, 18 May 2018 03:13:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbeERKLw (ORCPT + 99 others); Fri, 18 May 2018 06:11:52 -0400 Received: from mail.skyhub.de ([5.9.137.197]:54460 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbeERKLu (ORCPT ); Fri, 18 May 2018 06:11:50 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TJ6FjLOCYFAq; Fri, 18 May 2018 12:11:34 +0200 (CEST) Received: from pd.tnic (p200300EC2BC87100E112EAEA647B5E34.dip0.t-ipconnect.de [IPv6:2003:ec:2bc8:7100:e112:eaea:647b:5e34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DF16B1EC0181; Fri, 18 May 2018 12:11:33 +0200 (CEST) Date: Fri, 18 May 2018 12:11:14 +0200 From: Borislav Petkov To: Ingo Molnar Cc: Peter Zijlstra , Nadav Amit , linux-kernel@vger.kernel.org, x86@kernel.org, nadav.amit@gmail.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Josh Poimboeuf , Linus Torvalds , Andy Lutomirski , Peter Zijlstra , Denys Vlasenko Subject: Re: [PATCH 2/6] x86: bug: prevent gcc distortions Message-ID: <20180518101114.GB17285@pd.tnic> References: <20180517161402.78089-1-namit@vmware.com> <20180517161402.78089-3-namit@vmware.com> <20180518075853.GD12217@hirez.programming.kicks-ass.net> <20180518081354.GA11379@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180518081354.GA11379@gmail.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 10:13:54AM +0200, Ingo Molnar wrote: > Yes, that's my main worry too about all these inlining changes: > the very, very marked reduction in the readability of assembly code. Same reaction here: the small improvements this brings is simply not enough to sacrifice readability so much IMO. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.