Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4324255imm; Fri, 18 May 2018 03:15:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqQQJzB3Ofp6Yu1i309ailqfyOlNUlFcjckETjsLBY34Dl+hLaoyOlrz493xlAf6euqQAPU X-Received: by 2002:a62:1e02:: with SMTP id e2-v6mr8860980pfe.212.1526638503211; Fri, 18 May 2018 03:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526638503; cv=none; d=google.com; s=arc-20160816; b=DrRtjMIA9Bzje/BDkn4OEYFYe9LsGFJ8iTRRuhTAlf4oORWFbB1WVK49Hc7IYz5gp6 c5OvgIwbHDoDiu+TvC3lPpwZhDTsShrJlt5wkwaaw0kq3ceQBzsy3m/Q6OyN2oMUkY/9 RNpDrgrVue2no/vE+mgERojSswXGJoKPKGv55p1DxicfjAhGlnECMJHZhGFcndhCFleo xRhTiXVlZbTWbbQMj7OgKPcbCpHxtdn4qGXc65A4HzC5FBre3BN1Lms2ybZFJvyri1po 3rPpfa7cE+r8aTwWxQksossuYi5UCSaS/iw+RfCDVtPqMpHJFdsjjZJQCbLb4js59jMR XHPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=SG4ZfhfxnsEgNpkAoiAUCnEzQJz0P+f3iMf12jPb/rw=; b=ypzSfS42eDVO0DIVkt2C+/mI3QAib11/Pviksvp3KrhVearC62kiJe4496y4DdEjzS 6pP35zcYI+wXwQB1jOt7PoMv7m5yIErspdJ4HTHnyq3kGUuzHRhljxMq4GF+SbIseRMX 3Q2k4gHUZOVPqDSlv9+uZ6N4hKN83U3CXcKnc6g324aWki1Qvc64rRv9xF5QAA5PqHIY 9BdajHafCXe3txIAGfJtejgdV6gpyMSYDe78GaQ1aHmziufzZ8Zb7hGf7hEdX1/t87W4 1dvoOTwX3fGteme5xflL7EMFEt5LtZekj8izCUBz60c11JDk/AEoUFJCJUiW0Aw5omrM eG5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UUFzbQTI; dkim=pass header.i=@codeaurora.org header.s=default header.b=pNAP5p82; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8-v6si2323365pgc.505.2018.05.18.03.14.49; Fri, 18 May 2018 03:15:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=UUFzbQTI; dkim=pass header.i=@codeaurora.org header.s=default header.b=pNAP5p82; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbeERKOT (ORCPT + 99 others); Fri, 18 May 2018 06:14:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44032 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbeERKOR (ORCPT ); Fri, 18 May 2018 06:14:17 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 75A8460F61; Fri, 18 May 2018 10:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526638456; bh=4jaDqy+qv3yRdCw/Tj9FZEAtwmXeBa53Eupe42eCRPs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=UUFzbQTIZqdqaZgtMbei3oHNFJJXveQq3KLBZvLqBF2fyS9+SXFCnNchNv3p1Nwty LmomDP4UjTDZgWl9fLODGQww8SLJi5T+8aMRbHehGfRbFUVghjw5T7kNF1vTB4KqBO F03gGbQ0tIxnzJgLO9jPF87wJiarYx1xn6ZxW/6U= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.79.41.55] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EE7D6601D7; Fri, 18 May 2018 10:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526638455; bh=4jaDqy+qv3yRdCw/Tj9FZEAtwmXeBa53Eupe42eCRPs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=pNAP5p82iTyWD05Bbe33vbdilcGlzZx4RFbLu8FcC3JB3Z/gWlz/22mDRbDlU5daE hwD/qoeu0NIlIoP+SSUKAi82oOTYKpmnc38hzkkjZar+PNBCDQT9QBn/NRc9ZBRvZq g99+CGkpa9pzjvi5zlhgy3hP31RWRE6XqAVsNfEE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EE7D6601D7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH v11 0/4] iommu/arm-smmu: Add runtime pm/sleep support To: Robin Murphy , Will Deacon Cc: Tomasz Figa , "list@263.net:IOMMU DRIVERS" , Joerg Roedel , joro@8bytes.org, Rob Herring , Mark Rutland , "list@263.net:IOMMU DRIVERS" , Joerg Roedel , iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , "Rafael J. Wysocki" , Rob Clark , Stephen Boyd , Sricharan R , Marek Szyprowski , Archit Taneja , Lukas Wunner , linux-arm-msm References: <20180322102204.14760-1-vivek.gautam@codeaurora.org> From: Vivek Gautam Message-ID: <8bda01d5-61aa-d163-3b25-e8b055d54644@codeaurora.org> Date: Fri, 18 May 2018 15:44:01 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, On 4/9/2018 9:52 AM, Tomasz Figa wrote: > Hi Will, Robin, > > On Thu, Mar 22, 2018 at 7:22 PM Vivek Gautam > wrote: > >> This series provides the support for turning on the arm-smmu's >> clocks/power domains using runtime pm. This is done using the >> recently introduced device links patches, which lets the smmu's >> runtime to follow the master's runtime pm, so the smmu remains >> powered only when the masters use it. >> As not all implementations support clock/power gating, we are checking >> for a valid 'smmu->dev's pm_domain' to conditionally enable the runtime >> power management for such smmu implementations that can support it. >> This series also adds support for Qcom's arm-smmu-v2 variant that >> has different clocks and power requirements. >> Took some reference from the exynos runtime patches [1]. >> With conditional runtime pm now, we avoid touching dev->power.lock >> in fastpaths for smmu implementations that don't need to do anything >> useful with pm_runtime. >> This lets us to use the much-argued pm_runtime_get_sync/put_sync() >> calls in map/unmap callbacks so that the clients do not have to >> worry about handling any of the arm-smmu's power. >> Previous version of this patch series is @ [5]. >> [v11] >> * Some more cleanups for device link. We don't need an explicit >> delete for device link from the driver, but just set the flag >> DL_FLAG_AUTOREMOVE. >> device_link_add() API description says - >> "If the DL_FLAG_AUTOREMOVE is set, the link will be removed >> automatically when the consumer device driver unbinds." >> * Addressed the comments for 'smmu' in arm_smmu_map/unmap(). >> * Dropped the patch [10] that introduced device_link_del_dev() API. > As far as I can see, this version addresses all the earlier comments. Do > you think this is something that you could apply? > > Best regards, > Tomasz Gentle ping. Are we picking this series for 4.18? Regards Vivek