Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4480175imm; Fri, 18 May 2018 05:56:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpELvHYSrv761exisWDwGrEH3p9zA5Eb37u6P45iHO42QfE2nev19inxGv6ltBTyoKLH8Fz X-Received: by 2002:a62:d38f:: with SMTP id z15-v6mr9371277pfk.100.1526648195866; Fri, 18 May 2018 05:56:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526648195; cv=none; d=google.com; s=arc-20160816; b=NQ0+q7rSD5Y3lYw7A87gQCh33+jBFmiZqK+AN4N6XrR+GA6gAX1kRst2Jmd3Un3OG0 EiX14UDlK6S8DPmS8qwWkv6+KDKKeVcoW9IVAUtjAZDerJLsHSS/t7e8ixp6/4Rkvl1i rUVgagQnjr721I6cNbEUidKZ8r6rECJ1LvXPPUK2rcrLCjg4eEiOCFet8h599ZvoCm5H WDBJpSIYDwyx8qSuJHTtiVu38q50rgAT7Jo1bBk2aPHgQdF/SKienpKV8hvEssHtDZEG 8G2mENtlrYy7BE5u5sJcQmm/mJNJBlhgfnqPBaVJ7KOKxnrXvikns5cau9t1Gvu8kMeG nu0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=hS34oyTRSmMn3EMcFU/M2XED7Rv17GtmYccDQf9TGkk=; b=Ln9LYvXudltO+e4VX11ZeGIU8rWjB67+BMXwhCyBdql7BB0zQNIigorf7y2+VeZOqV 62UGyiM3fMeGN5T9AMrBz0BQbWGxC4G832ECIbVXHDfqfMr/9z8D9hKMJLuKK4Lb8dqj bUClSvfVZ+64r7irAA/u3DjfCaGznULQn0xIzJv/Q0kyY3HJCoOkksyW/2nZAy755TqR NiiP7CkcIZX44hLTms4R6cLEv9Xc8Xj5s/vhx66MBllaMJenDgIOr2H3WXS2M+YJ8Qsq iB6t57N1Cf2THbsEFNoQCpaQKmbdVKqE4etqAS5yO5vwh45D12rcg34BlPO7BVEGjYa7 LcIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linbit-com.20150623.gappssmtp.com header.s=20150623 header.b=dXb1ScQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w13-v6si6086792pgc.422.2018.05.18.05.56.20; Fri, 18 May 2018 05:56:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linbit-com.20150623.gappssmtp.com header.s=20150623 header.b=dXb1ScQH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbeERM4I (ORCPT + 99 others); Fri, 18 May 2018 08:56:08 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:53602 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbeERM4C (ORCPT ); Fri, 18 May 2018 08:56:02 -0400 Received: by mail-wm0-f66.google.com with SMTP id a67-v6so13885901wmf.3 for ; Fri, 18 May 2018 05:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hS34oyTRSmMn3EMcFU/M2XED7Rv17GtmYccDQf9TGkk=; b=dXb1ScQHfJlNWkiDDKFT+vAywQcuiOkE3TtTRXUTNYfX1wmNGPLdzT88rpsKzmNaF5 fJ/rm2HXMS6tajjtOpSjU1wUx9cxuU12Y+G+J1dch++ml4mog7X7RBS/bnvIgkrnmk13 24b+CpE3L2NbFhE4RLFD1cY4N/vJc8BXcmU4S/rUYOVNB0wjKO+/CvuSjGe/J5SHml7O GH2AYzwfTw8YK1e/2+epSPRhAxG16qZOTtXuBPcnQQj6/JhpYV2bEKYIWVx5EoikbdQm F3+mV74mxAT7ytB4wLDlXCXmMKgX72sQforzJnlmb755oQmMJiHEB47pDlI08LrNbhp4 2TXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=hS34oyTRSmMn3EMcFU/M2XED7Rv17GtmYccDQf9TGkk=; b=DLmxfclWogKD3puWE59ypl3aS2B9Mh7fEkaDTS4D0xuW/XBgQdI0fZFBFMuF5ciVyZ Efp6J6mtHcupuTmPzcPuKVy++X9F7J3VNT0AvlTemz5+Ef3SMi+vmSCIz5mghpLiitfR J2fzjrPtwhov+p3m8RFresZzhFK6MfNqWnyOILZYmVJ5COG+4r/0Zl6Lcke5RdFZM21L jlseQlqn5Q8LOiTORAG/XvytNdrof2LIQPq00yvlYDPKZ6CX/IPpWkGAB7GasAgXXTbF NLhM6qHPPCr48F5O72a2TONIEMC0q83DZVwgH723ZvvLzTkHisrilqaQEeAD2E2zKQBg xRjA== X-Gm-Message-State: ALKqPweH28pW6dL8xxEt6k/cbLmHzfw63PA8bbv+yQ90ID2bYrmdsH9R LQ8TQJQtwHHQQZLudBW74fkDsQ== X-Received: by 2002:a1c:8e47:: with SMTP id q68-v6mr4701232wmd.104.1526648161526; Fri, 18 May 2018 05:56:01 -0700 (PDT) Received: from soda.linbit ([86.59.100.100]) by smtp.gmail.com with ESMTPSA id v12-v6sm6352258wrm.68.2018.05.18.05.55.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 May 2018 05:56:00 -0700 (PDT) Date: Fri, 18 May 2018 14:55:54 +0200 From: Lars Ellenberg To: Christoph Hellwig Cc: Andrew Morton , Alexander Viro , linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Greg Kroah-Hartman , jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Jiri Slaby , linux-ext4@vger.kernel.org, Alexey Dobriyan , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 28/42] drbd: switch to proc_create_single Message-ID: <20180518125554.GA9238@soda.linbit> Mail-Followup-To: Christoph Hellwig , Andrew Morton , Alexander Viro , linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Greg Kroah-Hartman , jfs-discussion@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Jiri Slaby , linux-ext4@vger.kernel.org, Alexey Dobriyan , megaraidlinux.pdl@broadcom.com, drbd-dev@lists.linbit.com References: <20180516094346.20506-1-hch@lst.de> <20180516094346.20506-29-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516094346.20506-29-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 11:43:32AM +0200, Christoph Hellwig wrote: > And stop messing with try_module_get on THIS_MODULE, which doesn't make > any sense here. The idea was to increase module count on /proc/drbd access. If someone holds /proc/drbd open, previously rmmod would "succeed" in starting the unload, but then block on remove_proc_entry, leading to a situation where the lsmod does not show drbd anymore, but /proc/drbd being still there (but no longer accessible). I'd rather have rmmod fail up front in this case. And try_module_get() seemed most appropriate. Lars