Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4556923imm; Fri, 18 May 2018 07:05:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoXo5dOz2pKV91JvF1PxZpj69DZi+XqDRsPMu2SoFFIsl96R5E6ZoFvQYiH8nvWI3DZcfYt X-Received: by 2002:a63:7415:: with SMTP id p21-v6mr1690280pgc.373.1526652342714; Fri, 18 May 2018 07:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526652342; cv=none; d=google.com; s=arc-20160816; b=nkgjEP8VkW/nlRXEWUcMAeFYRBngYx+NvTv2fhgRCn5ERHWxKOC2hIno3tss5M9jm5 iENef6zZLA9NyGfE+9HhSeiJM1Tkg7gZ4+uDKIqyJdZBvLodEUlgsSdjKwUp4tPzXeIM 4brvDikX3eV6tYwsQ9zhXVh5ahUaIX1CVlYLOry+KfMuXbbXBsSDUfuphQzSn9UYgIQ4 Uf3l0o0ePN9f8Rs13XK0BuyxZuEmvcymI3fKeI52MCQSXIZ3m5cv8wYztpkswBF6FIdg F/hRiSy0BaoRFH37GP2vJj86VSm2Dup8HeEBgvFUwf5PE7i7m2D2cy2oiO97VhZcNSYT LCBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=RGQFIQd/Hfmw/+7LchJzb4DpeuVnnZB+89pwa83OmpA=; b=uzuUGMTM3/aYEJxtdRhooROdINJpOQ9sXj7uXsA2prD5FKS5Do6uERF15y1ZfDqeJc yK2zO5aKKbmB21lLD3dW2d8G7sks7Y9IlowBhX+1YuP0PaSmRVmCWwduGJEbZq01fSKp vB1acvOhfxPiIBntBDDLmG8EVYlb5FiecpfLKZsvGZHgBstKm+sCcZ5HH4+npCWchqWP snZa3YKQUhSi4ings8KXjl02EvxppuOHrNZqIGNrUZ5quxfshTUio+oHnX65vFdGWwh0 D4NcT1qqBZZJUnsACcuHGKwWAo43KO4I74VGAhLoWHQJ9a5XVPTdOnRUJ44DxL9iGoC2 PZzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i63-v6si1550510pgc.607.2018.05.18.07.05.18; Fri, 18 May 2018 07:05:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbeEROEp (ORCPT + 99 others); Fri, 18 May 2018 10:04:45 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:50728 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbeEROEk (ORCPT ); Fri, 18 May 2018 10:04:40 -0400 Received: from localhost (unknown [IPv6:2001:bc8:30d7:121:9eb6:d0ff:fe8a:8b39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ana) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7841D2870DA; Fri, 18 May 2018 15:04:37 +0100 (BST) Date: Fri, 18 May 2018 16:04:35 +0200 From: Ana Guerrero Lopez To: ming_qian@realsil.com.cn Cc: Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: media: uvcvideo: Support realtek's UVC 1.5 device Message-ID: <20180518140435.GA17444@delenn> References: <1525831988-32017-1-git-send-email-ming_qian@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1525831988-32017-1-git-send-email-ming_qian@realsil.com.cn> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 09, 2018 at 10:13:08AM +0800, ming_qian@realsil.com.cn wrote: > From: ming_qian > > The length of UVC 1.5 video control is 48, and it id 34 for UVC 1.1. > Change it to 48 for UVC 1.5 device, > and the UVC 1.5 device can be recognized. > > More changes to the driver are needed for full UVC 1.5 compatibility. > However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have > been reported to work well. > > Signed-off-by: ming_qian > Tested-by: Kai-Heng Feng > Reviewed-by: Hans de Goede > Tested-by: Josef Šimánek It works perfectly here on 4.16.5 with a Dell XPS 9370 in Debian. Tested-by: Ana Guerrero Lopez Cheers, Ana