Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4562444imm; Fri, 18 May 2018 07:10:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZofTxATQGRptp0zlrL7ju2Ghd/amvy7Mu7YhLKBLm13s6Qlj0n1dESxsvHzc54fzyWmiv1n X-Received: by 2002:a63:7b1d:: with SMTP id w29-v6mr7700840pgc.417.1526652619619; Fri, 18 May 2018 07:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526652619; cv=none; d=google.com; s=arc-20160816; b=xRrO8B42BaVbyCTWGFZ94URN+qVgwFaTKgUfDMnJhFt593V0r+pF1O67I1dgaDdIjm BiTKsOc+TTU+rdES+GTrKu0k2XYSqZG5Kq5WUYxmnnjpkCJng3INJ+3V0wuR2qo5UQjE d5g+0JhTh6CwN1Cr9LpXMgLPQef88/6nXFq7A/qZyTx4vYduX/aMZx4ZQnxPqEICLQCj jooP1B97OYHJnFBHxaqxxgKRSuKCPV9NPc8Rz76RwT/I91KhNQCCD3motbsK0DmrDpjO W7cxk8Ky1j2N1RcLDZuLpWim+bf3i/AJAZiyKphl0kP2i7GEMzwN/galNPC0fcluhLw8 JNUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :arc-authentication-results; bh=6YHxknfzR9iKLeXgtv7ggIz2BhNMctgB3xIKpi0iQU4=; b=eoxqeg7zuD/BGlXm4cXqyPGvucS4UY83alcxQsF6zt+J2FxyFfx2gAWTGYOhFewI2a dv7LFAeoYHHVaJT7ynJcClFuVpcSRXEyKf7r9S/pUfBDKUWt4fBJo6jsqIIDcMFZJph0 GffN1QRVQMoUVUddOwy0oRO6RQmb36Ba80x+PavQulvGV/L93sXBOofoIqbtZjMaNQG2 7XBGKgdVwOZ891Dx20xTwPBeWf3lT25r6TYHJ0hpAWwxyAuP96C0aNHgpFRQ3m0TxsYp CTZy1ddjzvSZOt9wDQWhUaHlOvP3drbp16VeCOrM0lgeedOZEzzFGP7C2n9DJrDXf61r E+cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o63-v6si7477134pfg.5.2018.05.18.07.09.37; Fri, 18 May 2018 07:10:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbeEROHg (ORCPT + 99 others); Fri, 18 May 2018 10:07:36 -0400 Received: from gofer.mess.org ([88.97.38.141]:43849 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbeEROHd (ORCPT ); Fri, 18 May 2018 10:07:33 -0400 Received: by gofer.mess.org (Postfix, from userid 1000) id A154560644; Fri, 18 May 2018 15:07:30 +0100 (BST) From: Sean Young To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Mauro Carvalho Chehab , Daniel Borkmann , netdev@vger.kernel.org, Matthias Reichl , Devin Heitmueller , Y Song , Quentin Monnet Subject: [PATCH v4 0/3] IR decoding using BPF Date: Fri, 18 May 2018 15:07:27 +0100 Message-Id: X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most widely used IR protocols, but there are many protocols which are not supported[1]. For example, the lirc-remotes[2] repo has over 2700 remotes, many of which are not supported by rc-core. There is a "long tail" of unsupported IR protocols, for which lircd is need to decode the IR . IR encoding is done in such a way that some simple circuit can decode it; therefore, bpf is ideal. In order to support all these protocols, here we have bpf based IR decoding. The idea is that user-space can define a decoder in bpf, attach it to the rc device through the lirc chardev. Separate work is underway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http://www.hifi-remote.com/wiki/index.php?title=DecodeIR [2] https://sourceforge.net/p/lirc-remotes/code/ci/master/tree/remotes/ [3] http://www.hifi-remote.com/wiki/index.php?title=IRP_Notation Changes since v3: - Implemented review comments from Quentin Monnet and Y Song (thanks!) - More helpful and better formatted bpf helper documentation - Changed back to bpf_prog_array rather than open-coded implementation - scancodes can be 64 bit - bpf gets passed values in microseconds, not nanoseconds. microseconds is more than than enough (IR receivers support carriers upto 70kHz, at which point a single period is already 14 microseconds). Also, this makes it much more consistent with lirc mode2. - Since it looks much more like lirc mode2, rename the program type to BPF_PROG_TYPE_LIRC_MODE2. - Rebased on bpf-next Changes since v2: - Fixed locking issues - Improved self-test to cover more cases - Rebased on bpf-next again Changes since v1: - Code review comments from Y Song and Randy Dunlap - Re-wrote sample bpf to be selftest - Renamed RAWIR_DECODER -> RAWIR_EVENT (Kconfig, context, bpf prog type) - Rebase on bpf-next - Introduced bpf_rawir_event context structure with simpler access checking Sean Young (3): bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found media: rc: introduce BPF_PROG_LIRC_MODE2 bpf: add selftest for lirc_mode2 type program drivers/media/rc/Kconfig | 13 + drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-lirc.c | 308 ++++++++++++++++++ drivers/media/rc/lirc_dev.c | 30 ++ drivers/media/rc/rc-core-priv.h | 22 ++ drivers/media/rc/rc-ir-raw.c | 12 +- include/linux/bpf_rcdev.h | 30 ++ include/linux/bpf_types.h | 3 + include/uapi/linux/bpf.h | 53 ++- kernel/bpf/core.c | 11 +- kernel/bpf/syscall.c | 7 + kernel/trace/bpf_trace.c | 2 + tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h | 53 ++- tools/include/uapi/linux/lirc.h | 217 ++++++++++++ tools/lib/bpf/libbpf.c | 1 + tools/testing/selftests/bpf/Makefile | 8 +- tools/testing/selftests/bpf/bpf_helpers.h | 6 + .../testing/selftests/bpf/test_lirc_mode2.sh | 28 ++ .../selftests/bpf/test_lirc_mode2_kern.c | 23 ++ .../selftests/bpf/test_lirc_mode2_user.c | 154 +++++++++ 21 files changed, 974 insertions(+), 9 deletions(-) create mode 100644 drivers/media/rc/bpf-lirc.c create mode 100644 include/linux/bpf_rcdev.h create mode 100644 tools/include/uapi/linux/lirc.h create mode 100755 tools/testing/selftests/bpf/test_lirc_mode2.sh create mode 100644 tools/testing/selftests/bpf/test_lirc_mode2_kern.c create mode 100644 tools/testing/selftests/bpf/test_lirc_mode2_user.c -- 2.17.0