Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4574959imm; Fri, 18 May 2018 07:21:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpqFkmPJyGctA+RidF31cwsMLKAJnh5nMo8zR/EcA85FNK2PyVCRfVtl0mOEK8nmrWf60Wn X-Received: by 2002:a62:3ec2:: with SMTP id y63-v6mr9679583pfj.102.1526653274001; Fri, 18 May 2018 07:21:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526653273; cv=none; d=google.com; s=arc-20160816; b=wEDBlYlZHHemulXSmLA5qik/kK6GVki79Vpong+21ze4PhlzT5CADm7IAagM2p+nr5 88G3MfVZ3N74e0eBQ2OJINzrUHgleg466n0RKADzxRT3lHaglC009ITwyO5TqWZzVIP1 dmgm1iH3QC8Zq0e2mjiIKZFe9PhQkBfm4fP8t7Acu/Nm3GM/43V4lS/opncMeuuJV/zi clyukWl+MKQdHkYL4FuMIWUmSk/ySU9cM1Vscua9DjiyCsTq4qbT8wvGjhKvt/oY7Eci 6HhhE4+RMu/1uXI8DqCev6LjxaaDPj8OB6IxaS9VPM0Ac64bG8NANA/n7Laww+mZgLbp mtng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=SqEgq/vVSvgvdmRlc25lBIlfyNHhDKml6lEzmIz5C5I=; b=IPNbMHbOez5NUPYs/yLNW40XWzDoNB7EsIJX5nstq+8qMKS/h5FaOwrcfLeXHaskYB NDEf9O0mXFq0brVa7ZLM+6YvE7RdOp1g0uzTMp2ax9XICXPmnf1BlIP9jF6RKKeIXft4 HrrMVaud6E6tTCUU5MtEIA/uq+3wr3HIuQ8AOH84pRT4+0mT6jr9FnbXaWgIXYXd5/8g E1xS+pETHbnwfNywklQCNspkxtr4mIzeJ7sdamt/rZj0MZr4pnPfZLkEqThxT1k9cJd4 PRnG0YmkGM80NigvMABMiABt0iAdx4TVQeweAVex4wD3JXG5rmrHreIBodKz53aZrbAg IXtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KNtXXrIa; dkim=pass header.i=@codeaurora.org header.s=default header.b=h8ZRx6Aq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5-v6si7421655plt.357.2018.05.18.07.20.59; Fri, 18 May 2018 07:21:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=KNtXXrIa; dkim=pass header.i=@codeaurora.org header.s=default header.b=h8ZRx6Aq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbeEROUh (ORCPT + 99 others); Fri, 18 May 2018 10:20:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49590 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbeEROUc (ORCPT ); Fri, 18 May 2018 10:20:32 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 60E52601D7; Fri, 18 May 2018 14:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526653232; bh=dv11JnHcfxhwJ2kJ1HlpXQCjstf+dAFUDkZdUKIhWSE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KNtXXrIazrr1rN4WgRBN0/9MboFd/AOsBTcP5TfZ66ySGmPfJGbREqv6FOGbL2Hlm HWKSQg6lhNt6fAadd9kLSivrfB4MKJFmFoD0MjrsY87+ZeEhgvwfkVj1FTmTVuEQxo GTaBBsDoCupaY8/AoPU94cBtuZiYKlct2OO/0NhY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.105] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 54931601D7; Fri, 18 May 2018 14:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526653231; bh=dv11JnHcfxhwJ2kJ1HlpXQCjstf+dAFUDkZdUKIhWSE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=h8ZRx6Aq+KUOlGz5z4GooeEHhqNu18KVxUyYV+PmBl4pnBW/QaM/JW97FPGYTVfni zfFspSwMV/DfEz2E+pv+Kyej81AQbFshAZP5UxPu5+GgigBNstKzgzoIh0M7ozYpTc zvlto8wVZI+Je8AZBq6TSkIOxntb1CNafeQRsIzw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 54931601D7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge To: Robin Murphy , linux-pci@vger.kernel.org, timur@codeaurora.org, ard.biesheuvel@linaro.org Cc: "open list:EFIFB FRAMEBUFFER DRIVER" , Bartlomiej Zolnierkiewicz , linux-arm-msm@vger.kernel.org, open list , "open list:FRAMEBUFFER LAYER" , Peter Jones , linux-arm-kernel@lists.infradead.org References: <1526563343-28721-1-git-send-email-okaya@codeaurora.org> <36cf3f12-bfe8-1c38-4d2c-b785fc64a3f6@arm.com> From: Sinan Kaya Message-ID: <733101d0-9051-a5a6-ef64-162d8d1e10a1@codeaurora.org> Date: Fri, 18 May 2018 10:20:29 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <36cf3f12-bfe8-1c38-4d2c-b785fc64a3f6@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/2018 6:42 AM, Robin Murphy wrote: > > FWIW, now that I've actually gone and looked, it appears you could simplify the whole function quite a bit by getting rid of these and just using the new local resource directly, especially since the only actual use of size is an open-coded resource_contains(). Posted V2 a minute ago. I did the simplification on a prior patch in order not to mix the issues. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.