Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4687882imm; Fri, 18 May 2018 09:02:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpCi57rbUHC4xIKrLpYk/Ur9LGjU8tgoj1uh/U8cU2bIb7HIaZ1JU18VVN+ztQACiCap2Im X-Received: by 2002:a62:fc8:: with SMTP id 69-v6mr10034536pfp.14.1526659362120; Fri, 18 May 2018 09:02:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526659362; cv=none; d=google.com; s=arc-20160816; b=DMZ62EI9Ybs+5G4DQPckkbgZCT3PSUTUah6zFJ+Eq1mzo/jMVdbd7WWsO2K6SUvreF LjYUrCCjBa8sOoGq7R5GxjDZJjMxDutB3NQeEOAMUrLOYv9tJfRi4M7ssuROHLkkP8qC MPdRdxOLbwbiR27qLdv0L8OposxlHxqwQEqBwBaP2uRiRxTBzQMNd0rWrcq84IYHTw52 cJqYVixPUOCIQHtDCSqWmvOX8MaRCyTbgKeqsvQDFU+lfskSxdZ3aChuycGCM8bm4Y+6 8sN99wlm+xo+RmuTLdsnxFbyMwgs2QZDUo4G0tF/prduACUHgjcuoEZJPdYD9oSjuFZ7 bj8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=XH7on/EsZsqCYVCiq01DI0Cd0bwvsp3x0r3/DYmcD20=; b=KO+W0mjjwWnamddhkvbPaogyjaUBROT0Gq+Gg5ZZO5JNpKjALPITjw5wE5BC3v7cYh j91r7XAiwQjBma6IMRq+3+bvsov4kWhmOCM0hXVPVCYki10iaI9ehI8MtXlxLToidCLe 1n32rxoOiS3DBaCFQuTr2Jbk3YCo/ExcM77TmlAvnjgdQ3ZoHFneI8SoOersoGoPJHlf BcnKPpFVdbRoQ7GduqGevYAI6GGVgry9IEqi9D3E7XIjbx82tj0+tNHWJkMsYxSAwq2S pM/96lXCLMDVoiDd6e1KSQu0STWrodyTzrRq75dyClo+uqpMnnC2naXpV7i+Upj05DnS T+WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Bt4lPaa0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4-v6si8103630pff.24.2018.05.18.09.02.26; Fri, 18 May 2018 09:02:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Bt4lPaa0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbeERQBg (ORCPT + 99 others); Fri, 18 May 2018 12:01:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59594 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbeERQBd (ORCPT ); Fri, 18 May 2018 12:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XH7on/EsZsqCYVCiq01DI0Cd0bwvsp3x0r3/DYmcD20=; b=Bt4lPaa0iaF47uvuwYydbLZjg KhrgN3/GIyo0wYwz1xQU9uz5gYf/ZiTdsHQpbTEFb//hfu7c7+GbOKMveYjykPNMTj9fg/2rNXxOB fKEmhkHooRiD53lzVqaMLFy0grnqDU+Aa+/nT7v/ZXmE86Rg7xsqm50HrPiDgfQqDVcgmwcluBg0S 0xhwYk42eYhji2s06wCRiWEkEmFLldKq8dGFzTEJRtVrVqDQH4ETEjuHdrK4JwbDS8fxh8UpPAfIi AObBFY84bIA+IvJB64hCkPaDBtd/es2OK89ClRshRE0Fb1FYL354w8yGkJ7+8l1ViUGS+66yvva4E b0uNNuZig==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJhoy-0007pW-8S; Fri, 18 May 2018 16:01:32 +0000 Date: Fri, 18 May 2018 09:01:32 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Dave Chinner , darrick.wong@oracle.com, tytso@mit.edu, linux-btrfs@vger.kernel.org, clm@fb.com, jbacik@fb.com, viro@zeniv.linux.org.uk, willy@infradead.org, peterz@infradead.org Subject: Re: [PATCH 05/10] don't use spin_lock_irqsave() unnecessarily Message-ID: <20180518160132.GB22791@infradead.org> References: <20180518074918.13816-1-kent.overstreet@gmail.com> <20180518074918.13816-11-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180518074918.13816-11-kent.overstreet@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 03:49:08AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Looks generally fine. A little changelog with an explanation of how we obviously never could get here with irqs disabled would be nice, though.