Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp4695316imm;
        Fri, 18 May 2018 09:08:30 -0700 (PDT)
X-Google-Smtp-Source: AB8JxZoT6UabhTe8wDJOEyIRyeNgNB+QY/FFm8DWkYhO+jeRJ+n0EbfAQNOPCatuqF2XgTBVYjOC
X-Received: by 2002:a17:902:8c81:: with SMTP id t1-v6mr9960202plo.310.1526659710087;
        Fri, 18 May 2018 09:08:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1526659710; cv=none;
        d=google.com; s=arc-20160816;
        b=vvyPguT3OHk6Uq91SXI09mCq62D7hlikqSvr9BJvMMBA3gILS4VCAcIMA0msBV9QeF
         hjcvFkDAfSVs5H/ZlrSKV6loniVP17vAT/4QinTLg+eWsFnsFW32zmGP9snWVYHKQSeN
         CeKlsFjVTniC4ljmsed6ONhmjXjE3Ndmm6Hi2NF93US+oMekcUfls5hUYYZVX6ibp9NB
         BTMf9RWD2N/v5t18tpHarizkyq+bTFRxUxLS5fLwcxdUzZKfy9jaK4IVnJcu5I8Cf2Ym
         bvmOH8/KuZRxhoonc3furiM6Zwxn7p9o3Ll80ocpQqoUpSUL/Jhnd95urs2yoCl+mYza
         4JVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature:arc-authentication-results;
        bh=jEk2GwVpT7Y8wWST7CST08znjsDJpaltlBasfp1nhD8=;
        b=FsfN5GCyMHjA9fFoz8KHKTn6paZfSDZB6DHZCSkwbzDU5k37qKYDKk9C9I+Pq+G5+r
         U4qeOR2/HoEPXc/6CkbFy7Ugn4hC38BOldnQZXgDiXDPNCNqHU3tEl0lSlCZUEu+bnVr
         Uv4LSOSjJqJoyvI5BgBiGRXq85/VESXB92IehplEFJbOYcjA0ZPKYCC0cYdU0zo15uqa
         OUNNb1cjHQVjf5du/DlR/8h56J3XDY623PzMBmFYzBI/xCWux3ZzueEj4NjAup3E/zIL
         wEJYR3BJnyHrmNJtvYWtN1Lwsf/ZTEwALgsFXHgshvoDHN3Izx0ZuQ6td06xBXOZtTXp
         WYKw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=szAUdiIq;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id n10-v6si7309016plk.112.2018.05.18.09.08.15;
        Fri, 18 May 2018 09:08:30 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=szAUdiIq;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752234AbeERQGk (ORCPT <rfc822;mohamedabbas.us@gmail.com>
        + 99 others); Fri, 18 May 2018 12:06:40 -0400
Received: from bombadil.infradead.org ([198.137.202.133]:36598 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751298AbeERQGi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 May 2018 12:06:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=jEk2GwVpT7Y8wWST7CST08znjsDJpaltlBasfp1nhD8=; b=szAUdiIqVPB1ez9XaT2G/zsRX
        c12kbNpQABALg6VNu+/PoJX4wTIV/nsONq6+4TWjo2ixNjoMXwjQrWCg73YLPZQuvbP3TuoUQhxwt
        nOaUzAQI4jdAfOQKojeHj9WcE6npImko9P/YJyn7X8AWb4DyjpNDbbYINvhDEBVKk6ki+G3WdT6ad
        2/+T04ySJoVBe+cDdM1R3/rPBkJK8l3aeBZZcDh4FR6xgzXVL5kqXHDSyPVpebQO2zNZTb1l0Gc8v
        6RXBbTSZasKRbyp2/BXFoy9WPN2phvWvac5JIrbsG+Z45MIa2lwlC0wP2JRT+8QKNbhIymi1V8KCR
        fYKAYuxnw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux))
        id 1fJhts-0002Dk-MM; Fri, 18 May 2018 16:06:36 +0000
Date:   Fri, 18 May 2018 09:06:36 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     adam.manzanares@wdc.com
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        axboe@kernel.dk, bcrl@kvack.org, mingo@kernel.org,
        peterz@infradead.org, pombredanne@nexb.com,
        gregkh@linuxfoundation.org, bigeasy@linutronix.de,
        rgoldwyn@suse.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-aio@kvack.org,
        linux-api@vger.kernel.org
Subject: Re: [PATCH v4 3/3] fs: Add aio iopriority support for block_dev
Message-ID: <20180518160636.GH22791@infradead.org>
References: <20180517203803.2664-1-adam.manzanares@wdc.com>
 <20180517203803.2664-4-adam.manzanares@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180517203803.2664-4-adam.manzanares@wdc.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks fine, although I'd split it into a aio and block_dev patch.

Also please wire this up for the fs/iomap.c direct I/O code, it should
be essentially the same sniplet as in the block_dev.c code.