Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <e97aa7a7b09f020614025ddd8ec2ca4b1fcc18e7.camel@perches.com>
References: <cover.1525964381.git.joe@perches.com> <deb55d864f0bf266e019a74456612db36f8921a9.1525964383.git.joe@perches.com>
 <20180518084203.n2etqcigvwxzcanv@pathway.suse.cz> <9332d922caf8e25747aa19e573cc3ab82519f6f7.camel@perches.com>
 <CAHp75VcaAMM7NxSWEFhrmQfKMOskuzbAHL-+eqi4DQ71cT7=Bg@mail.gmail.com> <e97aa7a7b09f020614025ddd8ec2ca4b1fcc18e7.camel@perches.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 19 May 2018 21:27:13 +0300
Message-ID: <CAHp75VcqVK6B3vuJF7y669+imhmQKo2L=1d9hYxesi46a3-s=Q@mail.gmail.com>
Subject: Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME
To:     Joe Perches <joe@perches.com>
Cc:     Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 19, 2018 at 5:05 AM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote:
>> On Fri, May 18, 2018 at 12:10 PM, Joe Perches <joe@perches.com> wrote:
>> > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote:
>> > > On Thu 2018-05-10 08:45:29, Joe Perches wrote:
>> > > [    0.000000] libftrace: ftrace: allocating 40753 entries in 160 pages
>> > > [    0.004008] apic: APIC: Switch to symmetric I/O mode setup
>> >
>> > I believe the uppercase APIC: bit should be removed.
>>
>> I disagree on lowering the case of some prefixes.
>>
>> In the case when kernel crashes at boot time and only what you have is
>> what on your screen it's much better to catch with different cases
>> than if everything would be either upper or lower.
>
> I don't parse.
> My suggestion is to make "apic: " the only prefix.

What I mean is after your patch it would be like:

subsys1: ...
...
framework1: ...
...
subsys2: ...
...

What I meant is what you can see in any current log, something like:

subsys1: ...
...
FRAMEWORK1: ...
...
subsys2: ...
...

When you see such on a long screen, you can momentarely put your eyes
on string in question.


-- 
With Best Regards,
Andy Shevchenko