Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp5976304imm; Sat, 19 May 2018 14:06:27 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpvSIFhR1o244k0rYK8736WnTGXnwRUVO7BcAkUjpVBIu0X+ZYanLlqAKb4cZT70KWAcFef X-Received: by 2002:a65:460f:: with SMTP id v15-v6mr10235902pgq.31.1526763987861; Sat, 19 May 2018 14:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526763987; cv=none; d=google.com; s=arc-20160816; b=PH4TA4i4Ah34nsTM/FCR9VaJFCF1YXwEyGgY0hQcnsBFIllsEClgI2CzGksEXRjKn9 YgFXDQjzSOoywSI0aorO67aomctGQhk3kitBO7HktKjkmFBY4zJn716uGhoH6x2VuS8l Al9f6YX/bPeqWx+nRzEGeo18mqfpy9h68qYj541dUorlgYajw2+DMk1kGLGnVbFn877o pwSHkv+ZBJ3sshwxI+vTOFtqqzc/E/d3X4zfQy+9TmH9n2ohZtb1BAEmJoedBwmd84Gl brWBZhjLOiJbEbRpL/5wMEPOOe9HKc9v3g7RsTFFJ18rJWgLKGLlK6+zWxgU+xRAAQID s1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=XbuHlJRrkK/bR8CEmoRQ17umXSJ/PvlizHx+7P5jBMw=; b=eOshkvf1TMbvhTn3UfOi4ovrcyBUpK1SkDUCPo4UJlTu/Eu3AaVFMD0ZsZ098SFs2c eCl7iqzeZgGTwe68WkwHnp8SZzLkB2onpsq5lcUwgx+d8rdkkLV7cJXkHCJb6IsKneR+ +asCPvKa+Qvgbb3iQCaVgQYkSY/ZyJKtfWeX4NPSTSVYA9z6RUK+VRbDifprPU1h+iqg OKwFD8po/tWeqMtDMftuRhQILnHkLGyj3ZsktZgs7nHWAugbd78hAFp6r6UqIEwdEagR 2c0dlU0d/SPiQG2QHpXLsClYqW7oG4HOrnNP8FnlUxgu9co8xF8easUaQewWz5YnkCCc DLCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oL7e3bIQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12-v6si10143355pls.278.2018.05.19.14.06.13; Sat, 19 May 2018 14:06:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oL7e3bIQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbeESVEt (ORCPT + 99 others); Sat, 19 May 2018 17:04:49 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:40083 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbeESVEq (ORCPT ); Sat, 19 May 2018 17:04:46 -0400 Received: by mail-qk0-f195.google.com with SMTP id a74-v6so1850956qkg.7; Sat, 19 May 2018 14:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XbuHlJRrkK/bR8CEmoRQ17umXSJ/PvlizHx+7P5jBMw=; b=oL7e3bIQBC1js1L8dgrByVwaSaT/Jy4W/oCI+4g4oV4rLAVbrsFR1QiF6iiNn+zrVM +bWdU/gwOY9UByksW6QTFmnn02pH9y9gt+QNiVVGBhpZGvV0frlrrYhoFPPjzAieen/a 2f3PURC9gEnhT1LfGkW3UIbLQNXdkmKnRzQyZnA1VzbtEFtV53m+fXX/79WJDH1gppHN WN4U8JRFPK9/oldTwUBSoXxnTO1AoS802Pt3x0otA5vvR5U0zLBFZW73VRqsDkmosPJ8 +nZJpj7fZPZnjdlTiz17f+weudS6unzPERHjE+zWfO3z3/kUh5vFak+Unul44jw2csMl Z7gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XbuHlJRrkK/bR8CEmoRQ17umXSJ/PvlizHx+7P5jBMw=; b=cCXHFon22HL3R/U6OkoyOqJTBrXMt6hH7Mpodaimw5r74SJaWmVgKzdYukJLRff+Ug JYfqr/uXNiAgM+AG34lJP/8rovPELGY73RgQMQWkyBs3FAAafFcZssObHKIj9WWxf14k XG0oWvaihjf1dy+vMGVQP+JcRYd39LEPKOu6QDCHDntcgBZdYT8BR/S2F6A3SoNOZoda NYxKLV0yRM1lp+sROenWPtl/MKZxqFHpQB5BVUW2WDQf5MecAt5sT4/IEvp+rX3eTl8B bAjju+g9+tkgIyrUDYDXeuTQvLafMjLAZQSMUzk5vYy8FXl+u01p6PA5Ics4qjZHzkkN ppsg== X-Gm-Message-State: ALKqPwdOpR6wb11vQEerIVxyEbZCvy0gjkUhxgs1NL94d7MNMtz31w+v gl2zGTkOkdTAhig167lkkqI= X-Received: by 2002:a37:9044:: with SMTP id s65-v6mr12968067qkd.73.1526763885605; Sat, 19 May 2018 14:04:45 -0700 (PDT) Received: from localhost.localdomain ([45.4.239.227]) by smtp.gmail.com with ESMTPSA id v86-v6sm7991193qkv.60.2018.05.19.14.04.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 May 2018 14:04:45 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 1FE5A181078; Sat, 19 May 2018 18:04:42 -0300 (-03) Date: Sat, 19 May 2018 18:04:42 -0300 From: Marcelo Ricardo Leitner To: Vlad Buslov Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 02/14] net: sched: change type of reference and bind counters Message-ID: <20180519210442.GA5488@localhost.localdomain> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-3-git-send-email-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526308035-12484-3-git-send-email-vladbu@mellanox.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 05:27:03PM +0300, Vlad Buslov wrote: > Change type of action reference counter to refcount_t. > > Change type of action bind counter to atomic_t. > This type is used to allow decrementing bind counter without testing > for 0 result. ... and in what does not testing for 0 result helps? Marcelo