Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp6005436imm; Sat, 19 May 2018 14:54:38 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoHx7J/hf/zw+STEiqReXE34Jovlxesadu3TwiJDROhTeF08xL42VaFlrxe9giC+WmU7pc3 X-Received: by 2002:a62:6402:: with SMTP id y2-v6mr14157824pfb.71.1526766878136; Sat, 19 May 2018 14:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526766878; cv=none; d=google.com; s=arc-20160816; b=ORuCuCs93EwXeNbmH2jHByR80StC1lMBGsXaC/Bv5q+2xPrYxmz8wV6/aefRrwAP0b xZb7IWozo1PW0NN7LtbGHkvVf+ZEjZRySVSdu2lKnjyJuGgXtQozFNyfRFyfN/S1Rmmu VNLy7BXAGsa+HcL7ntZmkXKjw1VhXqo1TbqaXqEKAsUWGLMH2zJaUFREhsfCwjQk95Xy i1Fip/+evmDsXXCyd9m3TuXxKRh9G1TIEbeB8iwg0xXsok3E6PomCUncEW5KGds1xHwi XLQCFevRfx2+hKlj0dhnCndVzruKJeEDGV8L89Es5uLtDE5RHMhIslgkBAY4JnM7PWKj /fwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=HvCaS+Yf+1CbvXsSl11SD8jszjI2pyjNeTK8ba2DIwc=; b=hCKd09UqmjKuLWqaWLjPruzNq2y9TasJNq+s7629CZK/E25S+jbHcvpz1fcvC3E+NX ulhxj3QlOR1d6PVbCzXPHsP1oAEYWypDUYDDceOfQXhKM+hYLPheAmWSxC5NFn8iA93H Wkog3yTEXVv/iBtckcgJQUvSHMrUxqgWXjoRCNjFVCx8/Xkds+3L4mTtCmJ9/syCJGkQ BptK9j5kz1abWVj841zKXl8VPDkpewFMqDsK+/M2gosOwqnwi5RwkPbtxNW8/4qUMB14 xjxPFTXtiQI1W+xE9OSQwJfEDRWAo9kPR+jXwgMoY+ygi5aw7yt5dE2lVeezN6lzINb7 75OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Kygr8Nxc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a92-v6si10462738pla.291.2018.05.19.14.54.12; Sat, 19 May 2018 14:54:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Kygr8Nxc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbeESVwx (ORCPT + 99 others); Sat, 19 May 2018 17:52:53 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:33020 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbeESVwv (ORCPT ); Sat, 19 May 2018 17:52:51 -0400 Received: by mail-qt0-f196.google.com with SMTP id e8-v6so14712676qth.0; Sat, 19 May 2018 14:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HvCaS+Yf+1CbvXsSl11SD8jszjI2pyjNeTK8ba2DIwc=; b=Kygr8NxcPWBqVhMPIMfF4DOA2Krp5S13m/2aUvoVh0vNeCwhHKo5Hmv9EjRfWqPTM8 93QJEsCfeTXQISkF9rWc8MZ2Vu608X+ztHkcqMgMjWMUMWYi6XNC/6KBauYkRVV5EW8g dF/aw42yaeV3czM25p+QNG0xW62BG/yBSsI8GEMyO6ejZVHBylqodc3jJNRA8HNxnCzV IJ3u5Pjg2bJjQv0bHDYxf5VGDCInPj165sHpsiEYrbk6J6sXlnZfmTubOHonRDFVh1Wd 5qDzMtcGPwz5RL3hd7lDjOw6Q8epM3GHPturnm0krgB1C22245yuzsP3fWdNLwtF2HyG fExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HvCaS+Yf+1CbvXsSl11SD8jszjI2pyjNeTK8ba2DIwc=; b=ZSmTSiAuCRIX63Oes+StnvsSYMO4pda8E09rkmxNw2LClPSMT3jJWEBaXfmBf5sRoU yarOgEGBIzeZ2ElM8HZFJN303Qz5WR5H0fyx7FP7knjw8gYy7jJW/kTucdwti+5bwGpF JJN3D4fL6PKrj0PxNMiaRlAiQEwP6S4H9gfbSuwjaLlNsz8J9q5VuJx5u+NWUQ6c6aH7 zzIT5lOjfOI/7F1DYOjohtGuNmspGFaEDjDud/Y1RyIP3e5HRGSzCL6Uto6d72DmmeWE Itr8Bu+RgOYP0PraMY4v11JEQFXvgMI+6DG8kdfXTryvJ5g55zdAKzCxAT6ao9zeoNT6 De3g== X-Gm-Message-State: ALKqPwcih7gou/BuC1ezRFNekrIB1RTH+sZmwBNccHg53lldWXZLOYgA 8le5XxUInKnJOSiz9UC8n8M= X-Received: by 2002:aed:3d87:: with SMTP id i7-v6mr13510722qtf.94.1526766770141; Sat, 19 May 2018 14:52:50 -0700 (PDT) Received: from localhost.localdomain ([45.4.239.227]) by smtp.gmail.com with ESMTPSA id e56-v6sm7975067qtc.61.2018.05.19.14.52.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 May 2018 14:52:49 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 61E23181078; Sat, 19 May 2018 18:52:46 -0300 (-03) Date: Sat, 19 May 2018 18:52:46 -0300 From: Marcelo Ricardo Leitner To: Vlad Buslov Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 09/14] net: sched: don't release reference on action overwrite Message-ID: <20180519215246.GD5488@localhost.localdomain> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-10-git-send-email-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526308035-12484-10-git-send-email-vladbu@mellanox.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote: > Return from action init function with reference to action taken, > even when overwriting existing action. Isn't this patch necessary before patch 7, to not break things up? AFAICU after patchset 7 it assumes the action init function is already behaving like this.