Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp6031228imm; Sat, 19 May 2018 15:36:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo4GEdqK9f5fGv26Hs8rMoq3/xJflU2YzwZpTWwZy1C0hftRgNYQsrpF7CXkV7qMiIZFxfO X-Received: by 2002:a17:902:57c7:: with SMTP id g7-v6mr14783690plj.222.1526769396409; Sat, 19 May 2018 15:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526769396; cv=none; d=google.com; s=arc-20160816; b=ztK7N2z2J+kLZTDUmgZE553cc56ZIExk6xKNVkkErBb/iE67UMv8O05+80Nk7M415N ZBn4koc0USbMMbiXNeewlvuS/ACmObJuGyY0YN33F80wnv6GpMVxtiEr412iak/K2xI7 /jbcP+mLB2nqceamPORStXOVQ+c5kvHYpeIUsY9sndWNJ0yp1wmeNjrZ0Q2J64pskA/q iQABuJeq9XyqwKbo1kMQ8Ro0O8GAtcwHfd/tMnQXAmPWPJWIDFkWCUyLvlChC4anf+Ph YEKozsjNsfhcEgAg+4XjboRq80ByDykMsIiBS56Vl1BKuw8Fmc58AjyBYLwMWR1/iIYr HTsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=MtpNS+YhCAiKIE1dyVscUD24MT8+HMv+P2IaoJwNwys=; b=iI8XfGQvT+XF67lOV5rLiVzBLWAStx0jsAsTO6BhpFzbTkdzu1HhlC+EEIrRJY83kN Jn01vd1RNGofKgyb2Ctaba7ExSiSw7a2gK6S1qhaHzWyBVkijNmJ59RyD7lVwkQdlNYF 4W5Iqx5KcEEcW6Ckqh9SqM4pj12mcnFt33PXsNudAHwqeJ5fuIqwDjbNWTt00KSKLawE fFIejHgKd19DwFh/8HKS0jn72p/Css0z6ty2NebWVMhiu1xaYsWFda+Od8FcBIiRQEy+ yd3ZyQODzcGq6UK2AXxQAoGBGolqN5rrXB8474OlcZn4JGZXsksZx1zUGMrdKLKws10d RXbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SG6Y/6cP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7-v6si8125084pgr.670.2018.05.19.15.36.08; Sat, 19 May 2018 15:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SG6Y/6cP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbeESWfx (ORCPT + 99 others); Sat, 19 May 2018 18:35:53 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36956 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752407AbeESWfv (ORCPT ); Sat, 19 May 2018 18:35:51 -0400 Received: by mail-qt0-f193.google.com with SMTP id q13-v6so14765005qtp.4; Sat, 19 May 2018 15:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MtpNS+YhCAiKIE1dyVscUD24MT8+HMv+P2IaoJwNwys=; b=SG6Y/6cPdGaup/S1bjNjOJOCZB8lQDeBy3DDEZU5a7rc2peHrHo5LhKBunRFrOiHJy sGk+yaTggcl7VEehDa4LGVnE2EqMaLNQ1hHxM/DY0oTTqHWySb2mpIBeljb557yHCXZp jEiX735uR1Teg4OzDv8U0AA0rVOdxgXFJOdqZbdaRtonw+8LA/BHfvjh31bDyfX8MqEj /4xYRLL/2Yvrpc2Gb/4vKmZ2gVyaSv+GfERhqv/1eKi4roMv365v3UCcAdIu7DMm1Pmm WYg/57mNyXb262ZBoe1g1yteDUQd7olTt6hdeWVSQpn1cpBaPpAJmF2lRTC2KOMwNGwQ yfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MtpNS+YhCAiKIE1dyVscUD24MT8+HMv+P2IaoJwNwys=; b=iege2WYi+c4hQ1aJzJstot/+3Fm+J8S6NuK3xINnzo7pYNYon0Fvv9pZEMcWT+8vIM vz9dfVmRy6gq9F1MoNPcYq1Al6aYz70N+fBQcwoUU68QLjNVbv2fBR3VMxFvq3FaRp25 gZfCYLVUNu/C9kNk1ZjLITq7wCcs7c2fZjFPL8kUsezIg31s0aQtjaIP55CSRqBqXAfP PNu7tV3WkRJnNXGfOz5COSWOuvEC1vxXh1JJt1zhwVck8xtwD70LS2+xC5GRnMVIG70t KTydM0rsJm1k45GE8T4zzDLVH3X0brDLdHbmGXrbvavmzKsnkzRepJ8VLwYtBzdC8k5a qzjQ== X-Gm-Message-State: ALKqPwf+nPmAwJsPCCPM5Bu0RGI0R98navJ2rEM1eP6IoT16i+l4tbTj HTjjJBg34fdOIdQB3DMcjMo= X-Received: by 2002:ac8:1a41:: with SMTP id q1-v6mr14480798qtk.191.1526769350000; Sat, 19 May 2018 15:35:50 -0700 (PDT) Received: from localhost.localdomain ([45.4.239.227]) by smtp.gmail.com with ESMTPSA id y13-v6sm7348502qti.85.2018.05.19.15.35.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 May 2018 15:35:49 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id C776C1809E3; Sat, 19 May 2018 19:35:46 -0300 (-03) Date: Sat, 19 May 2018 19:35:46 -0300 From: Marcelo Ricardo Leitner To: Jiri Pirko Cc: Vlad Buslov , netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 12/14] net: sched: retry action check-insert on concurrent modification Message-ID: <20180519223546.GG5488@localhost.localdomain> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-13-git-send-email-vladbu@mellanox.com> <20180516095953.GI1972@nanopsycho> <20180516122600.GM1972@nanopsycho> <20180516132135.GN1972@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516132135.GN1972@nanopsycho> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 03:21:35PM +0200, Jiri Pirko wrote: ... > int tcf_idr_check_alloc(struct tc_action_net *tn, u32 *index, > struct tc_action **a, int bind) Considering we don't have any other variant of it, maybe just "tcf_idr_alloc()" instead?