Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp7134580imm; Sun, 20 May 2018 19:41:49 -0700 (PDT) X-Google-Smtp-Source: AB8JxZork2FS6pvY6/GixJp1n7lcgLXJpZ2tiJs9enF/qIxEFguDLKn0cjLoUMBbZ+J8LkvXDZ/B X-Received: by 2002:a17:902:3f81:: with SMTP id a1-v6mr18379732pld.29.1526870509844; Sun, 20 May 2018 19:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526870509; cv=none; d=google.com; s=arc-20160816; b=FVNHB66s5mSKjC+DdhTZP/fq8onICGqdKCG+QtJkIHbnaJ0SGOY8i0PLPiuUQwDjTf BGAYBQ9LU4W+5s45To99Q/SGhRvFrhedtd5ooCFnllCxxs4eaMwi+heK6AbGc6Bi9t/Z 0R2OtUk3sU+K6dbfC65h7A5JlYDgCm1Sbie06PAUcWjHeeqrqU+aWkU9ufyAnwTwdfnc 4PzjT28iC65Z2BR+1QdI7ZGjt4wmx8oyG45JxC3hL/NxBwxIGs2DbZDEiZVan5gAacNN Hz+sWj6Z5TSb6+AklfoGuFHJjYwy7KgohIiTaXezU+jr5LWGZkht4rkBd7fICTWEMGrG +bow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=xcDED7NQ+Qrwzzvo4H3s5LSrLjCj3bHOSz+1ylA+Q3s=; b=dbYO78PTy6PwyoJwu1iiuBd7MmcAS1CFls/tTce4WBoKd9dA5w3z0oWLEzA81W3VNc DmX0tfU0hXetHRXoUvDCsRrvL1yny2sfOeCnNSme32bw6w2n2n8DVdxmXuOSF75XaAyk DowbpYKUtUkyMUhQ2MXZxLAt3ZJFancqgHTsVvihQNOEgNl1GSExAuIM8zXCT2v9oWHx wAHV4k4x7adkxPka4GFU5O2Yl20fR9ht64DC7B7Sil1tntoIslaePDLq4ALGs+TIss1f mThJfkFTOPrhNK3ub2ayOre4VFhKV4AaMrgurtZ6HxtiKuFzWGuCDJL1S7x5nRFs/N2/ yyGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=tIpVAsyW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 89-v6si13478947plb.154.2018.05.20.19.41.35; Sun, 20 May 2018 19:41:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=tIpVAsyW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbeEUClY (ORCPT + 99 others); Sun, 20 May 2018 22:41:24 -0400 Received: from imap.thunk.org ([74.207.234.97]:59930 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbeEUClW (ORCPT ); Sun, 20 May 2018 22:41:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xcDED7NQ+Qrwzzvo4H3s5LSrLjCj3bHOSz+1ylA+Q3s=; b=tIpVAsyWZAcxkrbn0HyuRbuYke apAf20JzmwczWjQLkiYjyylM0r8BfrOGf7n7sdoRLi7GmW/zpgclV2RA7O5rQSzj+Yq6n+l4Axcrq EoN/FfNHITaeUT1M3UyrVXaZKVngRuFIm9Vvv6yiALc2Y1e/LpNfjiO4EJiKuNhNizKU=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1fKal8-00084z-U1; Mon, 21 May 2018 02:41:15 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 007A37A4B08; Sun, 20 May 2018 22:41:09 -0400 (EDT) Date: Sun, 20 May 2018 22:41:09 -0400 From: "Theodore Y. Ts'o" To: Wang Long Cc: darrick.wong@oracle.com, jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jbd2: remove the conditional test Message-ID: <20180521024109.GF4464@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Wang Long , darrick.wong@oracle.com, jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517840679-5902-1-git-send-email-wanglong19@meituan.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517840679-5902-1-git-send-email-wanglong19@meituan.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 05, 2018 at 10:24:39PM +0800, Wang Long wrote: > kmem_cache_destroy already handles null pointers, so we can remove the > conditional test entirely. > > This patch also set NULL after the kmem_cache_destroy in function > jbd2_journal_destroy_handle_cache. > > Signed-off-by: Wang Long Thanks; I clarified the patch summary to be: jbd2: remove NULL check before calling kmem_cache_destroy() and have applied it. Apologies for not getting to this earlier. - Ted