Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp7138232imm; Sun, 20 May 2018 19:48:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqYGcgAmJg3tlt5kN9wOtlufpiFP6sKByKtaTPH6k0YL2Wz+mh0k+eU4+Zzpah9UQ6q2anE X-Received: by 2002:a62:fe0e:: with SMTP id z14-v6mr18408906pfh.73.1526870899453; Sun, 20 May 2018 19:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526870899; cv=none; d=google.com; s=arc-20160816; b=ZtrBMtSkRCv3qDF1BGlDBnPvpic/ZBcgJi8JhZUh5FfqoWc6G/YTjBzMLm01/gzuUR eYIAnRNjkZ86/b9gADangfiMAGfdqjYSqG0mYC3SSHgJ1HMF9cLT1uBxa+D7CYcKGXLj b2DfcyaMaRN6fW9FS40QbgFiRi0F1HZcuTMLISHi/F5zFzsejTZpjZOISSiHsCCskZ2T 5liawcGbaK8IisgVup9g5r8zmSWfkpY2KQupOVsBuQaHGuE5agqkk/i2Calksmo1FeBf 8FoyuKeCrb99MGyjAGteZVzFxBF0qDl38Q06Pw0VfLkyl9H08sWS9f0SREsoT9Lr+nop vKJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=h/ggNHXHp5POfehVG+40AouUbAuA42HFXqYMdGfXmSo=; b=jDUNzEdxj98sNzpw4af9SrTyqyVenjA6bQhtQE8UmkTYhACyeKt2zrcHRxbsttXuic D/0UuiAfHR+KOaR56cOmrsJjenSehO0zkDFAIhdtQ0adENTSKbnTCExC3O+47dIXAcDS 8PafUHDX1vn7bW9o6p2QjpdYUIf6aIEpxnxKK8IBeQzK7SEkLA+2Lpo9ws/70hDY58ij yduD5Pqc/o2sbrMcRuIJC60ERhZPCEkn9LVXPUc7COuosPqOsb2Dad0/+ToYwvBWa9Pq Tkv5MjAzZyfWwufyBimIgR5zrO6cJUtbYLwMBetFZ8xk2k5ASqnJTTT0v0QVVWrmivAE Mngw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=Lds4Bv1b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19-v6si4747542pgv.79.2018.05.20.19.48.04; Sun, 20 May 2018 19:48:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=Lds4Bv1b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbeEUCpf (ORCPT + 99 others); Sun, 20 May 2018 22:45:35 -0400 Received: from imap.thunk.org ([74.207.234.97]:59954 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbeEUCpd (ORCPT ); Sun, 20 May 2018 22:45:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h/ggNHXHp5POfehVG+40AouUbAuA42HFXqYMdGfXmSo=; b=Lds4Bv1bbOsyxpLuj7MP7MBFKB C5kW6zxEcCwAM+JYClBZAjbM7/CBostB0JNmjeiiAf7blu0gUufso7k7PcXrb7K7VpM+hKrWUsXNi IE5ZpJGzseOns6xrkeKSOSsPa0aI3mTrP4H7fdUDRTNQos9IN3NQ7hF3vWlZpJlg3EIo=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1fKapH-000866-6o; Mon, 21 May 2018 02:45:32 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 680E17A4B08; Sun, 20 May 2018 22:45:24 -0400 (EDT) Date: Sun, 20 May 2018 22:45:24 -0400 From: "Theodore Y. Ts'o" To: Sean Fu Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Remove unnecessary NULL checks in ext4. Message-ID: <20180521024524.GG4464@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Sean Fu , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <1517915730-11198-1-git-send-email-fxinrong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517915730-11198-1-git-send-email-fxinrong@gmail.com> User-Agent: Mutt/1.9.5 (2018-04-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 06, 2018 at 07:15:30PM +0800, Sean Fu wrote: > NULL check is done in kmem_cache_destroy. So remove NULL checks in ext4. > > Signed-off-by: Sean Fu Thanks, applied. I clarified the patch summary to be: ext4: remove NULL check before calling kmem_cache_destroy() - Ted