Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180520143933.GA9826@ravnborg.org>
References: <1526537830-22606-1-git-send-email-yamada.masahiro@socionext.com>
 <1526537830-22606-6-git-send-email-yamada.masahiro@socionext.com> <20180520143933.GA9826@ravnborg.org>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Mon, 21 May 2018 14:38:48 +0900
Message-ID: <CAK7LNATr+qHfjpYaj2h2-AcMUFozeyRDETjtJcp4kd8=DEk5dw@mail.gmail.com>
Subject: Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu
 after yyparse()
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ulf Magnusson <ulfalizer@gmail.com>,
        "Luis R . Rodriguez" <mcgrof@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Emese Revfy <re.emese@gmail.com>, X86 ML <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-05-20 23:39 GMT+09:00 Sam Ravnborg <sam@ravnborg.org>:

>> @@ -544,10 +530,10 @@ void conf_parse(const char *name)
>>       if (!modules_sym)
>>               modules_sym = sym_find( "n" );
>>
>> -     tmp = rootmenu.prompt->text;
>> -     rootmenu.prompt->text = _(rootmenu.prompt->text);
>> -     rootmenu.prompt->text = sym_expand_string_value(rootmenu.prompt->text);
>> -     free((char*)tmp);
>> +     if (!menu_has_prompt(&rootmenu)) {
>> +             current_entry = &rootmenu;
>> +             menu_add_prompt(P_MENU, "Linux Kernel Configuration", NULL);
>
> Could this be something less specific?
> To help the other users of kconfig out is the wild.
>
> For example:
>
>         menu_add_prompt(P_MENU, _("Main menu"), NULL);


OK, but this should be done as a separate work.

I am keeping the current string "Linux Kernel Configuration"


> Note, the added _() to make the text translateable.
>

Hmm, I just wonder how much helpful gettext things are...

Rather, it looks maintenance burden to me.
Once we add messages, it is difficult to change.


-- 
Best Regards
Masahiro Yamada