Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
        jgross@suse.com, konrad.wilk@oracle.com
Cc:     daniel.vetter@intel.com, matthew.d.roper@intel.com,
        dongwon.kim@intel.com,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20180517082604.14828-1-andr2000@gmail.com>
 <20180517082604.14828-2-andr2000@gmail.com>
 <6a108876-19b7-49d0-3de2-9e10f984736c@oracle.com>
From:   Oleksandr Andrushchenko <andr2000@gmail.com>
Message-ID: <9541926e-001a-e41e-317c-dbff6d687761@gmail.com>
Date:   Mon, 21 May 2018 08:40:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <6a108876-19b7-49d0-3de2-9e10f984736c@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/19/2018 01:04 AM, Boris Ostrovsky wrote:
> On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> A commit message would be useful.
Sure, v1 will have it
>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>>   	for (i = 0; i < nr_pages; i++) {
>> -		page = alloc_page(gfp);
>> -		if (page == NULL) {
>> -			nr_pages = i;
>> -			state = BP_EAGAIN;
>> -			break;
>> +		if (ext_pages) {
>> +			page = ext_pages[i];
>> +		} else {
>> +			page = alloc_page(gfp);
>> +			if (page == NULL) {
>> +				nr_pages = i;
>> +				state = BP_EAGAIN;
>> +				break;
>> +			}
>>   		}
>>   		scrub_page(page);
>>   		list_add(&page->lru, &pages);
>> @@ -529,7 +565,7 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
>>   	i = 0;
>>   	list_for_each_entry_safe(page, tmp, &pages, lru) {
>>   		/* XENMEM_decrease_reservation requires a GFN */
>> -		frame_list[i++] = xen_page_to_gfn(page);
>> +		frames[i++] = xen_page_to_gfn(page);
>>   
>>   #ifdef CONFIG_XEN_HAVE_PVMMU
>>   		/*
>> @@ -552,18 +588,22 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
>>   #endif
>>   		list_del(&page->lru);
>>   
>> -		balloon_append(page);
>> +		if (!ext_pages)
>> +			balloon_append(page);
>
> So what you are proposing is not really ballooning. You are just
> piggybacking on existing interfaces, aren't you?
Sort of. Basically I need to {increase|decrease}_reservation, not actually
allocating ballooned pages.
Do you think I can simply EXPORT_SYMBOL for {increase|decrease}_reservation?
Any other suggestion?
> -boris
>
>
Thank you,
Oleksandr