Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180520.183730.1550159916165131561.davem@davemloft.net>
References: <1526679228-1596-1-git-send-email-wang6495@umn.edu> <20180520.183730.1550159916165131561.davem@davemloft.net>
From:   Wenwen Wang <wang6495@umn.edu>
Date:   Mon, 21 May 2018 01:48:31 -0500
Message-ID: <CAAa=b7f3LA4GS18VfLouDLFYAsGifwbWb1DtMeWSGOCT64egug@mail.gmail.com>
Subject: Re: [PATCH v2] isdn: eicon: fix a missing-check bug
To:     David Miller <davem@davemloft.net>
Cc:     Kangjie Lu <kjlu@umn.edu>, Armin Schindler <mac@melware.de>,
        Karsten Keil <isdn@linux-pingi.de>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Wenwen Wang <wang6495@umn.edu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, May 20, 2018 at 5:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Wenwen Wang <wang6495@umn.edu>
> Date: Fri, 18 May 2018 16:33:47 -0500
>
>> In divasmain.c, the function divas_write() firstly invokes the function
>> diva_xdi_open_adapter() to open the adapter that matches with the adapte=
r
>> number provided by the user, and then invokes the function diva_xdi_writ=
e()
>> to perform the write operation using the matched adapter. The two functi=
ons
>> diva_xdi_open_adapter() and diva_xdi_write() are located in diva.c.
>
> This doesn't even compile:
>
> In file included from drivers/isdn/hardware/eicon/divasmain.c:30:
> drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name =E2=80=
=98diva_xdi_um_cfg_cmd_t=E2=80=99
>       int length, diva_xdi_um_cfg_cmd_t *msg,
>                   ^~~~~~~~~~~~~~~~~~~~~
> drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name =E2=80=
=98diva_xdi_um_cfg_cmd_t=E2=80=99
>         int length, diva_xdi_um_cfg_cmd_t *msg,
>                     ^~~~~~~~~~~~~~~~~~~~~

Sorry. I will correct the compilation errors and resubmit the patch.

Wenwen