Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>
CC:     John Youn <John.Youn@synopsys.com>,
        Vardan Mikayelyan <mvardan@synopsys.com>,
        Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
        Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Index: AQHT7ws4+xyvQUj0rEqQiAqvmDphzw==
Date:   Mon, 21 May 2018 08:45:35 +0000
Message-ID: <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com>
References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,=0A=
=0A=
On 5/19/2018 4:49 AM, John Stultz wrote:=0A=
> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")=0A=
> caused the HiKey board to not correctly handle switching between=0A=
> usb-gadget and usb-host mode.=0A=
> =0A=
> Unplugging the OTG port would result in:=0A=
> [   42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host re=
gisters to restore=0A=
> [   42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to r=
estore host registers=0A=
> =0A=
> And the USB-host ports would not function.=0A=
> =0A=
> And plugging in the OTG port, we would see:=0A=
> [   46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 dw=
c2_hsotg_init_fifo+0x194/0x1a0=0A=
> [   46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5-0=
0030-ge67da8c #231=0A=
> [   46.055767] Hardware name: HiKey Development Board (DT)=0A=
> [   46.055784] Workqueue: dwc2 dwc2_conn_id_status_change=0A=
> ...=0A=
> =0A=
Could you please send full log to debug.=0A=
=0A=
=0A=
> Thus, this patch sets the hisi params to disable the power_down=0A=
> flag by default, and gets thing working again.=0A=
> =0A=
> Cc: John Youn <johnyoun@synopsys.com>=0A=
> Cc: Vardan Mikayelyan <mvardan@synopsys.com>=0A=
> Cc: Artur Petrosyan <arturp@synopsys.com>=0A=
> Cc: Grigor Tovmasyan <tovmasya@synopsys.com>=0A=
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>=0A=
> Cc: linux-usb@vger.kernel.org=0A=
> Signed-off-by: John Stultz <john.stultz@linaro.org>=0A=
> ---=0A=
>   drivers/usb/dwc2/params.c | 1 +=0A=
>   1 file changed, 1 insertion(+)=0A=
> =0A=
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c=0A=
> index f03e418..96b1b25 100644=0A=
> --- a/drivers/usb/dwc2/params.c=0A=
> +++ b/drivers/usb/dwc2/params.c=0A=
> @@ -70,6 +70,7 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsot=
g)=0A=
>   		GAHBCFG_HBSTLEN_SHIFT;=0A=
>   	p->uframe_sched =3D false;=0A=
>   	p->change_speed_quirk =3D true;=0A=
> +	p->power_down =3D false;=0A=
=0A=
power_down declared as int, suggested to update as follow:=0A=
	p->power_down =3D DWC2_POWER_DOWN_PARAM_NONE;=0A=
=0A=
This can be accepted as temporary solution until we will fully debug =0A=
hibernation feature for HiKey platform.=0A=
=0A=
>   }=0A=
>   =0A=
>   static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)=0A=
> =0A=
=0A=