Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp66869imm; Mon, 21 May 2018 02:19:50 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr55pvx48EBV8tP1HwXIwHGNCAcEVORZyC5Pdw4qazWhgQk00LWDyyKUqWByU4+Lpu121/f X-Received: by 2002:a63:3681:: with SMTP id d123-v6mr7762073pga.381.1526894390545; Mon, 21 May 2018 02:19:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526894390; cv=none; d=google.com; s=arc-20160816; b=dmgc6cNuMjE8S/C7EakWY3CA/mrMTNNuMszESOeiqbFqc4aE9iOG2LP+tvr8U1XCWn V0HV+BLVCn00FkYkhyH/iEFAVLk9bbGm5fQmT1f+xsAo/MgVVxXtBnWmeK00JlF344Cd gGxQySdgbVjEAZbH5t8nwQnO0t5c1CCFCTEMlb85r69GQ+nGyp6YJn8TTq6+HHs0cMrD +4DNMBTSmCDvhGxgOql5SzuUJrOXV8oRum4JEU+MEWamAcda9zR4L0EZV6vByEofz0RF Rmj/Fin+or0V/jSgE948U2iZOEqx1n91ITHGHXnl90hkFcOYpPNhjyZ2j19NMEifvBuQ BuQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=dy3iMV8ctFCriu99Tm58mDq3yjW45y33qnjeZfAdsXU=; b=z1dmsqOnCZqmMXe3TSfPwerVY7wDSKO1ELrS83+nKIcXeWI7EDjZNuzo1Q3MkHTjqA cDu35tjHcc5l2DOf7RbM0AMWJN+FP4W8l9eDrN+gMfAz3tOkgpq2duxLiCxkv6S+6w/1 k5wOcHif9snh5NaVh4KRRjmQA8huE6OYICohrWWpjpRFwDQkMBdK1pVC2GQgUFGjNxGV nfk3F7M6EICAlwIiZXcBKZ9Vp7ltY+N790VOL0uEpffQB8a9DcRJMNh1B9/at4bW+UYa SLZFflCXZq115PTm4zPueihyEcgzQgcRHvihn4HvL/itQHxtPRy1vMFIrZjXmQ4hrWj3 mZ1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=aqWcDb6V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8-v6si10883130pgv.277.2018.05.21.02.19.36; Mon, 21 May 2018 02:19:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=aqWcDb6V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751161AbeEUJSw (ORCPT + 99 others); Mon, 21 May 2018 05:18:52 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:41910 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbeEUJSt (ORCPT ); Mon, 21 May 2018 05:18:49 -0400 Received: by mail-ot0-f195.google.com with SMTP id t1-v6so16098307oth.8; Mon, 21 May 2018 02:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dy3iMV8ctFCriu99Tm58mDq3yjW45y33qnjeZfAdsXU=; b=aqWcDb6V1yU/Xvvv351sEY06Oyq3EmNkn6B3zUnmG+Yw5hsT+Shkm6qU2qj0EiYVXg Dgw5wxabWupvMfv/XPIXPqhzEW6LLRsOS05/xgz/D9IOJdphILRxgwtnFxjDJf5y9TKO a3Vt08lCQFRPHN5dHRiIMSnx3ARwfD9/spF6Ifm1PhMnBiVjiztJq9wXq3MS/Jg90ljm nH6bFdQRAkJnYKKmN1AVl0FrfRClo/dkb2ZgtJlNtcAqza3WRuBU2YKaT06yZOfjg7/T gY41e1RFNKGxSz/nnw+hZAbo57B4NPcescWrY910v2fV7Zm/iUg0mWBl62TJBzB5iUjk 0D3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dy3iMV8ctFCriu99Tm58mDq3yjW45y33qnjeZfAdsXU=; b=P9xP2HPkzcFD/cwRmGsYj49Fa8a93xYW1y6YI6fq3FpNSMT2y9+m1VosaO9bAwl9jD g1JMb2Mpb/PLG+klHqDMsj4votJtCMZqUkkZEsfZUMwGL/zaKaxvJu0CoHR/uuQY8SJS 6meYaPm285rxwDHc1fK5kD0sS3ot3dC91LVtjPh1kuhDjJjPy80x5l3siTitA/AcZeFi MqDIDeEQykJ/nBrJ3kGDc3hxr40TlEMoQMthEtq7KeF7S0qFRrr4GN+HjH5/QHrrpLRF cGpJsRyPQKoP3waxxBAwAX0VYs9TeqLS85vF4QH8KimfRiJT1ongAMJKK3y8mTMfjmGv Qz4Q== X-Gm-Message-State: ALKqPwdUzUeAPdLUocwjAWOAk72vCdzpCltRp9oOrtr71z8Ad96HBm0N Mb7+EROL4HzkrEOpiq2c84TX3V6yyOFB95WM+JjGU8fO X-Received: by 2002:a9d:34f1:: with SMTP id t46-v6mr12213487otd.396.1526894329120; Mon, 21 May 2018 02:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.201.35.80 with HTTP; Mon, 21 May 2018 02:18:28 -0700 (PDT) In-Reply-To: <20180515163652.19980-2-jbrunet@baylibre.com> References: <20180515163652.19980-1-jbrunet@baylibre.com> <20180515163652.19980-2-jbrunet@baylibre.com> From: Martin Blumenstingl Date: Mon, 21 May 2018 11:18:28 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] clk: meson: mpll: add round closest support To: Jerome Brunet Cc: Neil Armstrong , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 15, 2018 at 6:36 PM, Jerome Brunet wrote: > Allow the mpll driver to round the requested rate up if > CLK_MESON_MPLL_ROUND_CLOSEST is set and it provides a rate closer to the > requested rate. > > Signed-off-by: Jerome Brunet Acked-by: Martin Blumenstingl I gave it a quick spin on Odroid-C1 (which uses an RGMII Ethernet PHY and the RGMII TX clock is supplied by MPLL2). the clock tree looks fine and Ethernet is still working: mpll2_div 1 1 0 249999701 0 0 mpll2 1 1 0 249999701 0 0 c9410000.ethernet#m250_sel 1 1 0 249999701 0 0 c9410000.ethernet#m250_div 1 1 0 249999701 0 0 c9410000.ethernet#fixed_div2 1 1 0 124999850 0 0 c9410000.ethernet#rgmii_tx_en 1 1 0 124999850 0 0