Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp186035imm; Mon, 21 May 2018 04:30:39 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoGXjsIK99TC6pJQ0chMDijGpJIlyjSwfp8GeIOaEBHkv+WlpcKRzI5PgJgJ7Adp5w8XDXy X-Received: by 2002:a62:dc8a:: with SMTP id c10-v6mr19744985pfl.183.1526902239852; Mon, 21 May 2018 04:30:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526902239; cv=none; d=google.com; s=arc-20160816; b=a2MdGFX0PYIbUNfwpoPUo9ZAdea2WU7oBcYIzB2j1jZGSpi9BYDRaoWmHvZQMKC4nd 4Ne3e/iDdszg1MLd0YgaUGOtP/tpwXAF38oVKUS4TWta57wOlU2ujhwsrxuJem8YdDg+ yhjhLwmXCElVcz2RXXtX+DeC+UFUBJP5UEv9q0741GHAP67YscEscI8R0B9iNcPkgYCX /7DYncnUld4V5HEn5fNxu4UksXF3vsK5uXMTIXyVJcqBguaXhQQlS9nta1xZfzaLywhq bvtIp3EmGmeEJgpOmErjUoo+GoygA9L/IwouF7R2+HUVXX89Do7YJPaA/PwGWwAaWuxQ nkrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=UKFiy4T6kJIZzjlqol7F57KqNMa6sI0BSmxMPzbMphk=; b=ek4vKGKYgceIfYdfFIWcZMN/SGWBnPq4eldZVu2r2D7EZGvcf34QZTKpw8U7/gEAdP zmwjuNNkYhIv9jnhLv06eKacu1rjihgolVLwyXyAFLckel2FKXdZ9k+ngQTA/Xgq3eWr 2UiODUojraYVGX0KivS6ULfTdxI/iFnsXbrI5zhx91G0PtSlNKuUa58F2JIgBdA3THUh iWC25Lt+SjhGSFpo3Fu6Wm034zrTeMhddIE/a6t1VYEeg75ryq66uLm86c16W7nAkgpk DxiDF6LuOKyYr5bKXc2FbYQduf00zYgPWs+M2sTGUjgXu2ljH2sn1gIhP3iOK3OnPQTa /+1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lMEej/qj; dkim=pass header.i=@codeaurora.org header.s=default header.b=N50MyTJN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7-v6si10921726pgc.14.2018.05.21.04.30.25; Mon, 21 May 2018 04:30:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lMEej/qj; dkim=pass header.i=@codeaurora.org header.s=default header.b=N50MyTJN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbeEUL03 (ORCPT + 99 others); Mon, 21 May 2018 07:26:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38510 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbeEUL0X (ORCPT ); Mon, 21 May 2018 07:26:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9B24C60C54; Mon, 21 May 2018 11:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526901982; bh=RLeKw+yUITeByQPqgWNTo/ziCo4iAaputZTsrtN9p1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lMEej/qjrXXNB8eHJ2OGP0ruTfXCD+Fb0phwKNoIfpJ0KOw/kHPebOy6se073lkiR 3U/81XMkJaALOePGl5tdc1OWKIkX48glOWOnX2jPCYxAhf1dNWcprnMAL/wYQRLFDp oDqqYjXK7BnqgRDhG/ugF8+EyoTHZl0AgMLuXXrk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from lx-ilial.mea.qualcomm.com (unknown [185.23.60.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilialin@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 064F060C54; Mon, 21 May 2018 11:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526901981; bh=RLeKw+yUITeByQPqgWNTo/ziCo4iAaputZTsrtN9p1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N50MyTJNthqGv3Xb2u/zEHXKg8w0eeKUesKc+cI6UmIRPkWY6LW0axLG4smf1ywnS H2dhlzvi9KFj7rwpvFLA0XBwjDwdVG/3RxqIMljhuoHrGoc7s9qEAnuQBYcv7ZTvCW K0f+QFWIeq6DY0lQ8In3CpWrJ+XQeLCKbBX05jYw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 064F060C54 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilialin@codeaurora.org From: Ilia Lin To: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, viresh.kumar@linaro.org, nm@ti.com, lgirdwood@gmail.com, broonie@kernel.org, andy.gross@linaro.org, david.brown@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, linux-clk@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rnayak@codeaurora.org, ilialin@codeaurora.org, amit.kucheria@linaro.org, nicolas.dechesne@linaro.org, celster@codeaurora.org, tfinkel@codeaurora.org Subject: [PATCH v9 07/15] clk: qcom: cpu-8996: Add support to switch below 600Mhz Date: Mon, 21 May 2018 14:25:24 +0300 Message-Id: <1526901932-9514-8-git-send-email-ilialin@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1526901932-9514-1-git-send-email-ilialin@codeaurora.org> References: <1526901932-9514-1-git-send-email-ilialin@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CPU clock controller's primary PLL operates on a single VCO range, between 600MHz and 3GHz. However the CPUs do support OPPs with frequencies between 300MHz and 600MHz. In order to support running the CPUs at those frequencies we end up having to lock the PLL at twice the rate and drive the CPU clk via the PLL/2 output and SMUX. So for frequencies above 600MHz we follow the following path Primary PLL --> PLL_EARLY --> PMUX(1) --> CPU clk and for frequencies between 300MHz and 600MHz we follow Primary PLL --> PLL/2 --> SMUX(1) --> PMUX(0) --> CPU clk Signed-off-by: Rajendra Nayak Signed-off-by: Ilia Lin --- drivers/clk/qcom/clk-cpu-8996.c | 25 ++++++++++++++++++++++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c index 620fdc2..ff5c0a5 100644 --- a/drivers/clk/qcom/clk-cpu-8996.c +++ b/drivers/clk/qcom/clk-cpu-8996.c @@ -68,6 +68,8 @@ enum _pmux_input { NUM_OF_PMUX_INPUTS }; +#define DIV_2_THRESHOLD 600000000 + static const u8 prim_pll_regs[PLL_OFF_MAX_REGS] = { [PLL_OFF_L_VAL] = 0x04, [PLL_OFF_ALPHA_VAL] = 0x08, @@ -95,10 +97,11 @@ enum _pmux_input { static const struct alpha_pll_config hfpll_config = { .l = 60, - .config_ctl_val = 0x200d4828, + .config_ctl_val = 0x200d4aa8, .config_ctl_hi_val = 0x006, .pre_div_mask = BIT(12), .post_div_mask = 0x3 << 8, + .post_div_val = 0x1 << 8, .main_output_mask = BIT(0), .early_output_mask = BIT(3), }; @@ -140,7 +143,7 @@ enum _pmux_input { .vco_mask = 0x3 << 20, .config_ctl_val = 0x4001051b, .post_div_mask = 0x3 << 8, - .post_div_val = 0x1, + .post_div_val = 0x1 << 8, .main_output_mask = BIT(0), .early_output_mask = BIT(3), }; @@ -181,6 +184,7 @@ struct clk_cpu_8996_mux { u8 width; struct notifier_block nb; struct clk_hw *pll; + struct clk_hw *pll_div_2; struct clk_regmap clkr; }; @@ -226,6 +230,13 @@ static int clk_cpu_8996_mux_set_parent(struct clk_hw *hw, u8 index) struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_hw(hw); struct clk_hw *parent = cpuclk->pll; + if (cpuclk->pll_div_2 && req->rate < DIV_2_THRESHOLD) { + if (req->rate < (DIV_2_THRESHOLD / 2)) + return -EINVAL; + + parent = cpuclk->pll_div_2; + } + req->best_parent_rate = clk_hw_round_rate(parent, req->rate); req->best_parent_hw = parent; @@ -237,13 +248,19 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, { int ret; struct clk_cpu_8996_mux *cpuclk = to_clk_cpu_8996_mux_nb(nb); + struct clk_notifier_data *cnd = data; switch (event) { case PRE_RATE_CHANGE: ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, ALT_INDEX); break; case POST_RATE_CHANGE: - ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, PLL_INDEX); + if (cnd->new_rate < DIV_2_THRESHOLD) + ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, + DIV_2_INDEX); + else + ret = clk_cpu_8996_mux_set_parent(&cpuclk->clkr.hw, + PLL_INDEX); break; default: ret = 0; @@ -295,6 +312,7 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, .shift = 0, .width = 2, .pll = &pwrcl_pll.clkr.hw, + .pll_div_2 = &pwrcl_smux.clkr.hw, .nb.notifier_call = cpu_clk_notifier_cb, .clkr.hw.init = &(struct clk_init_data) { .name = "pwrcl_pmux", @@ -315,6 +333,7 @@ int cpu_clk_notifier_cb(struct notifier_block *nb, unsigned long event, .shift = 0, .width = 2, .pll = &perfcl_pll.clkr.hw, + .pll_div_2 = &perfcl_smux.clkr.hw, .nb.notifier_call = cpu_clk_notifier_cb, .clkr.hw.init = &(struct clk_init_data) { .name = "perfcl_pmux", -- 1.9.1