Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp350213imm; Mon, 21 May 2018 07:04:46 -0700 (PDT) X-Google-Smtp-Source: AB8JxZomveclO0aw968lapXLbS5bSnu0pEkA0hliv9yuSY+YTg6GOn55LoyWdVcX9mWtj24R3h1H X-Received: by 2002:a17:902:2006:: with SMTP id n6-v6mr20940956pla.125.1526911486464; Mon, 21 May 2018 07:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526911486; cv=none; d=google.com; s=arc-20160816; b=TrlHTp+PfUBUm+AHNAdMUBRKLcr7pExOF5we7EjfT/tvfLRRC4O4P8F+vDBtNU/97v l1x/XCkKjMEgG2lz/xDF7poyWk93uUp12V/csg5mjoxMXKv16Z6+gwj09WdyjNxAnte5 As1Tn3vk/WyKb2IaaQYNscSx7WCNNpQVFIsXkS3L/EriYis8wWd5YCvGsWVev/VYWhpS YXtiWwiGi4k1lTEosnjf/B3QpYLn1PN7oyNh+jC06sJTKQGUwsJsMU4ii5JuU5RN3suc onup569E+CCfeZmKAnXe7bd18vyN/uDoV9tIFIplJAfQd/hCXYJ2C+qaeBQcvGNFsPuX L23g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+p2aY/aomYxBw78ObBH5qOtmffRiKvz07tUWQhPuBq0=; b=QMSLlVd0aKOt/YcELX6R7/LoAl2aQJsBvutQED9BCtDhWjekE18nhguZFy8mxuuEj4 PYcQOMjXwLfq/mLYVzW0Qf/fYR9LpdqpWCER0KXSEPOu7a6EheOmpbJZ3+kLO7bqFUIg xmk9szsbGhwRzyLsfjeLjzhCoZJU3sCIll2mcrfmmJ81KkaS99pcgeC4sR7PKW7E/Pb3 0wkzh4lnJUquuIewELfNjjeCm6WrdS2ivpr/cWXR9nX3FluoQNF5Lj1eCrw3ZN+azQz3 KDDgVr5KP7r4wq7UMFQ5/MArzfidse1vfTCONI8lb5XtJKXixaprDxyqKyQ3Cqg5Dn7i h5gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4-v6si11007447pgq.636.2018.05.21.07.04.21; Mon, 21 May 2018 07:04:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbeEUOEC (ORCPT + 99 others); Mon, 21 May 2018 10:04:02 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50624 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752572AbeEUOD6 (ORCPT ); Mon, 21 May 2018 10:03:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE4E9401DEA6; Mon, 21 May 2018 14:03:57 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F7552017D1F; Mon, 21 May 2018 14:03:57 +0000 (UTC) Date: Mon, 21 May 2018 10:03:56 -0400 From: Mike Snitzer To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, hch@infradead.org, colyli@suse.de, darrick.wong@oracle.com, clm@fb.com, bacik@fb.com, linux-xfs@vger.kernel.org, drbd-dev@lists.linbit.com, linux-btrfs@vger.kernel.org, linux-raid@vger.kernel.org, neilb@suse.com Subject: Re: [PATCH 00/13] convert block layer to bioset_init()/mempool_init() Message-ID: <20180521140348.GA19069@redhat.com> References: <20180520222558.7053-1-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180520222558.7053-1-kent.overstreet@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 21 May 2018 14:03:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 21 May 2018 14:03:57 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 20 2018 at 6:25pm -0400, Kent Overstreet wrote: > Jens - this series does the rest of the conversions that Christoph wanted, and > drops bioset_create(). > > Only lightly tested, but the changes are pretty mechanical. Based on your > for-next tree. By switching 'mempool_t *' to 'mempool_t' and 'bio_set *' to 'bio_set' you've altered the alignment of members in data structures. So I'll need to audit all the data structures you've modified in DM. Could we get the backstory on _why_ you're making this change? Would go a long way to helping me appreciate why this is a good use of anyone's time. Thanks, Mike