Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp466155imm; Mon, 21 May 2018 08:52:58 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrhM9sx5mDUayxBBCENTKme26SHffofRTXfdgu2l7KnKHuf966WVAYIy3nII51E5ulWLFYM X-Received: by 2002:a63:b601:: with SMTP id j1-v6mr12741050pgf.335.1526917978728; Mon, 21 May 2018 08:52:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526917978; cv=none; d=google.com; s=arc-20160816; b=rpljxrzRFeP4clX2bEDCy/+e+tUKNb8CURoMFbADheX27c1QaC0Otd0fwQax1O1w+d MqcszluOETezc7u0baFVaBKKxMWSwy/a0TWnc+qNv302c8gEeRQ946/iuKmD/OsGQonR FcBWNS1EJTOcmyzaMTQaTE6qGMvPiZBZTEBg/in+PfhpkpcFcEhoJBWcSg1CAqgfPfm8 09ehsiW7Je4oOsaPz+1hWUAZQlW8BZq0M2mJTJdQFw8El9lCPj6OehyBjutEn809+UT6 IZqkCXBMIvZd+30Ycp9SVtnYlcTCWFKHNmjggCm8S1qMzMbXswfXDb0wlyClo+Qw3ODN tW6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=hepnrKyC7AH0eZrSf6exYqI5L4bIAXRnJFh5lOA/rNo=; b=im/fK7gSbBAFWneoJDu4TyRHwllCVvilXNH3oI8VLwm7E+qCD5mYQ0EDlgdgStauYI yKni5d1Vh/8Cj1HfAd3/nQDAu1JVkfYOtJ++mp6wWxHX5c7r1d0GYVS84swWNMCw+1ht MIoft4UFcSQ4mUDDh4nYVq/YsajR3Myi+jLGJa71NsB37pQPONiW78e2XIoRjJQEWWHG Z1J5gcGHGRO/+ndi5KiwZZ2fOblZF4TUOUb3lOyFG8wKGksy2vnTg86nCH1q2SOmp8JE ds0QwFYwW6PYugKEal20R5RGL6oLAjRxDDYBRxhx3Rje3tFBbWSVROkkPeLqUK5rztII TThg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=k8W3ZXk+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5-v6si14580296plo.479.2018.05.21.08.52.44; Mon, 21 May 2018 08:52:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=k8W3ZXk+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbeEUPso (ORCPT + 99 others); Mon, 21 May 2018 11:48:44 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:55388 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753275AbeEUPsi (ORCPT ); Mon, 21 May 2018 11:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=hepnrKyC7AH0eZrSf6exYqI5L4bIAXRnJFh5lOA/rNo=; b=k8W3ZXk+Pkne 0dYPcfYxiDpy2mozl1hhXh2kwlR0HBoPzx3tMmBSLM7S5Obbzr578pVgaN6yzo0GC/DxZrlwk77xR 2fs+55exJ0/5GRZg+1zVjFsIRP/MWUv8urPypjBtcM+zmTMbZWTz+gEGXPN2GuCnia0uD4ksZ9ywi 19DYM=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fKn36-000132-TJ; Mon, 21 May 2018 15:48:36 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fKn36-0007Jc-EB; Mon, 21 May 2018 16:48:36 +0100 From: Mark Brown To: Mukunda@sirena.org.uk, Vijendar Cc: Vijendar Mukunda , Mark Brown , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Liam Girdwood , open list , Takashi Iwai , Jason Clinton , Mark Brown , Vijendar Mukunda , Alex Deucher , Akshu Agrawal , Guenter Roeck , alsa-devel@alsa-project.org Subject: Applied "ASoC: amd: memory release for rtd structure" to the asoc tree In-Reply-To: <1524741374-13523-7-git-send-email-Vijendar.Mukunda@amd.com> Message-Id: Date: Mon, 21 May 2018 16:48:36 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: amd: memory release for rtd structure has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From cac6f59717e1084552e509172d40d5c9d278feb9 Mon Sep 17 00:00:00 2001 From: "Mukunda, Vijendar" Date: Tue, 8 May 2018 10:17:49 +0530 Subject: [PATCH] ASoC: amd: memory release for rtd structure rtd structure freed early may result in kernel panic in dma close call back. moved releasing memory for rtd structure to the end of dma close callback. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz Signed-off-by: Mark Brown --- sound/soc/amd/acp-pcm-dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 39cd54f1b493..1c44b26ad2db 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -998,8 +998,6 @@ static int acp_dma_close(struct snd_pcm_substream *substream) DRV_NAME); struct audio_drv_data *adata = dev_get_drvdata(component->dev); - kfree(rtd); - if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { adata->play_i2ssp_stream = NULL; /* @@ -1028,7 +1026,7 @@ static int acp_dma_close(struct snd_pcm_substream *substream) */ if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream) acp_reg_write(0, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB); - + kfree(rtd); return 0; } -- 2.17.0