Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp813113imm; Mon, 21 May 2018 15:00:25 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqjqLLIPs1LfNsQfMmkDn4dXp0HUREI+5AQgD2+4sHdUuLCZYclzt0RI85QRs5D2fEr2Ymq X-Received: by 2002:a63:2bc4:: with SMTP id r187-v6mr16943661pgr.231.1526940024973; Mon, 21 May 2018 15:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526940024; cv=none; d=google.com; s=arc-20160816; b=DWHOxx5J9n8sBbrgRobBdxcgF3rLEx+qqjsDKuHmFJ034XBc0RJl1DFIP8qs1sellw xwcpmleVPrQ7EZ55/nn3ZxyfhXz3A0bKsM7zoIBuke8qwyEbYiaqRcVLM1MjZeu6PLqe vL7J+gV5jrd67Lpmbg2MyNUaqm0PfO12Ql+GHqSDQp3WpECbeTjffxG9qHxoEot6tyC5 +XsUZ66vVOytoUTdogp3BfqMHpKul6EHlLvcJ/n8IJxKgViAAGx7rogXWbac5JrtjVnH a5Tbp4trmr8I7Z2+PlwIG3h+u4cnGdTrJvg9TPJPSpgY8fnHyKotiMrLQxfe9LFJErKg GsTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature:arc-authentication-results; bh=9s9VDdf5bo+TYurPLxezDV8m3cqtc6Jud5c/Tseoq8g=; b=rGyLJ+mPCMM95XdG0zA8CuHBb+R7YWXQS2qUB7Pp8BJGbnH1tqeBzu6WtkiKEqIfeN wVAORPbOFGeSmBPnk+NQRlPpVSebY0f73dOJY/O++VJvqGq5ZP78pWIMuHb2G/oXDFEv rw/wFwG4xmVreLCVJs9E4eUjMC6Z0FABOHdSYzHvKSAClnG53+V0eFDyjKuN1H6D24yV sdeQ+VJwq1EbVYxg1P3aW46OKNsJL7WH3L8TbA432jIQaw+HFLJuJt2wSVe55qi4a+Lp eT04JyUi5OSV1R2To9Qb46Yhf4f/YkbPb/OFY4zwl2J+7WH0NIMh4nZ2acLxjaeMqooX r4wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=LV+Hse4e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2-v6si4576389plj.389.2018.05.21.15.00.10; Mon, 21 May 2018 15:00:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=LV+Hse4e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbeEUV7y (ORCPT + 99 others); Mon, 21 May 2018 17:59:54 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:38552 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754092AbeEUV7t (ORCPT ); Mon, 21 May 2018 17:59:49 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4LLu5S4176008; Mon, 21 May 2018 21:59:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2017-10-26; bh=9s9VDdf5bo+TYurPLxezDV8m3cqtc6Jud5c/Tseoq8g=; b=LV+Hse4eiQBil6UTmhUiPmIvrJa/7wxOSC5q2XYxMd2hy3+eafRiQVZ27ykd1SX7oI7A 8I1BcjGjQOZZq1YicJqk+rfl3Mf7oUlj7HFGh/eauXqaPMdWyMkfUdUqI1DsuAJBdFQX 4f89hBTh9mGvBbAquiMgrLRCOjoq0JwSQi0zoH4AVuBAknNaPZp5YUvri8asYO0TI+aB Mdl7ksOQzyzoufPMKGqGpMUpMkCa3tJjl96XgQ3GygM/TigKWbTqQJ+nFXbPBRp7ePYF BH5B0ORVZkAt+GK/KIAiLqQIgwG8cCmPn0j8VFHC0Foy0H8JCaxrxODO+PM59Q+/aQUz tA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2j2bcde4xc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 May 2018 21:59:47 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4LLxkiv015401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 May 2018 21:59:46 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4LLxjfI006933; Mon, 21 May 2018 21:59:46 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 May 2018 14:59:45 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id B7A126A00C1; Mon, 21 May 2018 17:59:44 -0400 (EDT) From: Konrad Rzeszutek Wilk To: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Fix SSBD not being exposed to guests. (v1) Date: Mon, 21 May 2018 17:54:48 -0400 Message-Id: <20180521215449.26423-1-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.13.4 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8900 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=583 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805210256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Without this patch, when launching QEMU with -cpu +ssbd I ended up with a warning seeing that the CPU does not support - which in fact it does. The issue was the X86_FEATURE_ - the kvm_cpuid_7_0_edx_x86_features had bit 17 set (X86_FEATURE_SSBD), while the right bit should have been bit 31 ( X86_FEATURE_SPEC_CTRL_SSBD). That meant the masking: entry->edx &= kvm_cpuid_7_0_edx_x86_features; would nicely clear the SSBD bit. This fixes: Fixes: 52817587e706 ("x86/cpufeatures: Disentangle SSBD enumeration") arch/x86/kvm/cpuid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Konrad Rzeszutek Wilk (1): KVM: VMX: Expose SSBD properly to guests.