Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1045963imm; Mon, 21 May 2018 20:13:01 -0700 (PDT) X-Google-Smtp-Source: AB8JxZphOSFCnCNA0B/nckd/wGOvBLFNBpk9pYDY0aUI3Me5/tWoUcCBVEINPYaFaecp7hj2wp2g X-Received: by 2002:a62:c95c:: with SMTP id k89-v6mr22235701pfg.47.1526958781449; Mon, 21 May 2018 20:13:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526958781; cv=none; d=google.com; s=arc-20160816; b=hi3CLiJ74Q4AKDB6yn6LqWHMg+SdPdGnWgeSOLvjaRDkzeCK89y/O8rT3iWaDrhSF0 /TESRG8rMZMdjA9gbxvVpMGW6wQyURTmmaOxbdFgTONefZxBW9/c3qTSxRmm08/RlZGB 48QDRkIuKNsAd8yXTvwm7D/iwj/S6hr0OE2z5aCz7+Goxfyr69py+NT23pVcwLrp9Sc7 cg2gIaVNc5junsfFiyKEzH/wCAgJbeITvJwJ+Mcsx/TOs29WBHHTSVrBFaANDMKwqOT3 BQ0s05T8dGVN+Jr/vrQ3vSKuwZnzz01j6Lbz0sdah+TJmzRn4zUOFQdrv5pL5zO4fU7S qRAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-filter :arc-authentication-results; bh=miMS/UVHdl3PRuNMdhRP91T4Izu1V7SHdTz+4ZqoxUg=; b=YO44WKUdstUNlpDt/bwLdXJe65q9gXAgTTWCZpQMQz+38YE+KmOAr+iWuEOuVk5AZd 1FomxLx2g5IUT38P4YDuDVWnxcI3FvyQxSUrByznkWyRQzF4y+KFf2rGXBiPHNKgTfRV fPlIGhrIGIAUHE8FVmxr9oSXwIlYmZf/TVB1pyJUcpvd1hzdZXiuhdXWHQTFH9uJZLbR ZlLBr3Jo/UFRSw43HHDvneXclWoNA/KXB9X6fD50DRCPlzlqvpTtCc9rTfrlEFmh/1hq dv/b1PGP7IF1zC9QHTKUDNb4GM/DSD6AjBMo7vuZ+Ajo38AV6nRjBdDcKs1sVtxrxqYx 1mmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=B35Iiiw+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92-v6si15258673plc.452.2018.05.21.20.12.46; Mon, 21 May 2018 20:13:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=B35Iiiw+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752464AbeEVDMg (ORCPT + 99 others); Mon, 21 May 2018 23:12:36 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:52385 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbeEVDMd (ORCPT ); Mon, 21 May 2018 23:12:33 -0400 Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) (authenticated) by conssluserg-05.nifty.com with ESMTP id w4M3CNJP024209; Tue, 22 May 2018 12:12:24 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com w4M3CNJP024209 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1526958744; bh=miMS/UVHdl3PRuNMdhRP91T4Izu1V7SHdTz+4ZqoxUg=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=B35Iiiw+ukShhqM/ePdJvXlfmEyg+1a47iCt//oFzM76qAMjVX/21B9KXaHGrzRgw Lcmjl2UoFdcPixiyGnkcwEgjPRFzdxN/IealD2VruBMCUYDA4YEOkbKHLHJnfy6C0T iFUGxKqIRWHIEHxy1H/2BQztEl5w9T5gfJX5G+lSBWobqX4HEawuQyQO1darZiXr51 EXDsHiL5PO2nJn+CYIIZ2dex4o3BhFKRpPtg/hJr4nj3DX9SoeWOyJm5kq3MbSIQt4 j8TgIaN4PITHBladNaxVD9UQ/2Y7W80PjYR8ZnvuxcccFosSg956HWOEmjKLVjAn+9 Wxo+WmzFPWCSw== X-Nifty-SrcIP: [209.85.213.41] Received: by mail-vk0-f41.google.com with SMTP id m144-v6so10023678vke.4; Mon, 21 May 2018 20:12:24 -0700 (PDT) X-Gm-Message-State: ALKqPwfujlxFwbC45v9e+XG6cVCz0NQycX+rBzizkkChhIYE6lJg/1Z1 rDVn2Go9YRQ4Kin2c4HZgqljlg9c/GNEYl0Jq3E= X-Received: by 2002:a1f:acc4:: with SMTP id v187-v6mr14851551vke.11.1526958743189; Mon, 21 May 2018 20:12:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.85.216 with HTTP; Mon, 21 May 2018 20:11:42 -0700 (PDT) In-Reply-To: References: <1526537830-22606-1-git-send-email-yamada.masahiro@socionext.com> <1526537830-22606-8-git-send-email-yamada.masahiro@socionext.com> <20180520145031.GB9826@ravnborg.org> From: Masahiro Yamada Date: Tue, 22 May 2018 12:11:42 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 07/31] kconfig: add built-in function support To: Ulf Magnusson Cc: Sam Ravnborg , Linux Kbuild mailing list , Linus Torvalds , "Luis R . Rodriguez" , Linux Kernel Mailing List , Nicholas Piggin , Kees Cook , Emese Revfy , X86 ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : > On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: >>> On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: >>>> Will the following be equal: >>>> >>>> $(foo,abc,$(x),$(y)) >>>> $(foo, abc, $(x), $(y)) >>>> >>>> make is rather annoying as space is significant, but there seems no good reason >>>> for kconfig to inheritate this. >>>> So unless there are good arguments consider alloing the spaces. >>>> If the current implmentation already supports optional spaces then I just missed >>>> it whie reviewing. >>>> >>>> Sam >>> >>> +1 from me. >>> >>> I also find the rules for whitespace in Make confusing, and always >>> have to look them up when doing trickier stuff. Maybe they're the >>> result of people not considering whitespace initially, and stuff >>> getting tacked on later. GNU Make adds some alternate syntaxes with >>> quotes. >>> >>> I was going to mention shell, but it looks like you already did. :) >>> >>> If we go with Make-like syntax, maybe we could at least have a variant >>> with fewer whitespace gotchas. >>> >>> Cheers, >>> Ulf >> >> Maybe it'd be a pain to implement, but something like $(foo $(x) "two >> words" "interpolated $(stuff)") seems pretty nice, with three >> arguments there. > > Guess that might interact poorly with $(shell foo "bar baz") though. > Kinda nice to have a syntax that doesn't overlap with shell when > building shell commands. Right. I can easily imagine that would end up with more gotchas due to quoting and escaping. > Still wondering if you could get rid of some of the Make gotchas > without losing other stuff... > > Cheers, > Ulf -- Best Regards Masahiro Yamada