Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared
 buffers
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Oleksandr Andrushchenko <andr2000@gmail.com>,
        alsa-devel@alsa-project.org, xen-devel@lists.xenproject.org,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, perex@perex.cz,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
References: <20180514062742.25879-1-andr2000@gmail.com>
 <20180514062742.25879-5-andr2000@gmail.com> <s5ho9hi56ds.wl-tiwai@suse.de>
 <e37b5170-4fab-0c06-8902-730e57118ceb@gmail.com>
 <s5h8t8l5ufq.wl-tiwai@suse.de>
 <19a2c003-6730-265a-29aa-1eedd37147b9@epam.com>
 <s5ho9he94s7.wl-tiwai@suse.de> <s5hh8n03gd4.wl-tiwai@suse.de>
From:   Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Message-ID: <5aaef4e5-3e9d-9170-f92d-382e4cf5ffba@epam.com>
Date:   Tue, 22 May 2018 08:25:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <s5hh8n03gd4.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: epam.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2018 05:25:33.0853 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d8ac2c70-7f4b-4a07-fdaa-08d5bfa47120
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0302MB3204
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/21/2018 11:26 PM, Takashi Iwai wrote:
> On Thu, 17 May 2018 08:26:16 +0200,
> Takashi Iwai wrote:
>> On Tue, 15 May 2018 08:02:08 +0200,
>> Oleksandr Andrushchenko wrote:
>>> On 05/15/2018 09:01 AM, Takashi Iwai wrote:
>>>> On Tue, 15 May 2018 07:46:38 +0200,
>>>> Oleksandr Andrushchenko wrote:
>>>>> On 05/14/2018 11:28 PM, Takashi Iwai wrote:
>>>>>> On Mon, 14 May 2018 08:27:40 +0200,
>>>>>> Oleksandr Andrushchenko wrote:
>>>>>>> --- /dev/null
>>>>>>> +++ b/sound/xen/xen_snd_front_shbuf.c
>>>>>>> @@ -0,0 +1,193 @@
>>>>>>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>>>>>>> +
>>>>>>> +/*
>>>>>>> + * Xen para-virtual sound device
>>>>>>> + *
>>>>>>> + * Copyright (C) 2016-2018 EPAM Systems Inc.
>>>>>>> + *
>>>>>>> + * Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>>>> + */
>>>>>>> +
>>>>>>> +#include <xen/xen.h>
>>>>>>> +#include <xen/xenbus.h>
>>>>>>> +
>>>>>>> +#include "xen_snd_front_shbuf.h"
>>>>>> Hm, with the local build test, I get the following error:
>>>>>>
>>>>>>      CC [M]  sound/xen/xen_snd_front_shbuf.o
>>>>>>      In file included from sound/xen/xen_snd_front_shbuf.c:11:0:
>>>>>>      ./include/xen/xen.h:18:8: error: unknown type name ‘bool’
>>>>>>       extern bool xen_pvh;
>>>>>>               ^~~~
>>>>>>       In file included from ./include/xen/interface/xen.h:30:0,
>>>>>>                        from ./include/xen/xen.h:29,
>>>>>>                        from sound/xen/xen_snd_front_shbuf.c:11:
>>>>>>      ./arch/x86/include/asm/xen/interface.h:92:21: error: unknown type name ‘uint64_t’
>>>>>>       DEFINE_GUEST_HANDLE(uint64_t);
>>>>>>                           ^
>>>>>> 			
>>>>>> Adding #include <linux/kernel.h> fixed the issue.
>>>>>>
>>>>>> Did you really test your patches with the latest Linus tree?
>>>>> My bad, it does build for ARM (which is my target), but also does
>>>>> need "#include <linux/kernel.h>" for x86 which I didn't build this time.
>>>>> Sorry about that.
>>>>>
>>>>> Do you want me to resend this single patch or you can make the change
>>>>> while applying?
>>>> Yes, it's fine.
>>> Thank you
>> FWIW, the patches are in topic/xen branch in sound.git tree, and I'll
>> keep boiling for a while to see if any issues are caught by 0day bot.
> ... and now the topic/xen branch got merged to for-next, targeted for
> 4.18.
>
> Thanks for your patient works!
>
>
> Takashi
Great news, thank you,
Oleksandr