Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 May 2018 09:26:30 +0200
Message-ID: <s5hlgcc1789.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Cc:     "Yisheng Xie" <xieyisheng1@huawei.com>,
        <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
        "Clemens Ladisch" <clemens@ladisch.de>
Subject: Re: [alsa-devel] [PATCH 29/33] ALSA: oxfw: use match_string() helper
In-Reply-To: <fc6c89ab-a8e7-72f8-3cd6-308f21e77995@sakamocchi.jp>
References: <1526903890-35761-1-git-send-email-xieyisheng1@huawei.com>
        <1526903890-35761-30-git-send-email-xieyisheng1@huawei.com>
        <fc6c89ab-a8e7-72f8-3cd6-308f21e77995@sakamocchi.jp>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 22 May 2018 00:26:53 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On May 21 2018 20:58, Yisheng Xie wrote:
> > match_string() returns the index of an array for a matching string,
> > which can be used intead of open coded variant.
> >
> > Cc: Clemens Ladisch <clemens@ladisch.de>
> > Cc: Jaroslav Kysela <perex@perex.cz>
> > Cc: Takashi Iwai <tiwai@suse.com>
> > Cc: alsa-devel@alsa-project.org
> > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> > ---
> >   sound/firewire/oxfw/oxfw.c | 8 +-------
> >   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> 
> For my information, use_match_string() helper was firstly introduced to
> v4.6 kernel by a commit 56b060814e2d ('lib/string: introduce
> match_string() helper').

OK, applied now.  Thanks.


Takashi