Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1280643imm; Tue, 22 May 2018 01:15:48 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpnmu+iesG0e5KwQv+7s735M7h1nhC0DGU5Xp+SlXOkMvGfgkd0WkWkKZFb9RFysfRpaXHP X-Received: by 2002:a63:be01:: with SMTP id l1-v6mr8790396pgf.382.1526976948732; Tue, 22 May 2018 01:15:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526976948; cv=none; d=google.com; s=arc-20160816; b=wDP+sL+WQeLri2FluC8Fvf74HAVQ7nEW81luUvZ1sb/WLHwmLpxv9QrvJXzTQ/t+WX B7UeybdeTCvxb00pFwS+5XjGEwwgd5j3ij3VGhq3rtUctMJ3Sap/6Qgrr+dzbrMyH+vc MxBLb3kYUqH53CSWOlWE4gTC0xvRVFYF+Dsb2Ur/sj40x/ybZ8qhAC5zFR6Nv+JuLrX1 3cyW6k4NvI4teIPD5u/xSKLmu9xQPxmfnGDp7gpSw18H1BTFG9ZtA4S9+acqk67cn1Nx ASOxlC42yo9pnOx5/UXsfDJnmzQEJfrx00XDFK45SlSr2QJ932jzDLJuEFqc2l6dqLbT Zi1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=S0QgQPN2kDMGM7bAdl9GcUSHjdiOzQK3igQq0NHBzVg=; b=N50/dliP18ZzKOPgKn78PMYHQmuABShxj7y9Vt3EpnVbSGl8gRjIeht5KyVayTCn4I dS6P5lWyA86wiu5aJ/BwBR8aQdzIYcreUuD4Pcv6DyRhaZlgLEDpgmcqQ8Ca+Ho+Gin8 qutcDpU4griXwkB+3pZC4ILTPLKGXPO65nsCMD+gIGYuVadFD/EGhfWfvMLmcheDkw3p lYvp9UUuqZGl4wxF5zEZSsamZfDHk9z/+FDFtexrFpy/dtWOZFTnIo891eaEzTwqjjud 3orqt4Uxs9pVFEew5QBw8h2jO2PLgk/cs5odnI2HRudb5/ybUTTM9WQBqhtQjsmB11SY JSpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o189-v6si15621800pfo.20.2018.05.22.01.15.33; Tue, 22 May 2018 01:15:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbeEVIPC (ORCPT + 99 others); Tue, 22 May 2018 04:15:02 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751392AbeEVIO7 (ORCPT ); Tue, 22 May 2018 04:14:59 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 812C040122A3; Tue, 22 May 2018 08:14:58 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D7F185789; Tue, 22 May 2018 08:14:55 +0000 (UTC) Date: Tue, 22 May 2018 10:14:53 +0200 From: Cornelia Huck To: Alex Williamson Cc: kwankhede@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pasic@linux.ibm.com Subject: Re: [PATCH v4 2/2] vfio/mdev: Re-order sysfs attribute creation Message-ID: <20180522101453.1b6e99ad.cohuck@redhat.com> In-Reply-To: <20180518191035.3187.77957.stgit@gimli.home> References: <20180518190145.3187.7620.stgit@gimli.home> <20180518191035.3187.77957.stgit@gimli.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 22 May 2018 08:14:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 22 May 2018 08:14:58 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 May 2018 13:10:35 -0600 Alex Williamson wrote: > There exists a gap at the end of mdev_device_create() where the device > is visible to userspace, but we're not yet ready to handle removal, as > triggered through the 'remove' attribute. We handle this properly in > mdev_device_remove() with an -EAGAIN return, but we can marginally > reduce this gap by adding this attribute as a final step of our sysfs > setup. > > Signed-off-by: Alex Williamson > --- > drivers/vfio/mdev/mdev_sysfs.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Cornelia Huck