Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 May 2018 10:37:53 +0200
From:   Jan Kara <jack@suse.cz>
To:     Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Cc:     viro@ZenIV.linux.org.uk, jra@google.com, tytso@mit.edu,
        olaf@sgi.com, darrick.wong@oracle.com,
        kernel@lists.collabora.co.uk, linux-fsdevel@vger.kernel.org,
        david@fromorbit.com, jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/15] nls: Wrap uni2char/char2uni callers
Message-ID: <20180522083753.sphuqufm5edg7dja@quack2.suse.cz>
References: <20180521173617.31625-1-krisman@collabora.co.uk>
 <20180521173617.31625-2-krisman@collabora.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180521173617.31625-2-krisman@collabora.co.uk>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 21-05-18 14:36:03, Gabriel Krisman Bertazi wrote:
> Generated with the following coccinele script:
> 
> <smpl>
> 
> @@
> expression A, B, C, D;
> @@
> (
> - A->uni2char(B, C, D)
> + nls_uni2char(A, B, C, D)
> |
> - A->char2uni(B, C, D)
> + nls_char2uni(A, B, C, D)
> )
> 
> </smpl>
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

fs/udf/unicode.c also uses char2uni and uni2char but evades your SMPL
patch. So you'll need to fix that up manually. Also note that I have some
changes to that area queued in my tree.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR