Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1350872imm; Tue, 22 May 2018 02:38:52 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrrqf5t0qUjRgAnOU+iZ/IngK45aBkGy5/eOt/Wy4qB/j0Beq1krChgPmeYjL4wkLKxTCwO X-Received: by 2002:a65:62d9:: with SMTP id m25-v6mr18476626pgv.407.1526981932506; Tue, 22 May 2018 02:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526981932; cv=none; d=google.com; s=arc-20160816; b=GMgwqEIWmxy1Y0utx53a/EuVUsMTHgJmSp7ld84lIpjAlLUGeIdc/gb2oFS0QQeURr 4s5DwE0NipIqKjYVNveH3d5FCLlSqm6yNUf487w9op8RSjmZuafyj7nKBMBNQq55PevX j6Jyd7h1Qb9hO0ionjkQC+l52aWpA7r1ZvhXatlIpC80fDw1KPKa+i8hFgIHHg87Ko9D 2Ampssg9vjcvN0MVARRyc8jOV82B3E3UCdQtefm+aKajF2Kp1aQizZB2y6KmPcxLaRni ZvUDIG9NOz3MdnPghT3AEST8e74zPjkfp8nzyFGdcUdlZRej4vfmmro2MGaNeOmgYGGw H41A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=M4INESxLyxjFPAvAEVW7iyUCKIST3o6noPHpwPPFByU=; b=V+R+ASban02gMjvxyGUamSAjUFTnEQYDDavBn8iRjS+2RIsSQuNHKyxMGmcsRqN72T AJIMIQZUt+UNcsS4hVA/EffbGlD+qmjqK/u5YKSUwa84zwsik+oDHAOPCZfnGVW+vcpi 73qtuY0ApeHiUsU9QqqqTCUFH7e6H9LDECY6ulCF4Zn1dPVrtKC56liddx3GBmEoJxDH 143puusmrnUV4SZpZJZ+S7U0awPFYFN6z5mDCmRcgCyVIYLqNfdNwwaoiEHFrUx8yQIr zmZv80kCbRQRyM55crvkJ1wefRy++NkhKS1whGeNjvpa84HhvrlotIRyz8ScZB+aruAh oPOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BswMr4tM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c74-v6si16942989pfc.224.2018.05.22.02.38.38; Tue, 22 May 2018 02:38:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BswMr4tM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbeEVJiW (ORCPT + 99 others); Tue, 22 May 2018 05:38:22 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59312 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbeEVJiR (ORCPT ); Tue, 22 May 2018 05:38:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=M4INESxLyxjFPAvAEVW7iyUCKIST3o6noPHpwPPFByU=; b=BswMr4tMVo5zL1p5T4LksIpwI L088yDallij3NvQCkGRX5lD6loQ54ejn2s0CqGjLgKH2VG/wFEZ5MTcWIeJjjleelefyLajQvMkCU r1Hcvz0eiYnXC7+Fth0cmCf8tX8CV6TKCeU66IBE50sOD7ONNHKf0Zd34QBk2Fh/N/3Dlc5QfTvAb wNy8ZxJxHa3e5g/R2R2V67dl0Hl0JQvSUfOMoXs45CL8cLNLq33nvr98rWtJqwfSsDZx9nQGczznU XTi4BnLtNdg1opFmNRVrDkTrCqvPCQk6nGE2aNsGPfd7H5NQWxmLp3fygnK9RpDTXJsdcucUSkMfj 76I0X+l6g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fL3k6-000870-8w; Tue, 22 May 2018 09:38:06 +0000 Date: Tue, 22 May 2018 02:38:06 -0700 From: Christoph Hellwig To: Huaisheng Ye Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mhocko@suse.com, willy@infradead.org, vbabka@suse.cz, mgorman@techsingularity.net, kstewart@linuxfoundation.org, alexander.levin@verizon.com, gregkh@linuxfoundation.org, colyli@suse.de, chengnt@lenovo.com, hehy1@lenovo.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-btrfs@vger.kernel.org, Huaisheng Ye , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Robin Murphy Subject: Re: [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage of address zone modifiers Message-ID: <20180522093806.GA25671@infradead.org> References: <1526916033-4877-1-git-send-email-yehs2007@gmail.com> <1526916033-4877-3-git-send-email-yehs2007@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526916033-4877-3-git-send-email-yehs2007@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This code doesn't exist in current mainline. What kernel version is your patch against? On Mon, May 21, 2018 at 11:20:23PM +0800, Huaisheng Ye wrote: > From: Huaisheng Ye > > Use __GFP_ZONE_MASK to replace (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32). > > ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP > bitmasks, the bottom three bits of GFP mask is reserved for storing > encoded zone number. > __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated by OR. If they have already been deleted the identifier should not exist anymore, so either your patch has issues, or at least the description.