Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1386915imm; Tue, 22 May 2018 03:18:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrlKaAMR2zEXEyG+6PpTfUP1XhXFRRNZPFkI6+EuCqx3s2Ftnvev42u+77HszLUhlwXeUQN X-Received: by 2002:a17:902:59ce:: with SMTP id d14-v6mr24535422plj.253.1526984320452; Tue, 22 May 2018 03:18:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526984320; cv=none; d=google.com; s=arc-20160816; b=EY8eYRTp2/ZBKe3A7q20eYUnaPiqkfYcjqgaD9WKUYOJeKnu+ZueIR5GX18+tbFMxu OFpBHkGBr+JDG9SKRHlhwLmvnO+UKAYgKO87u16vHebHo8I/d/iTUa/ciXaLe1iId6di CWVl0jY8PwvZGGqYjLj2vRnewAfKYOsPh/hWPKJcvX1qWFLuEeUBjz3LyD76v5k+EgXd /8O7CLSv65DFxPVx9xhwrLQ2JvKkW35hHShqZCOFk7R6bvuboa7ywpqtlMQ5VFqyhMWH mO4fbH6Xe1CLQ2zzYLBvzOh9ttopEm6dR4sFkIMJ8XyEdofpLKVLdOKJMyvdDmO3OHmI 9W6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=oeWQZ8f49OpYkHUvfXo7FjwJEWYpA0LcSVKkaUbhk4U=; b=HBaxV4/i7t8bOua1MEc6E7H87lwCszZMiVXsa9bruIz53zupIsX3IX2EyODU1xpvEJ L7Kt+XJcHwuJ+rpmFEAGrnWIrrOCh9O4LIDVE+rTZM+ymgQoEEHil9v4TsuxrIWG+dyT JgUojjfyDxT8K/EiACx6UXP3evkEYcuEjjSnc4B3tmuYAhcF+ttJgZd/FIHyVgLXBixF uf+Gp6iWW92auHRFSqI2gqK0MgYPSi9I/8/UOKQP/r2JkaanOrB0WsGxK7BlKDnIVWKw O0HLyNBD9h0bj2hENaHtNx/sYnSKl0LJr6mqD+V7f8dHPpNhpyr/DNEOkEyQJL7lIvNd AHgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@LenovoBeijing.onmicrosoft.com header.s=selector1-lenovo-com header.b=FUhHL0eQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lenovo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 128-v6si12687069pgb.176.2018.05.22.03.18.25; Tue, 22 May 2018 03:18:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@LenovoBeijing.onmicrosoft.com header.s=selector1-lenovo-com header.b=FUhHL0eQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=lenovo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbeEVKSM (ORCPT + 99 others); Tue, 22 May 2018 06:18:12 -0400 Received: from mail1.bemta12.messagelabs.com ([216.82.251.7]:43305 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbeEVKSI (ORCPT ); Tue, 22 May 2018 06:18:08 -0400 Received: from [216.82.251.41] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-7.bemta-12.messagelabs.com id 82/4C-32001-E5EE30B5; Tue, 22 May 2018 10:18:06 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WTf0xTVxTHe9977Xs4qo9HSc+Y1a2JicMVBfb HDS7ELFl8+xGz+AdL1DDb+dY2toX1FYGYOH7MkW1IELfiGEqnMpBUCW23oTNliLKpm251EOcc BKEblAmomA7L3N7rQ7f99znn+z3nnnNzL0NyQTqTEco9gttldhg1SyjbxChhKpomt67z3uJwS 5dfg4+Ebbip6gqNa452afClhiME9nbrsa93Pa5rqUY4MtZB46unWzR42P+3Gve0hQk8Ur8BR7 72EbhvdlyNg4GPSPxJVT3CiT8lWzx0gMCJ+HvUBh3vP+xH/KnmX2k+2JHFB+400vz05cs0/+3 BBMX3HvLT/IFr7Yjvn/2J4mfCgxq+KzRI8d/5zkkFl3bzn98v4PfGM/i7gRWvpm1R212W4vLt alt0cIYuCaaUR/dWoUo0Qb+PljAcO47g8PcPkBL0I7j4YYyQA4rtIGG0Y3jRVk/AD3P7SSUYQ TC5b0YKUhgN+zRc+GMoyTqJr7fXJk0kO09D8MwALQvp7C740h8iFFMZ9PVUSsxInAv1Q5vlNM Wugqmqc0hmLbsN4vvbFg/zIfjl5ila9qewedBWvU32INYA3psjyZYkq4dD3ma1zMCycOzMFVL hDJgce6CWSxG7GaZDRUr6Kbg3+g2lsAEirR8k1we2QQ1HEzWkEnyB4Pbc+UVXFgzGbpByI2B3 QqK3QklvBG/1AKHwCujcN0optQESuv6KUIp/OcTPr1Hys2rovHctuQvHWuBEwt6ATM3/WUHhZ 8D31R2Nwmvgs0+nyObktaTBhY/HKR+iOtFqUXDvEtymXJxtcdutNo/TbHeYcnJys52CKJqtgs NsEbPfKHYGkPSA31apUA/qbnrpLHqcIYwZ2sIouZVbaineUWEzi7bX3aUOQTyLljOMEbSv3JK 0NLdgFcrftDukX/BQBibVqNOqZFkrlpidot2qSBeRifGHGutIjnIVu4RMvfZn2cTKJlup61GL h38pggyZ6VqkUqm41BLB7bR7/q/HkJ5BxnTtdrlLqt3leXRSTBqCkIb4sT05hMf8r5RZiTbtj sy/Q7uIY5F8btlkXtPtPdGN7Mp83ctF+XmPvSA8z8zeWHjLGk4vU/2+dNPKd1V3fc9u6Z86Pb /uyRN96vU1+sboTubFhdULQ8Oesav3J8IqrqiWqFi74/pcoWgg6dKT3QVP7CHSYvrW5wqWGX6 rG6jVTbSuLTuoWUUMF752vMBIiTZzThbpFs3/AH7jxqxGBAAA X-Env-Sender: yehs1@lenovo.com X-Msg-Ref: server-10.tower-143.messagelabs.com!1526984282!7012542!1 X-Originating-IP: [104.232.225.2] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2004 invoked from network); 22 May 2018 10:18:06 -0000 Received: from unknown (HELO maesmtp01.lenovo.com) (104.232.225.2) by server-10.tower-143.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 22 May 2018 10:18:06 -0000 Received: from USEXEDGE01.lenovo.com (unknown [10.62.65.4]) by maesmtp01.lenovo.com with smtp (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-SHA) id 6b67_2526_0554d5eb_8485_4697_94ed_86baa89db884; Tue, 22 May 2018 10:17:55 +0000 Received: from APC01-HK2-obe.outbound.protection.outlook.com (65.55.88.211) by USEXEDGE01.lenovo.com (10.62.65.4) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 22 May 2018 06:17:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=LenovoBeijing.onmicrosoft.com; s=selector1-lenovo-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oeWQZ8f49OpYkHUvfXo7FjwJEWYpA0LcSVKkaUbhk4U=; b=FUhHL0eQfGTIj8NZaiAOD2F3wygC89Dtj+hAtbiVm9l2s0KM0615DsIEDB9kWMJ9rErgXkjcg1goJJxCaRol2F9tkIOXaDx4uCWKdUtchrFsu8AdRDygrFYiCb+SbYHZGO5rhUoJdjRBM9BKRyv65lTVzymgiCI6Z4wVx4SFJe4= Received: from HK2PR03MB1684.apcprd03.prod.outlook.com (10.165.178.14) by HK2PR03MB1396.apcprd03.prod.outlook.com (10.165.56.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.5; Tue, 22 May 2018 10:17:50 +0000 Received: from HK2PR03MB1684.apcprd03.prod.outlook.com ([fe80::bd0b:1233:5126:db12]) by HK2PR03MB1684.apcprd03.prod.outlook.com ([fe80::bd0b:1233:5126:db12%5]) with mapi id 15.20.0797.011; Tue, 22 May 2018 10:17:50 +0000 From: Huaisheng HS1 Ye To: Christoph Hellwig CC: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "mhocko@suse.com" , "willy@infradead.org" , "vbabka@suse.cz" , "mgorman@techsingularity.net" , "kstewart@linuxfoundation.org" , "alexander.levin@verizon.com" , "gregkh@linuxfoundation.org" , "colyli@suse.de" , "NingTing Cheng" , Ocean HY1 He , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "xen-devel@lists.xenproject.org" , "linux-btrfs@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Robin Murphy , Huaisheng Ye Subject: RE: [External] Re: [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage of address zone modifiers Thread-Topic: [External] Re: [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage of address zone modifiers Thread-Index: AQHT8bCxPP1RFiGBikCAC5+qplwdk6Q7hRrg Date: Tue, 22 May 2018 10:17:50 +0000 Message-ID: References: <1526916033-4877-1-git-send-email-yehs2007@gmail.com> <1526916033-4877-3-git-send-email-yehs2007@gmail.com> <20180522093806.GA25671@infradead.org> In-Reply-To: <20180522093806.GA25671@infradead.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.120.65.17] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HK2PR03MB1396;7:8zGa8oo1CAxYhlUzPYZAVxumxY7dLbR3wWd91Pc9Dx+Me1cBue+/MUSuxw85JmR29WrvuT0CozLk7EAF92H1IUjKn6srFxo7To5rcFEYrMQhdvpIyUbm3lEJnVe1hadTcy4wHoC/mjkdZRuYEGRBCDQJAVoSOsSBQHtpyEXoTocVBAy9u4qMups9o7WkwDNQTILKiZio9gtMFQpV/pibA7V5sXwe5beLynFsJKSmAl10RSRRPXyajIiSSQy262eg;20:55rAwjOiP44noh23CNct7TmaoVdWzjA1qFTliHxrOBy3vSc6bGdjNbPRRB2fL35WHyKVDpQmjpNEz8jsr4wGWIT5TV+kpu0JuUZd1Snyr8zrmgaBa6Emb9zbL41V/TciFQII4milUb4NNzs5cjDfywufJYjsP0zD7mMEs4PNyhLrjExk+HqQDKktSYOLg43GbvgM9jXZm0VSoHl/HRLPMGeKr+EqiHSKa3EXYa9fISOuI8mFS2GA+5+T0BHnsS8Tu9wNjuhWtPP9SjQlRPx0RXmYj+s1Nl4ZfLLmE518fauMR6qTVBlOLDrz901dxwCkgUpZCylBrnBLft1FnfGlZw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:HK2PR03MB1396; x-ms-traffictypediagnostic: HK2PR03MB1396: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(3940261145250)(788757137089); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(149027)(150027)(6041310)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:HK2PR03MB1396;BCL:0;PCL:0;RULEID:;SRVR:HK2PR03MB1396; x-forefront-prvs: 0680FADD48 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39380400002)(396003)(366004)(39850400004)(189003)(199004)(3280700002)(3660700001)(6436002)(446003)(7416002)(316002)(6916009)(54906003)(5250100002)(5660300001)(86362001)(7696005)(11346002)(229853002)(76176011)(14454004)(66066001)(2900100001)(476003)(6506007)(8936002)(2906002)(186003)(486006)(102836004)(26005)(99286004)(81156014)(81166006)(53936002)(8676002)(25786009)(68736007)(6116002)(3846002)(33656002)(97736004)(478600001)(6246003)(305945005)(7736002)(4326008)(74316002)(39060400002)(9686003)(106356001)(55016002)(105586002)(9126004)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:HK2PR03MB1396;H:HK2PR03MB1684.apcprd03.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: lenovo.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tqYgGupvna3GLYswcX6nwPcHzo0bXesaax/wjfJ/vu3K0xgcrUe2SaeOPntQjLgF74yo5UrOl3adNg4EYOUtNJi5LY7474NGRCJWYFXbKbRF8cruSoWJSliwCkG6VPqqUwQLuLqtkpY8MxmCpTogcJf/9Em608FULfCbErUsAEfQzpkZNDi26vUflL9WA2E0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 08b83da7-5735-4644-2675-08d5bfcd460a X-MS-Exchange-CrossTenant-Network-Message-Id: 08b83da7-5735-4644-2675-08d5bfcd460a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2018 10:17:50.4542 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5c7d0b28-bdf8-410c-aa93-4df372b16203 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR03MB1396 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: owner-linux-mm@kvack.org On Behalf Of Christoph Hellwig >=20 > This code doesn't exist in current mainline. What kernel version > is your patch against? >=20 > On Mon, May 21, 2018 at 11:20:23PM +0800, Huaisheng Ye wrote: > > From: Huaisheng Ye > > > > Use __GFP_ZONE_MASK to replace (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32= ). > > > > ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP > > bitmasks, the bottom three bits of GFP mask is reserved for storing > > encoded zone number. > > __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated by OR. >=20 > If they have already been deleted the identifier should not exist > anymore, so either your patch has issues, or at least the description. Dear Christoph, The kernel version of my patches against is Linux 4.16, the most of modifications come from include/Linux/gfp.h. I think they should be pushed to Linux-mm, so I follow the requirement of maintainers to make patches based on mmotm/master. I just checked the current mainline, yes, (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32) has been deleted, I can rebase my patches to mainline, and resend them to mail list. Sincerely, Huaisheng Ye