Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1621439imm; Tue, 22 May 2018 06:57:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq0bwHsVko2KRaGqjaQs8cfkyTWHFWXPZ3A4CCncsCFDRpa4HNmlz1mPvr0dg5jlvnDBiM1 X-Received: by 2002:a63:7341:: with SMTP id d1-v6mr18900599pgn.404.1526997471309; Tue, 22 May 2018 06:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526997471; cv=none; d=google.com; s=arc-20160816; b=UnAk1fofbffZbdOsK0c+2wdQyEhMM8Tu0LcVl3TjZmIcDBYa3uZDz9dWLlyXXonZU+ y0g4PEpTpJL522rHZ+WS5jdbzMMlV8Pt0srNLJbFIZNMc5RrQfgDwAWzYfpaieUBOY9o tnNm5kUId79zWY8T4rFxWglNLZxDARK0anNt7C1Sl53F3TlQi1y21BM+WSpJH6Mo8I5R wcWNtTZa6SwRqcHUVItrQsA7XI2QwCJvbSdZTLQChvddsOLMgR2JRMlQCVYv8qhvu2On V4eLJ/fyUde1PdJ/QRSvNhIgDfQgk2W4+eG54ZSYbqZUyDRSXuJFRV7mPK5pXOJsqhKr 0/2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=/k7XLcgOhDuouQOYCF28+UV5q4uwX/AThrpuXlp3WYc=; b=w40faBpLsDC3DA9cGwRlkz7/WKnEJ6e9B54sZdNmc889RrTLiOqKzXsLHhF/GVumAl g0cy6R7ZLvMnwSDM2EQzmjhO0TUB2d8Av9dxFdXZPHa8p1aS3G31nKR2jkFp9WmD2NTS AZkJZVLmbIUAnwkcvDiO9bz/P12VM04eIznHL8dv2/YyJhlHuZ1FGwn6zhhCQgFkkDLl tKZgGqW+jUX3XtaLLEo4MzqFLlb0li+JA1AQmEWMTPlzO8s2AZfmzEpJPkRCV22lzBa/ cZjas5pz3jZzi2a585jhtK0iJpznvPWy+gchRjTtMwMVlqp5ko8rqg2txDsPX9dn0+29 fhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QArkb6C1; dkim=pass header.i=@codeaurora.org header.s=default header.b=QArkb6C1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si14847226plc.574.2018.05.22.06.57.36; Tue, 22 May 2018 06:57:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=QArkb6C1; dkim=pass header.i=@codeaurora.org header.s=default header.b=QArkb6C1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751516AbeEVN5S (ORCPT + 99 others); Tue, 22 May 2018 09:57:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751236AbeEVN5P (ORCPT ); Tue, 22 May 2018 09:57:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 91A4960A06; Tue, 22 May 2018 13:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526997434; bh=01iXy5g3dM5tRWWlCTMRNLYGp9ziS3iXGIAr+TpjcDk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QArkb6C1cQdMw5OlncfTjHOTjZU3BS2NQDMJ4haWVuIKgNdDN5nVQTHeeM//PmUfZ hMG9HhQxh8NPjELmTj6QXsW66ct7avl3kiALtK8P5cwqjk/WKyLz1EWOAVjYHK3Fyx tVl5O4KCaQTDepSld6+FKDV3gcFblTeFgKEoG3QY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A82B5604D4; Tue, 22 May 2018 13:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1526997434; bh=01iXy5g3dM5tRWWlCTMRNLYGp9ziS3iXGIAr+TpjcDk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QArkb6C1cQdMw5OlncfTjHOTjZU3BS2NQDMJ4haWVuIKgNdDN5nVQTHeeM//PmUfZ hMG9HhQxh8NPjELmTj6QXsW66ct7avl3kiALtK8P5cwqjk/WKyLz1EWOAVjYHK3Fyx tVl5O4KCaQTDepSld6+FKDV3gcFblTeFgKEoG3QY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A82B5604D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ramon Fried Cc: jjohnson@codeaurora.org, linux-kernel@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Eyal Ilsar , Ramon Fried Subject: Re: [PATCH v2] wcn36xx: Add support for Factory Test Mode (FTM) References: <20180518103122.28439-1-ramon.fried@gmail.com> Date: Tue, 22 May 2018 16:57:09 +0300 In-Reply-To: <20180518103122.28439-1-ramon.fried@gmail.com> (Ramon Fried's message of "Fri, 18 May 2018 13:31:22 +0300") Message-ID: <87a7srvlmy.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ramon Fried writes: > From: Eyal Ilsar > > Introduce infrastructure for supporting Factory Test Mode (FTM) of the > wireless LAN subsystem. In order for the user space to access the > firmware in test mode the relevant netlink channel needs to be exposed > from the kernel driver. > > The above is achieved as follows: > 1) Register wcn36xx driver to testmode callback from netlink > 2) Add testmode callback implementation to handle incoming FTM commands > 3) Add FTM command packet structure > 4) Add handling for GET_BUILD_RELEASE_NUMBER (msgid=0x32A2) > 5) Add generic handling for all PTT_MSG packets > > Signed-off-by: Eyal Ilsar > Signed-off-by: Ramon Fried kbuild bot reported a warning: drivers/net/wireless/ath/wcn36xx/testmode.c:122:5: warning: 'msg' may be used uninitialized in this function [-Wmaybe-uninitialized] -- Kalle Valo