Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To:     John Stultz <john.stultz@linaro.org>,
        Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
CC:     lkml <linux-kernel@vger.kernel.org>,
        John Youn <John.Youn@synopsys.com>,
        Vardan Mikayelyan <mvardan@synopsys.com>,
        Artur Petrosyan <Arthur.Petrosyan@synopsys.com>,
        Grigor Tovmasyan <Grigor.Tovmasyan@synopsys.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Topic: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down
 feature
Thread-Index: AQHT7ws4+xyvQUj0rEqQiAqvmDphzw==
Date:   Tue, 22 May 2018 14:24:47 +0000
Message-ID: <410670D7E743164D87FA6160E7907A560131356C4E@am04wembxa.internal.synopsys.com>
References: <1526690943-8211-1-git-send-email-john.stultz@linaro.org>
 <410670D7E743164D87FA6160E7907A5601313531E1@am04wembxa.internal.synopsys.com>
 <CALAqxLVZXs97sryfPaGY5Gq50-FZROgaBADNXXadcyiNhP3EPQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,=0A=
=0A=
Please provide log with debug enabled configuration.=0A=
=0A=
On 5/21/2018 11:41 PM, John Stultz wrote:=0A=
> On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan=0A=
> <Minas.Harutyunyan@synopsys.com> wrote:=0A=
>> Hi John,=0A=
>>=0A=
>> On 5/19/2018 4:49 AM, John Stultz wrote:=0A=
>>> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down")=0A=
>>> caused the HiKey board to not correctly handle switching between=0A=
>>> usb-gadget and usb-host mode.=0A=
>>>=0A=
>>> Unplugging the OTG port would result in:=0A=
OTG port you mean MicroAB, Correct?=0A=
dwc2 driver loaded when some device connected to OTG port?=0A=
And below message printed after disconnect the device from OTG port?=0A=
=0A=
>>> [   42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host =
registers to restore=0A=
>>> [   42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to=
 restore host registers=0A=
>>>=0A=
>>> And the USB-host ports would not function.=0A=
USB-host ports - you mean 2 USB A-ports, connected to TS3USB221 HUB?=0A=
Switching ports between OTG and Host ports via TS3USB221 Switch =0A=
performing automatically or by some SW tool?=0A=
=0A=
>>>=0A=
>>> And plugging in the OTG port, we would see:=0A=
>>> [   46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 =
dwc2_hsotg_init_fifo+0x194/0x1a0=0A=
>>> [   46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5=
-00030-ge67da8c #231=0A=
>>> [   46.055767] Hardware name: HiKey Development Board (DT)=0A=
>>> [   46.055784] Workqueue: dwc2 dwc2_conn_id_status_change=0A=
>>> ...=0A=
>>>=0A=
>> Could you please send full log to debug.=0A=
> =0A=
> Full dmesg log attached.=0A=
> =0A=
> I unplugged the usb-otg port at 136=0A=
> and replugged it back in at 141=0A=
> =0A=
> =0A=
>>>        p->uframe_sched =3D false;=0A=
>>>        p->change_speed_quirk =3D true;=0A=
>>> +     p->power_down =3D false;=0A=
>>=0A=
>> power_down declared as int, suggested to update as follow:=0A=
>>          p->power_down =3D DWC2_POWER_DOWN_PARAM_NONE;=0A=
>>=0A=
>> This can be accepted as temporary solution until we will fully debug=0A=
>> hibernation feature for HiKey platform.=0A=
> =0A=
> Ok, will re-send with the suggested change above.=0A=
> =0A=
> thanks=0A=
> -john=0A=
> =0A=
=0A=