Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 May 2018 11:49:30 -0400 (EDT)
Message-Id: <20180522.114930.689064251143958449.davem@davemloft.net>
To:     shuah@kernel.org
Cc:     vladbu@mellanox.com, linux-kselftest@vger.kernel.org,
        lucasb@mojatatu.com, jhs@mojatatu.com, mrv@mojatatu.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tc-testing: flush gact actions on test teardown
From:   David Miller <davem@davemloft.net>
In-Reply-To: <11f03b6a-a8c4-e64c-7e2d-fb8218bc6320@kernel.org>
References: <1526660482-10424-1-git-send-email-vladbu@mellanox.com>
        <11f03b6a-a8c4-e64c-7e2d-fb8218bc6320@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Shuah Khan <shuah@kernel.org>
Date: Tue, 22 May 2018 09:43:28 -0600

> On 05/18/2018 10:21 AM, Vlad Buslov wrote:
>> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
>> on teardown. Leaking pipe action causes failures in other tests.
>> 
>> Add additional teardown command to also flush gact actions.
>> 
>> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
>> ---
>>  tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> index 443c9b3..acb24f7 100644
>> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> @@ -44,7 +44,8 @@
>>          "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
>>          "matchCount": "1",
>>          "teardown": [
>> -            "$TC actions flush action mirred"
>> +            "$TC actions flush action mirred",
>> +            "$TC actions flush action gact"
>>          ]
>>      },
>>      {
>> 
> 
> I can get this into 4.18-rc1 unless there is a reason for this to go
> through net tree.

Why wouldn't a networking testing bug fix go through my tree?