Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp1941428imm; Tue, 22 May 2018 11:53:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZodV3MuabFO3EVyY0rYgKPbqBZkb8ejoHK+w1PrPWKnJ8XLoOp7OQ1Oq4Yha2lqDoUV6LNO X-Received: by 2002:a17:902:1a8:: with SMTP id b37-v6mr26483989plb.326.1527015195119; Tue, 22 May 2018 11:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527015195; cv=none; d=google.com; s=arc-20160816; b=rTEdDdnQLQdeoYDb074ZaPdlGo3qe1KOgK4oy2KpFLkV16PLcb6rY43uIT+YmKnTFI loaRhToDoWf9wgJHB2xW311vYrgIRzF9aDjfLp9SgaI4kreBFOejPos/LIg0CVoY7z7L KhSO1GtLJzvtK9iCbLMrWwTOK77/iZJ8Bodr3BJHZhwRNm2iieeaUWVJUNkQFglYGqq7 Ddpd/rlW10HPY1qwKKKr0Xk1N+7Vj30oLdQ0aF+ShsNYp5Bn/FjJon4USfIiKs7VlFwE iSTwCQLhhSaKt/GLex5436quhuPkXHGJ7tRTbwKAGq0nPuwULn8uJeZ6KqnKEtu6GUv5 KoSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=HSk7wABFVM9FFhWia2ChrPsxsGFON5n+7lfhSa4nCSk=; b=rcf5VzBywEsCSgJDBqxkNNR/mI09du/XWxWGCQ33fV38MfH3JEsSqn08GI7dZPDn2B t6pjCvtC3vw30j6VcAD1gKvMImHPXkFtZIpsrHqixEaC4fO3GZA4sYhUT4DqlZytxHwR 9ExLNSV53nGeFyNewblPiO3VeHBT4Xau5MBCwPw9CxMDrPU+0u6pv+Ah7HY3sV8n4m7A DCF/Vsi0wpX/PQ+XrbV7Mnv35qw6tc3q0wVSTXg5OqdnAy0EVuQ4+DMpzGmSRVpFVOvt ZBklzMgYmouW2hR8aCt9Zu7gJ+aWH5DkpPAPkAGobKXmXlGbjJI6Bo2eP9Je2zc8J6wZ 3OJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=pX9uGq2N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12-v6si10797073pgf.653.2018.05.22.11.52.59; Tue, 22 May 2018 11:53:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=pX9uGq2N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbeEVSvt (ORCPT + 99 others); Tue, 22 May 2018 14:51:49 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:37784 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbeEVSvr (ORCPT ); Tue, 22 May 2018 14:51:47 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4MIkOYS186342; Tue, 22 May 2018 18:50:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=HSk7wABFVM9FFhWia2ChrPsxsGFON5n+7lfhSa4nCSk=; b=pX9uGq2NeOZioFBf9Xt8tJIV/JoJNjUUbVB360DDsK0/W4Ey6E+pdI5VLU3Q9ncURUSX WBQKeXYupHqwBrN1XodbYso5OZAJTxoyVBZnlOSrGw87mwgmI8TqcK51jvUhiBhH2q++ 7GQ1LdnVjQglNxxlWWQfJzR7mi4G0areLnEj/GU9ix1kszLpfI/p/jnOa4QmMblh+2sU WnJASmkoS5ET1kCr6hzD0IDN7y1wI1dbadZwP/G5nBOSe8Fn6EXIgZgtsFH9BxjZ1m5E 5GDgpL/IDqTFlU4wt9Ph/50xTf/GfRz+bysGJ1zhSW8vitmMBWd04pt3gQ+vNeGAELtP IQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2j4nh791ey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 May 2018 18:50:50 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4MIonWL013473 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 May 2018 18:50:49 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w4MIokhH014085; Tue, 22 May 2018 18:50:47 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 May 2018 11:50:46 -0700 To: Christoph Hellwig Cc: Kees Cook , Jens Axboe , "Martin K. Petersen" , James Bottomley , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180522181512.39316-1-keescook@chromium.org> <20180522181512.39316-4-keescook@chromium.org> <20180522183613.GA3784@infradead.org> Date: Tue, 22 May 2018 14:50:43 -0400 In-Reply-To: <20180522183613.GA3784@infradead.org> (Christoph Hellwig's message of "Tue, 22 May 2018 11:36:13 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8901 signatures=668700 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=851 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805220198 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > On Tue, May 22, 2018 at 11:15:09AM -0700, Kees Cook wrote: >> Both SCSI and ATAPI share the sense header. In preparation for using the >> struct scsi_sense_hdr more widely, move this into a separate header and >> move the helper function to scsi_ioctl.c which is linked with CONFIG_IDE >> by way of CONFIG_BLK_SCSI_REQUEST. > > Please keep the code where it is and just depend on SCSI on the legacy > ide driver. No need to do gymnastics just for a legacy case. Yup, I agree. -- Martin K. Petersen Oracle Linux Engineering