Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp69122imm; Tue, 22 May 2018 14:09:20 -0700 (PDT) X-Google-Smtp-Source: AB8JxZobBnHTubF9G0uHj0auiFou9A3zVpmjKaSQcb9GGJomLSbnIihU5mbbrRqEv5i2TiwWDUZt X-Received: by 2002:a17:902:6a85:: with SMTP id n5-v6mr97369plk.288.1527023360435; Tue, 22 May 2018 14:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527023360; cv=none; d=google.com; s=arc-20160816; b=AEQo9zBFdWFX+uTQEC9Jmaloh8HAhbHr8qY65I1OUFIkkLqiU7AeGcrbo2GP8bkz/m Z9n5pR9/1T3Wd5rWn0NPhtrX9JUJWaXLfsrsizjZbnnUlmrrAHFV0Qy9D898RvTv1hD9 dXvyzV37wVm7XpsOI8KFOH+ZRRCTgADd8YMUrhNN7EYrXW0fuBOBSXn4m4mJmb700Bgm +XGZcmxmfu2uh1AvYPXyV83Wb4/oN/4VCO1Mk0hbX144NDkrOvN0U+ncv3wKlaCNVLix O3Gy8y7+DWArqPsWB+WUv9sSZRbZ+/BuXQwyxtAnHN5YDoeHbDNMPfIixkRt0/JJznj4 jNGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=gxVh8BlqNuhICPQycRDOjmhMKMFE+THBV84sAwv2MiM=; b=vWntnq4Bvkh3iGiHgjESrPvor/bLXfQcwmPSSsNuwPbDyJoOsZJGGygq1K3UUPyXcr KElb0YKmqLjIt7YmMIoDV+fK2ZD4raj5r2TF5VOdRuQj70mmZ+g3ojUmmeHqTVQoNfN1 w9/jIm73DzmEf9P8hduJKI5Eawerr8B2EbEH0okrcbGJGqv5QmfMEnOj+IuDPL1IRFeo M/rkflhkqKIE/s3E7qbpOkNbQGpe6HHI6mtPgOIc7Qq6diPskNcUQyvUdrrkt4ryXQ+X E8huzVBuT/GQE//odPXSxLU6mhy3BkWXnnWr9BKj+cwgo4ecIpgBg68anZH0ZxD5jVJB SKYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k14-v6si13780093pgs.418.2018.05.22.14.09.05; Tue, 22 May 2018 14:09:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbeEVVHh (ORCPT + 99 others); Tue, 22 May 2018 17:07:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43156 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbeEVVHg (ORCPT ); Tue, 22 May 2018 17:07:36 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4246D147F; Tue, 22 May 2018 21:07:36 +0000 (UTC) Date: Tue, 22 May 2018 14:07:35 -0700 From: Andrew Morton To: Andrey Ryabinin Cc: David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Potapenko , Dmitry Vyukov , "open list:KASAN" Subject: Re: [PATCH v2 2/2] kasan: fix memory hotplug during boot Message-Id: <20180522140735.71dcd92e7b013629a7f15f91@linux-foundation.org> In-Reply-To: <09c36096-f8c8-b9e9-0bed-113e494f159a@virtuozzo.com> References: <20180522100756.18478-1-david@redhat.com> <20180522100756.18478-3-david@redhat.com> <09c36096-f8c8-b9e9-0bed-113e494f159a@virtuozzo.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 May 2018 22:50:12 +0300 Andrey Ryabinin wrote: > > > On 05/22/2018 07:36 PM, David Hildenbrand wrote: > > On 22.05.2018 18:26, Andrey Ryabinin wrote: > >> > >> > >> On 05/22/2018 01:07 PM, David Hildenbrand wrote: > >>> Using module_init() is wrong. E.g. ACPI adds and onlines memory before > >>> our memory notifier gets registered. > >>> > >>> This makes sure that ACPI memory detected during boot up will not > >>> result in a kernel crash. > >>> > >>> Easily reproducable with QEMU, just specify a DIMM when starting up. > >> > >> reproducible > >>> > >>> Signed-off-by: David Hildenbrand > >>> --- > >> > >> Fixes: fa69b5989bb0 ("mm/kasan: add support for memory hotplug") > >> Acked-by: Andrey Ryabinin > >> Cc: > > > > Think this even dates back to: > > > > 786a8959912e ("kasan: disable memory hotplug") > > > > Indeed. Is a backport to -stable justified for either of these patches?