Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp216397imm; Tue, 22 May 2018 17:21:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZorKWrTs/QF/TGC27BTWUBQqavpeOezupJz1/Db3C6LUffn/9EgUrWU9QDXlddBd5Ap4kJM X-Received: by 2002:a63:18a:: with SMTP id 132-v6mr511081pgb.344.1527034875522; Tue, 22 May 2018 17:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527034875; cv=none; d=google.com; s=arc-20160816; b=FNXgJJjbju9Fi+KUognDp+NZ+0/nYbmoSSZBeyHrf0jvd31tvusRe35VW3bbZYjrFm frFn9Q3ZGMB7PZUCSy/aCb/Opjf3NfmDRJ59SQs8PbDsbduMPjkMQUWNM8oDCQeLEQY7 /QAUNnjS23CWu3SlTxJx/I2FgvK7VQcG96+rDXhN6cJJ9urry+tlYdo+az8Rtvnuwbed vMNuPDKrKBYIgGNIws3m4euRwvonqGZ4tDJidof+2s54WWZRiChXB06tlsFPkx/ody1J qYzfbLlK4HEl5XKtrwuENXJR6vg9En8y21FRMllTUoUYs+jz/Qj7C0+EUgbyAmz6kquT X0KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Ktrbc40kvjwgOags73NvDixKtN2UxiPzBIT/I0i44tQ=; b=kO1/maRC5Lz54+gv9ro5tAdR0S0k3AMSXBLCGLhizGYF3voyyefG423Jyed6xVLcHp 83fF3vt3nFFRP90JfvCfFQkYrCUk2IK+xaSi4hosCWQvdSQ8vgwQt356azHpSPURHtib pt8g4ZSCWdEwi7li8azyBP+Z+OL+MZBNRbS9RUEZFRfyOmEes1b9z8+X4UvaKNbctgB+ ESh9JUa2QQ0Hxv81RNU4A52lpWMt2sHUxeEXiAwNIuYvvq5wAFt3ZD3Asz7YJts+Gg7Q u8Moo0cJN9O3b+oBl+77tClrWz0mwpB9ypyZK1/RUTLxANraSzqX6C87CmDxCy08niCe R+rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5-v6si17444370pfb.314.2018.05.22.17.21.01; Tue, 22 May 2018 17:21:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbeEWATr (ORCPT + 99 others); Tue, 22 May 2018 20:19:47 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:38920 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbeEWATq (ORCPT ); Tue, 22 May 2018 20:19:46 -0400 Received: by mail-pl0-f67.google.com with SMTP id c19-v6so11870785pls.6 for ; Tue, 22 May 2018 17:19:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ktrbc40kvjwgOags73NvDixKtN2UxiPzBIT/I0i44tQ=; b=KTRl0SBh1SRWr4bvK5QQxX0CbkV8bmltZqyD9fsU3o91nX0tmtipNI5vnS6w/PWcp2 AgE8p97EpF9wcMdm9U3j9CJsR54AgBjFkD3rahqm1ewHXrCgf0TL7I6GS0uOWuMPzNXg U/BcoxMR2sUSRFusSqY//pgQ2A3c740AuEUhdLrmHI4VrFeSXXGTubfcHGGZLv2XGsCz 7gjw4/BCKsFaaoCzegDeTgw+UUb6NYoPgWdKnviAneZ7Ew2GXaLs+kly1Bp/G6WPhyFm ExkG+WzafzM4CtGlbbFzk1hso5agXm8heUswHJdanlvKA2qe9Ewt7rq/8iM24HSo4zo2 jilw== X-Gm-Message-State: ALKqPwfvHD7qIYwvm0WBq1B0A39rOpDpcoUBi5+K1jsBbrZ6K3znbu6m uHq9U9S8HFjxEdzCoiPO3iKBAA== X-Received: by 2002:a17:902:bb93:: with SMTP id m19-v6mr632319pls.74.1527034785791; Tue, 22 May 2018 17:19:45 -0700 (PDT) Received: from localhost.net ([2601:602:9802:a8dc::4dc5]) by smtp.gmail.com with ESMTPSA id 206-v6sm29303145pfy.51.2018.05.22.17.19.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 May 2018 17:19:44 -0700 (PDT) From: Laura Abbott To: Andy Lutomirski , mjw@fedoraproject.org, "H . J . Lu" , Masahiro Yamada Cc: Laura Abbott , Linus Torvalds , X86 ML , linux-kernel@vger.kernel.org, Nick Clifton , Cary Coutant , linux-kbuild@vger.kernel.org Subject: [PATCHv3 0/2] Salted build ids via linker sections Date: Tue, 22 May 2018 17:19:37 -0700 Message-Id: <20180523001939.9431-1-labbott@redhat.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is v3 of the series to allow unique build-ids in the kernel. As a reminder of the context: "" In Fedora, the debug information is packaged separately (foo-debuginfo) and can be installed separately. There's been a long standing issue where only one version of a debuginfo info package can be installed at a time. Mark Wielaard made an effort for Fedora 27 to allow parallel installation of debuginfo (see https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo for more details) Part of the requirement to allow this to work is that build ids are unique between builds. The existing upstream rpm implementation ensures this by re-calculating the build-id using the version and release as a seed. This doesn't work 100% for the kernel because of the vDSO which is its own binary and doesn't get updated. After poking holes in a few of my ideas, there was a discussion with some people from the binutils team about adding --build-id-salt to let ld do the calculation debugedit is doing. There was a counter proposal made about adding some extra information via a .comment which will affect the build id calculation but just get stripped out. "" I mentioned in the previous version that there were problems with sporadic build failures. v3 switches to generating the linker script directly instead of a header + a linker script to avoid this problem. I also dropped the Kconfig completely (I can add it back as a guard if this seems not small enough to want all the time). I've also dropped the RFC tag since it's well formed enough at this point. Laura Abbott (2): kbuild: Introduce build-salt linker script x86/vdso: Add build salt to the vDSO Makefile | 4 +++- arch/x86/entry/vdso/Makefile | 4 +++- scripts/.gitignore | 1 + scripts/Makefile | 9 ++++++++- scripts/gensalt | 22 ++++++++++++++++++++++ scripts/link-vmlinux.sh | 3 ++- 6 files changed, 39 insertions(+), 4 deletions(-) create mode 100755 scripts/gensalt -- 2.17.0