Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp493194imm; Wed, 23 May 2018 00:05:55 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpCNmGA+lw5l7ndOLz9Z0BzLHSA+hk5n1/IjFfhWu0RJqr+akuaRzxlb+Ur11GSziE7CS/o X-Received: by 2002:a62:5959:: with SMTP id n86-v6mr1668030pfb.217.1527059155084; Wed, 23 May 2018 00:05:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527059155; cv=none; d=google.com; s=arc-20160816; b=Y2MTNw4F7ifvx8Lh2rthYBvCZ5dOE2+xBEAHOz4bCIvUODo1Uut69iZd9Rbu3nNCAo ZpIh8LbvB6VqhQnJ9zXUW3p9mVFYQoC50RfKPUwi7jumKU6ZrgxYn0ExwRhpSdTUNodr MVZtuWWjncrMFAKQDuDiHuniWCReXEeUkeln/nC2dGVzaudVXdTJ/Y8S925u+1IRakBk 8lcIfhHVNNWAWEv0kh1KBGR4tf8yNno1ZZfHE5dGKg6VKCnbppIOkrnVXq74vipIKgdw wkHqata6bP9bjJynrEHDt5x/VhOhYnYYXCKcSWyBv7lt0SvYNBTMncAds5N5Mgr2v0dV qzHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=RgChF2ramynf7v4wk4PYZie00L5kZj2hIOpM71pzO0Y=; b=f+59PkAB0HWZyIEAmotm4vyclKmmV5EAd7Y/RQJZ4VLMTfnLauCc5lE41D4AaZ1gsi wJ6dEJFRZIBHBrHkaVXsrOHRr0IJ1hdyEPjVBh1xRhCnecGx4NB9sMOZtIAhamNKRqN3 3XDG6PVs5Ovsegom7qCFHEsVpXKnLFb7oLL9LOFbOkSh9A5JhYZfeTTfsjPq3vNobIZF SbzyaNsJlv5rVPkhGpvVOEFff7PJah63bF5h+7QdCcbphubXG4iokP/3rANvjs6rQ4zJ 1EFdT4D5CJ80G6wZD75uhXQIQ5SK/86LsUazs0T8rvcB9mMw0sSzI/IxVcuyxd1F6Jng 2jdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g3bu7I2l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65-v6si18216723pfo.229.2018.05.23.00.05.40; Wed, 23 May 2018 00:05:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g3bu7I2l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754339AbeEWHFI (ORCPT + 99 others); Wed, 23 May 2018 03:05:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:45590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754286AbeEWHFG (ORCPT ); Wed, 23 May 2018 03:05:06 -0400 Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B5B32087C; Wed, 23 May 2018 07:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527059105; bh=x85tWNaughDTluVu+NE4qAoGtX1dgmNBSoHth3WBZVo=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=g3bu7I2lqdtwEpBb+k+OJCx4qDqKaysHSIg5VyllybNgZ0gpaSS7YPTvOJDKNE9RT A0BoIEw0x4eR9jtab2WD8bSPndSZwSFC+H9s/Mmn0BymW9JpbxWAvtiUrXfbYvxdVS f+1Kv3RzKLuRw0w1h7tEl1CcN0jsPfxn1Y4QejC8= Received: by mail-wm0-f44.google.com with SMTP id j5-v6so6060808wme.5; Wed, 23 May 2018 00:05:05 -0700 (PDT) X-Gm-Message-State: ALKqPwegXDWG+n8nY0Ed2qjfTrfHRI7jEU+fTKJmOuWlcBCnQ+3DuR4x jGuFHlu/7vOa2mMO0BfJwZ6EZ57IAlNShA4VGgM= X-Received: by 2002:a1c:8a03:: with SMTP id m3-v6mr2955517wmd.135.1527059103673; Wed, 23 May 2018 00:05:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:c552:0:0:0:0:0 with HTTP; Wed, 23 May 2018 00:05:02 -0700 (PDT) In-Reply-To: References: <1526543103-21668-1-git-send-email-krzk@kernel.org> From: Krzysztof Kozlowski Date: Wed, 23 May 2018 09:05:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 1/3] ARM: dts: tegra: Remove skeleton.dtsi and fix DTC warnings for /memory To: Stefan Agner Cc: Rob Herring , Mark Rutland , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Ziswiler , Lucas Stach Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 17, 2018 at 1:39 PM, Stefan Agner wrote: > On 17.05.2018 09:45, Krzysztof Kozlowski wrote: >> Remove the usage of skeleton.dtsi and add necessary properties to /memory >> node to fix the DTC warnings: >> >> arch/arm/boot/dts/tegra20-harmony.dtb: Warning (unit_address_vs_reg): >> /memory: node has a reg or ranges property, but no unit name >> >> The DTB after the change is the same as before except adding >> unit-address to /memory node. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v4: >> 1. None >> --- >> arch/arm/boot/dts/tegra114-dalmore.dts | 3 ++- >> arch/arm/boot/dts/tegra114-roth.dts | 3 ++- >> arch/arm/boot/dts/tegra114-tn7.dts | 3 ++- >> arch/arm/boot/dts/tegra114.dtsi | 4 ++-- >> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 ++- >> arch/arm/boot/dts/tegra124-apalis.dtsi | 3 ++- >> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 3 ++- >> arch/arm/boot/dts/tegra124-nyan.dtsi | 3 ++- >> arch/arm/boot/dts/tegra124-venice2.dts | 3 ++- >> arch/arm/boot/dts/tegra124.dtsi | 2 -- >> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 3 ++- >> arch/arm/boot/dts/tegra20-harmony.dts | 3 ++- >> arch/arm/boot/dts/tegra20-paz00.dts | 3 ++- >> arch/arm/boot/dts/tegra20-seaboard.dts | 3 ++- >> arch/arm/boot/dts/tegra20-tamonten.dtsi | 3 ++- >> arch/arm/boot/dts/tegra20-trimslice.dts | 3 ++- >> arch/arm/boot/dts/tegra20-ventana.dts | 3 ++- >> arch/arm/boot/dts/tegra20.dtsi | 7 +++++-- >> arch/arm/boot/dts/tegra30-apalis.dtsi | 5 +++++ >> arch/arm/boot/dts/tegra30-beaver.dts | 3 ++- >> arch/arm/boot/dts/tegra30-cardhu.dtsi | 3 ++- >> arch/arm/boot/dts/tegra30-colibri.dtsi | 3 ++- >> arch/arm/boot/dts/tegra30.dtsi | 7 +++++-- >> 23 files changed, 53 insertions(+), 26 deletions(-) >> >> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts >> b/arch/arm/boot/dts/tegra114-dalmore.dts >> index eafff16765b4..5cdcedfc19cb 100644 >> --- a/arch/arm/boot/dts/tegra114-dalmore.dts >> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts >> @@ -23,7 +23,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> reg = <0x80000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra114-roth.dts >> b/arch/arm/boot/dts/tegra114-roth.dts >> index 7ed7370ee67a..b4f329a07c60 100644 >> --- a/arch/arm/boot/dts/tegra114-roth.dts >> +++ b/arch/arm/boot/dts/tegra114-roth.dts >> @@ -28,7 +28,8 @@ >> }; >> }; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> /* memory >= 0x79600000 is reserved for firmware usage */ >> reg = <0x80000000 0x79600000>; >> }; >> diff --git a/arch/arm/boot/dts/tegra114-tn7.dts >> b/arch/arm/boot/dts/tegra114-tn7.dts >> index 7fc4a8b31e45..12092d344ce8 100644 >> --- a/arch/arm/boot/dts/tegra114-tn7.dts >> +++ b/arch/arm/boot/dts/tegra114-tn7.dts >> @@ -28,7 +28,8 @@ >> }; >> }; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> /* memory >= 0x37e00000 is reserved for firmware usage */ >> reg = <0x80000000 0x37e00000>; >> }; >> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi >> index 0e4a13295d8a..b917784d3f97 100644 >> --- a/arch/arm/boot/dts/tegra114.dtsi >> +++ b/arch/arm/boot/dts/tegra114.dtsi >> @@ -5,11 +5,11 @@ >> #include >> #include >> >> -#include "skeleton.dtsi" >> - >> / { >> compatible = "nvidia,tegra114"; >> interrupt-parent = <&lic>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> >> host1x@50000000 { >> compatible = "nvidia,tegra114-host1x", "simple-bus"; >> diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi >> b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi >> index bb67edb016c5..80b52c612891 100644 >> --- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi >> +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi >> @@ -15,7 +15,8 @@ >> compatible = "toradex,apalis-tk1-v1.2", "toradex,apalis-tk1", >> "nvidia,tegra124"; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x0 0x80000000 0x0 0x80000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi >> b/arch/arm/boot/dts/tegra124-apalis.dtsi >> index 65a2161b9b8e..3ca7601cafe9 100644 >> --- a/arch/arm/boot/dts/tegra124-apalis.dtsi >> +++ b/arch/arm/boot/dts/tegra124-apalis.dtsi >> @@ -50,7 +50,8 @@ >> model = "Toradex Apalis TK1"; >> compatible = "toradex,apalis-tk1", "nvidia,tegra124"; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x0 0x80000000 0x0 0x80000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> b/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> index 6dbcf84dafbc..8d9e6ee6c6a7 100644 >> --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts >> @@ -24,7 +24,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x0 0x80000000 0x0 0x80000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi >> b/arch/arm/boot/dts/tegra124-nyan.dtsi >> index 3609367037a6..15a2b0e3237e 100644 >> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi >> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi >> @@ -13,7 +13,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x0 0x80000000 0x0 0x80000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts >> b/arch/arm/boot/dts/tegra124-venice2.dts >> index 89bcc178994d..241cdc4b6600 100644 >> --- a/arch/arm/boot/dts/tegra124-venice2.dts >> +++ b/arch/arm/boot/dts/tegra124-venice2.dts >> @@ -18,7 +18,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x0 0x80000000 0x0 0x80000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi >> index 174092bfac90..df1642876a4c 100644 >> --- a/arch/arm/boot/dts/tegra124.dtsi >> +++ b/arch/arm/boot/dts/tegra124.dtsi >> @@ -7,8 +7,6 @@ >> #include >> #include >> >> -#include "skeleton.dtsi" >> - >> / { >> compatible = "nvidia,tegra124"; >> interrupt-parent = <&lic>; >> diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> b/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> index 5c202b3e3bb1..305efb275b48 100644 >> --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi >> @@ -10,7 +10,8 @@ >> rtc1 = "/rtc@7000e000"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x20000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-harmony.dts >> b/arch/arm/boot/dts/tegra20-harmony.dts >> index 628a55a9318b..5009a55ae15c 100644 >> --- a/arch/arm/boot/dts/tegra20-harmony.dts >> +++ b/arch/arm/boot/dts/tegra20-harmony.dts >> @@ -18,7 +18,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts >> b/arch/arm/boot/dts/tegra20-paz00.dts >> index 30436969adc0..e794ac5442ef 100644 >> --- a/arch/arm/boot/dts/tegra20-paz00.dts >> +++ b/arch/arm/boot/dts/tegra20-paz00.dts >> @@ -19,7 +19,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x20000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts >> b/arch/arm/boot/dts/tegra20-seaboard.dts >> index 284aae351ff2..6cb832cfa4f3 100644 >> --- a/arch/arm/boot/dts/tegra20-seaboard.dts >> +++ b/arch/arm/boot/dts/tegra20-seaboard.dts >> @@ -18,7 +18,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-tamonten.dtsi >> b/arch/arm/boot/dts/tegra20-tamonten.dtsi >> index 872046d48709..6ceb1228fed3 100644 >> --- a/arch/arm/boot/dts/tegra20-tamonten.dtsi >> +++ b/arch/arm/boot/dts/tegra20-tamonten.dtsi >> @@ -15,7 +15,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x20000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-trimslice.dts >> b/arch/arm/boot/dts/tegra20-trimslice.dts >> index d55c6b240a30..3f94be3da9e5 100644 >> --- a/arch/arm/boot/dts/tegra20-trimslice.dts >> +++ b/arch/arm/boot/dts/tegra20-trimslice.dts >> @@ -18,7 +18,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20-ventana.dts >> b/arch/arm/boot/dts/tegra20-ventana.dts >> index ee3fbf941e79..c897a90289bc 100644 >> --- a/arch/arm/boot/dts/tegra20-ventana.dts >> +++ b/arch/arm/boot/dts/tegra20-ventana.dts >> @@ -18,7 +18,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@0 { >> + device_type = "memory"; >> reg = <0x00000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> index 0a7136462a1a..290ebbeb210f 100644 >> --- a/arch/arm/boot/dts/tegra20.dtsi >> +++ b/arch/arm/boot/dts/tegra20.dtsi >> @@ -4,11 +4,14 @@ >> #include >> #include >> >> -#include "skeleton.dtsi" >> - >> / { >> compatible = "nvidia,tegra20"; >> interrupt-parent = <&lic>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + chosen { }; >> + aliases { }; >> >> iram@40000000 { >> compatible = "mmio-sram"; >> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi >> b/arch/arm/boot/dts/tegra30-apalis.dtsi >> index d1d21ec2a844..184f60c720fa 100644 >> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi >> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi >> @@ -10,6 +10,11 @@ >> model = "Toradex Apalis T30"; >> compatible = "toradex,apalis_t30", "nvidia,tegra30"; >> >> + memory@0 { >> + device_type = "memory"; >> + reg = <0 0>; >> + }; >> + >> pcie@3000 { >> avdd-pexa-supply = <&vdd2_reg>; >> vdd-pexa-supply = <&vdd2_reg>; >> diff --git a/arch/arm/boot/dts/tegra30-beaver.dts >> b/arch/arm/boot/dts/tegra30-beaver.dts >> index ae52a5039506..72369877d284 100644 >> --- a/arch/arm/boot/dts/tegra30-beaver.dts >> +++ b/arch/arm/boot/dts/tegra30-beaver.dts >> @@ -17,7 +17,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> reg = <0x80000000 0x7ff00000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi >> b/arch/arm/boot/dts/tegra30-cardhu.dtsi >> index 92a9740c533f..24c04d4c335d 100644 >> --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi >> +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi >> @@ -40,7 +40,8 @@ >> stdout-path = "serial0:115200n8"; >> }; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> reg = <0x80000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi >> b/arch/arm/boot/dts/tegra30-colibri.dtsi >> index c44d8c40c410..cc46cedf80b9 100644 >> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi >> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi >> @@ -10,7 +10,8 @@ >> model = "Toradex Colibri T30"; >> compatible = "toradex,colibri_t30", "nvidia,tegra30"; >> >> - memory { >> + memory@80000000 { >> + device_type = "memory"; >> reg = <0x80000000 0x40000000>; >> }; >> >> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi >> index a110cf84d85f..4383f0fd789d 100644 >> --- a/arch/arm/boot/dts/tegra30.dtsi >> +++ b/arch/arm/boot/dts/tegra30.dtsi >> @@ -5,11 +5,14 @@ >> #include >> #include >> >> -#include "skeleton.dtsi" >> - >> / { >> compatible = "nvidia,tegra30"; >> interrupt-parent = <&lic>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + chosen { }; >> + aliases { }; > > Could we not add > > memory { device_type = "memory"; }; > > in the SoC level device trees? > > This would save device_type in all other instances. > > That is also how it is done in other places, e.g. > arch/arm/boot/dts/imx6qdl.dtsi Not really because the unit address will not match between different boards. The imx6qdl, as I see, has the same issue: - imx6qdl.dtsi defines "memory" node - imx6dl-apf6dev.dts includes the previous and defines "memory@10000000" This is wrong - two memory nodes. > Also, could we maybe split this in two? > > ARM: dts: tegra: Remove skeleton.dtsi > ARM: dts: tegra: fix DTC warnings for /memory It is possible to split it but this really won't bring any benefit because the removal of skeleton.dtsi is the way to fix the errors. Or saying it differently - the warnings are the reason to remove the skeleton.dtsi. If you split them, what is the reason to remove the skeleton.dtsi? (Theoretically it was deprecated so this could be explanation). If you wish, I can prepare something like: 1. Remove skeleton.dtsi and add everywhere 'device_type = "memory"'. All the warnings will stay but the end DTB should be equal between changes. 2. Fix warnings. > The first would only touch SoC level dts. No, because device_type has to be added everywhere. And because of warnings (explained before) it cannot be added to SoC DTSI. Best regards, Krzysztof > > The second then would fix DTC warnings by adding the address to the > memory nodes in all board files. > > -- > Stefan > >> >> pcie@3000 { >> compatible = "nvidia,tegra30-pcie";