Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp542190imm; Wed, 23 May 2018 01:09:41 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqrJGFntNLNU6GgbKyP6mkjJivHcrfcR5pIbhVQaHJHSmtSIunnliSrYuvxBNoEnc5xz6ik X-Received: by 2002:a63:7a11:: with SMTP id v17-v6mr1290944pgc.97.1527062981619; Wed, 23 May 2018 01:09:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527062981; cv=none; d=google.com; s=arc-20160816; b=kY0sw32342g7lexWxLtAx4PKgyzBOLYSRaDqOe8ZZvpGF79MPKMy5zzwt4LMgiVpRb sSOIjXdyo3unoMQdxmnOwmuU4z46Y4yzAZZPQG1MhFv15msF3XVlaYA3UXIwqJ31+h/3 oPvsspO+qMzTPfAGqvhkJg6KHfTGb2ViPmsu09N/mX/RhjX9NyenmQDBc/9XwXuUxkTW iHXYAefZ5qJQyx5K37uVpOlMC0FiZjKceexrwkYJ4MboJTaryvF4+539gwHuCrK7p6aC JnvI+8nxlDbDOhtmPjpQPDDELxpzjMsEgL1svWjvNehavShHR8RwA1+50clJ8PlI5Fa9 IWcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ExP5HYDgtSFTDXpC8wqIOGnDmHDOPhvSzudOGhp3AIE=; b=wJdG1TuYxLqJLf88LH+TFZ3/m2msKz0JX4Hou/FLnYBtD8/fFx008032r+WW4caZOf b6uyAmX0ohIQWckWgm/hJsA/xpZWVipceKr5owqLk3hPnBHnbRorJ2Sp1zFh2ZCLfJjw wYBDIic29byWwhBXtdcx0qW9drgsjt23pGLfOzENWkStmZGxvd2oIRit+pRK0yx1vNFl YNsNX1gzf6X8WmWF0Qxbbg8CXUTubjOYYo7syL3I/bbGyuJuvbFxi8AoaUOEpXGo8TjZ ysVgWs9rCcqjAeMpZJwx4t9O+6jAslHUGO1xe7FuRKO4qENfl9fQ53b+uDjmwwlHaHzk Cw3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mN3rNG9l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f30-v6si18591430plj.600.2018.05.23.01.09.26; Wed, 23 May 2018 01:09:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mN3rNG9l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbeEWIIe (ORCPT + 99 others); Wed, 23 May 2018 04:08:34 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:39640 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754255AbeEWII3 (ORCPT ); Wed, 23 May 2018 04:08:29 -0400 Received: by mail-oi0-f65.google.com with SMTP id n65-v6so18700486oig.6; Wed, 23 May 2018 01:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ExP5HYDgtSFTDXpC8wqIOGnDmHDOPhvSzudOGhp3AIE=; b=mN3rNG9l6c4gqYkJjfzpvjktRTSJxJYru8IgShH4iZ4n9oPrRkVUq6byi3OR54UCH1 Cgjno/d2RDy4hqMIF7pecEEHYt5vkZ4Gf16Hc1QZFX9DMBou2b7djKQIqS+hdXcmmIpf fu+6ACINjSzHxknFGTBo70ZCSqfYwv/+0ZTtowYYvsJN5VYvTO5C6SvhMmAX5Cdd45Go 1MisZCZoLjbnpGZQAX/QNyHQZeSiSMDsYbEQmr+MWv5hi/v81gpBtOFKcVbs7WQinaUV L+f+2Ktj0LFtGeZCfhb4lUOA5oPECd0oQYGhlkgeRl6xZV0fBk5UZ4s59VsdHIG2eb+D +z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ExP5HYDgtSFTDXpC8wqIOGnDmHDOPhvSzudOGhp3AIE=; b=baW2ykyA+7TAdGSDT5r0726vBjW6pQ73GxpMBxG2b2oSpOlJ0/QD/zTy82Szhj/f+v F0fOhO2l6u2LIxlP1NiBzZiZX7XD8ez7yjq49QZt0OCOchjgkw37jQ8qyZewWYQbxu8Z 61fe2NoFTiRAnCMYXh7umpoWWiHFgJcBj7bpwQnnkfS0ubyz/K+6qWdx8ZiMr3pcbK6D fR9F88ex9d+6xIQNBeKDPg+Vagzwk7FL+c5ccmWYEhQexY4FsH7+Wd4GUqNswbmfzzUa NQQPQDn58NFQtJEWo3MiiCEVBD96y070vGg6dd4gaNu9uGiWgoP6H6MAWklzkda2UWFF FUQA== X-Gm-Message-State: ALKqPwcRTCz7SGS7WUppm3pfx1pyDvVKjqZmNRjmbgeI3AsD8kur1Utr mgtqDPV8k+12bGoHcaYWqKy4plQIL9pEOc0K2w8= X-Received: by 2002:aca:1107:: with SMTP id 7-v6mr497960oir.116.1527062908729; Wed, 23 May 2018 01:08:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:1468:0:0:0:0:0 with HTTP; Wed, 23 May 2018 01:08:28 -0700 (PDT) In-Reply-To: <425bceb1-a03c-06da-f39c-1299662fb6b0@cn.fujitsu.com> References: <20180320110432.28127-1-douly.fnst@cn.fujitsu.com> <20180320110432.28127-5-douly.fnst@cn.fujitsu.com> <7c33b3bd-7e9d-1583-737c-d2edd457bd1a@cn.fujitsu.com> <425bceb1-a03c-06da-f39c-1299662fb6b0@cn.fujitsu.com> From: "Rafael J. Wysocki" Date: Wed, 23 May 2018 10:08:28 +0200 X-Google-Sender-Auth: 4gUbRATX0y3GUCK0e4BtZMqBycY Message-ID: Subject: Re: [PATCH 4/5] acpi/processor: Fix the return value of acpi_processor_ids_walk() To: Dou Liyang Cc: Thomas Gleixner , LKML , "the arch/x86 maintainers" , ACPI Devel Maling List , "open list:DOCUMENTATION" , Ingo Molnar , Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , "H. Peter Anvin" , Peter Zijlstra , "Rafael J. Wysocki" , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 3:34 AM, Dou Liyang wrote: > At 05/22/2018 09:47 AM, Dou Liyang wrote: >> >> >> >> At 05/19/2018 11:06 PM, Thomas Gleixner wrote: >>> >>> On Tue, 20 Mar 2018, Dou Liyang wrote: >>> >>>> ACPI driver should make sure all the processor IDs in their ACPI >>>> Namespace >>>> are unique for CPU hotplug. the driver performs a depth-first walk of >>>> the >>>> namespace tree and calls the acpi_processor_ids_walk(). >>>> >>>> But, the acpi_processor_ids_walk() will return true if one processor is >>>> checked, that cause the walk break after walking pass the first >>>> processor. >>>> >>>> Repace the value with AE_OK which is the standard acpi_status value. >>>> >>>> Fixes 8c8cb30f49b8 ("acpi/processor: Implement DEVICE operator for >>>> processor enumeration") >>>> >>>> Signed-off-by: Dou Liyang >>>> --- >>>> drivers/acpi/acpi_processor.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/acpi/acpi_processor.c >>>> b/drivers/acpi/acpi_processor.c >>>> index 449d86d39965..db5bdb59639c 100644 >>>> --- a/drivers/acpi/acpi_processor.c >>>> +++ b/drivers/acpi/acpi_processor.c >>>> @@ -663,11 +663,11 @@ static acpi_status __init (acpi_handle handle, >>>> } >>>> processor_validated_ids_update(uid); >>>> - return true; >>>> + return AE_OK; >>>> err: >>>> acpi_handle_info(handle, "Invalid processor object\n"); >>>> - return false; >>>> + return AE_OK; >>> >>> >>> I'm not sure whether this is the right return value here. Rafael? >>> > > +Cc Rafael's common used email address. > > I am sorry, I created the cc list using ./script/get_maintainers.pl ... > and didn't check it. No worries, I saw your messages, but thanks!