Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp608577imm; Wed, 23 May 2018 02:32:08 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp25orjxwtngc/kRpjuOS+ReoixeSeHKgEVBSSW1dFqoqY7OzVindZKAWDi4kJBWOLh1Loh X-Received: by 2002:a63:4207:: with SMTP id p7-v6mr1709455pga.163.1527067928742; Wed, 23 May 2018 02:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527067928; cv=none; d=google.com; s=arc-20160816; b=aZPZp6AF9Z7Dty7PtRw7bGoU2iFMDmYi/zrzFJBalL3XtLyjQBiGAJCaTBEOMsZGL9 8SjknOGWHABu6WtT70zXbUaF1jBXX8eNvrW46hKa88vtAASQNfg22da7Zz9ItjZJrxZ5 PloQq3ukOVzSY7jNTLpxSPH7dDGUPrdp5dwN8CtCEO99PYvWFwlaGzM02HstNW6ETo/2 QOvhRn9hnCCX02Y3dGq3+w9gbOGuWVMC0C9HhaYBmnioLKeaXZGff+Chw5hyXOBXZx85 8keYyR/dfS2Ih8QxkqYcaN/SU0NLB865Q8lCH6uiTCbO43FTm6TVgilht1GO4sDUMmOc Y4Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=k6umhQj4JG0que3GV4HJN0SNNB0tQdYhxsHt+W+pZDQ=; b=JCgBhsrJBg9PaqN3aZUzwlQeOaQ9eprtjWJVPn4DQGfMgcdrd7qy4rPiDiWkQO7I6g i8J2gOzss5qG15YuRJTmVE80f2LF/c0wBsfbSRUJmYn2n4IehndesxyVmk3ygWdRirSG WAAoJ87ujHTruZdbsllsSO4DXW+8ogp1hWNfaQAwDo0queSdxX6u2tH3VPfHq4hBHwrS 5vMuMRm5joA0R3Ac6wmunYQfB8GViRA4UqaLff3ukHE+PG05l/Rf2Y9Djzvz2l10us9K 5UupuPwwPfsXatkdGX/MkKZOGO5PbwG7IfHC+4op69DvMUwyD8B8t0b6wFHw8FAShb5S G75A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17-v6si14494262pgp.214.2018.05.23.02.31.54; Wed, 23 May 2018 02:32:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932270AbeEWJbR (ORCPT + 99 others); Wed, 23 May 2018 05:31:17 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:59253 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932196AbeEWJbN (ORCPT ); Wed, 23 May 2018 05:31:13 -0400 X-UUID: e8198ed3252a43af8b563a641819357a-20180523 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 571305620; Wed, 23 May 2018 17:31:11 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 23 May 2018 17:31:09 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 23 May 2018 17:31:09 +0800 Message-ID: <1527067869.19074.29.camel@mtksdaap41> Subject: Re: [PATCH v2 4/4] drm/mediatek: add connection from OD1 to RDMA1 From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , , Date: Wed, 23 May 2018 17:31:09 +0800 In-Reply-To: <1527055278.21354.3.camel@mtksdaap41> References: <20180523022517.12103-1-stu.hsieh@mediatek.com> <20180523022517.12103-5-stu.hsieh@mediatek.com> <1527055278.21354.3.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-05-23 at 14:01 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-05-23 at 10:25 +0800, Stu Hsieh wrote: > > This patch add the connection from OD1 to RDMA1 for ext path. > > > > I would like to apply this patch before the patch 'Add support for > mediatek SOC MT2712' because this patch is necessary for mt2712. ok > > Regards, > CK > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 3c7bd453cf42..0450ecbbc356 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -193,6 +193,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > } else if (cur == DDP_COMPONENT_GAMMA && next == DDP_COMPONENT_RDMA1) { > > *addr = DISP_REG_CONFIG_DISP_GAMMA_MOUT_EN; > > value = GAMMA_MOUT_EN_RDMA1; > > + } else if (cur == DDP_COMPONENT_OD1 && next == DDP_COMPONENT_RDMA1) { > > + *addr = DISP_REG_CONFIG_DISP_OD_MOUT_EN; > > + value = OD1_MOUT_EN_RDMA1; > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > value = RDMA1_MOUT_DPI0; > >