Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp684212imm; Wed, 23 May 2018 04:00:51 -0700 (PDT) X-Google-Smtp-Source: AB8JxZocXgPg0i/wjD2SSmxDptPwUsH5pKuzNn70G86+yAPaxlKkZOgFFl9/ZPw3CtSKUDLJR09+ X-Received: by 2002:a17:902:64d0:: with SMTP id y16-v6mr2407575pli.349.1527073251920; Wed, 23 May 2018 04:00:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527073251; cv=none; d=google.com; s=arc-20160816; b=fO2y6d4OIG5OYRIapPLVe7EFAKzHxYuYnggah73a3e5x23M3XtfAEFzkDpMecFX+ov dHhbllYFZALJWJ0JVlc+/cp66jXu5kc/OzNPiESnLcSQtjdHCaKbje0eXcxrBEBTkDjt LeM27VCc+WsBYG8fI5Tc4lhXdRSuE5vvyUjF1JLxw2e7jQBVWg++poL6p76KCfdRgmxN jKeW5ibVLW+Fgal29W/rVbvEINCsRTY2rAIYuOekbJRtjgzFeOL30Ax4lmo5R4saITZC YbU66L8aL03rzrhXIWIzf4BvDf8oULYtvGi/bQO2lC5iMUWMRRgqCEvJz7otNEKmtrrx jcSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:arc-authentication-results; bh=zAzpPyBMsgo3irrpVCJ9CJ54OC8IZnMReSrmnq6HsIE=; b=PZOKO1nJwWqNeJEctgJ9iu8qfvt1pxworekdvRPcPCAbKlRnHTXpm9RyY8CbLWklNU eTxmPQNrAV2LHCrGyw07e6vf9Yxh+x0L4AZzEPAeebSypGhTMyhcYyCPQhYZXDgygXON GWNxA7igUcdd4G3zOXhfTFPYEhZ3LI49ruk4eVSiL4Yn6+u8EmHHNaciTzCwcQyMUKF5 zshqw9tkgzzK8RASQh8i6oSt2DF9eDZcGSAghbYCoNhAxOWrffEDwwZZWnFBHsOeJ4Ao VJk1kxGMA/28XraoXXjUrYyB5Whdxgy9h460Q9mgc8tckRy6mKuLYeCi5fIc4NYJJyAQ YA4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=zqfZsa6C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4-v6si19214007pff.24.2018.05.23.04.00.37; Wed, 23 May 2018 04:00:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@agner.ch header.s=dkim header.b=zqfZsa6C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932562AbeEWLAZ (ORCPT + 99 others); Wed, 23 May 2018 07:00:25 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:52820 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932312AbeEWLAV (ORCPT ); Wed, 23 May 2018 07:00:21 -0400 Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id DAE935C1224; Wed, 23 May 2018 13:00:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1527073219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zAzpPyBMsgo3irrpVCJ9CJ54OC8IZnMReSrmnq6HsIE=; b=zqfZsa6CJ+QjMLKhlePvzgdSRscotBfwyKyMtSmdi4mTD5VSR9hj+tCUprROBdUvlIsg8R u6uslOt/4T5L+xuBQXF6UKDZdsqV6veOm3ZpIzhEJkR06tWcUWdiLV+2E1pb4YgpwYelCf fCTxGK+q+86RXie7KHI1GtvlzRTPFF0= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 23 May 2018 13:00:19 +0200 From: Stefan Agner To: Krzysztof Kozlowski Cc: Rob Herring , Mark Rutland , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Ziswiler , Lucas Stach Subject: Re: [PATCH v6 2/4] ARM: dts: tegra: Fix unit_address_vs_reg DTC warnings for /memory In-Reply-To: <1527069406-6359-2-git-send-email-krzk@kernel.org> References: <1527069406-6359-1-git-send-email-krzk@kernel.org> <1527069406-6359-2-git-send-email-krzk@kernel.org> Message-ID: <870361d2b9451af2e21cc570c8fca2c2@agner.ch> X-Sender: stefan@agner.ch User-Agent: Roundcube Webmail/1.3.4 X-Spamd-Result: default: False [-3.10 / 15.00]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[dt]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[10]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; ASN(0.00)[asn:29691, ipnet:2a02:418::/29, country:CH]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.05.2018 11:56, Krzysztof Kozlowski wrote: > Add a generic /memory node in each Tegra DTSI (with empty reg property, > to be overidden by each DTS) and set proper unit address for /memory > nodes to fix the DTC warnings: > > arch/arm/boot/dts/tegra20-harmony.dtb: Warning (unit_address_vs_reg): > /memory: node has a reg or ranges property, but no unit name > > The DTB after the change is the same as before except adding > unit-address to /memory node. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v5: > 1. Split with skeleton.dtsi removal (suggested by Stefan). > > Changes since v4: > 1. None > --- > arch/arm/boot/dts/tegra114-dalmore.dts | 2 +- > arch/arm/boot/dts/tegra114-roth.dts | 2 +- > arch/arm/boot/dts/tegra114-tn7.dts | 2 +- > arch/arm/boot/dts/tegra114.dtsi | 3 ++- > arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 2 +- > arch/arm/boot/dts/tegra124-apalis.dtsi | 2 +- > arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +- > arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +- > arch/arm/boot/dts/tegra124-venice2.dts | 2 +- > arch/arm/boot/dts/tegra124.dtsi | 3 ++- > arch/arm/boot/dts/tegra20-colibri-512.dtsi | 2 +- > arch/arm/boot/dts/tegra20-harmony.dts | 2 +- > arch/arm/boot/dts/tegra20-paz00.dts | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > arch/arm/boot/dts/tegra20-tamonten.dtsi | 2 +- > arch/arm/boot/dts/tegra20-trimslice.dts | 2 +- > arch/arm/boot/dts/tegra20-ventana.dts | 2 +- > arch/arm/boot/dts/tegra20.dtsi | 3 ++- > arch/arm/boot/dts/tegra30-apalis.dtsi | 4 ++-- > arch/arm/boot/dts/tegra30-beaver.dts | 2 +- > arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +- > arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +- > arch/arm/boot/dts/tegra30.dtsi | 3 ++- > 23 files changed, 28 insertions(+), 24 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts > b/arch/arm/boot/dts/tegra114-dalmore.dts > index eafff16765b4..1788556b4977 100644 > --- a/arch/arm/boot/dts/tegra114-dalmore.dts > +++ b/arch/arm/boot/dts/tegra114-dalmore.dts > @@ -23,7 +23,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@80000000 { > reg = <0x80000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra114-roth.dts > b/arch/arm/boot/dts/tegra114-roth.dts > index 7ed7370ee67a..3d3835591cd2 100644 > --- a/arch/arm/boot/dts/tegra114-roth.dts > +++ b/arch/arm/boot/dts/tegra114-roth.dts > @@ -28,7 +28,7 @@ > }; > }; > > - memory { > + memory@80000000 { > /* memory >= 0x79600000 is reserved for firmware usage */ > reg = <0x80000000 0x79600000>; > }; > diff --git a/arch/arm/boot/dts/tegra114-tn7.dts > b/arch/arm/boot/dts/tegra114-tn7.dts > index 7fc4a8b31e45..bfdd1bf61816 100644 > --- a/arch/arm/boot/dts/tegra114-tn7.dts > +++ b/arch/arm/boot/dts/tegra114-tn7.dts > @@ -28,7 +28,7 @@ > }; > }; > > - memory { > + memory@80000000 { > /* memory >= 0x37e00000 is reserved for firmware usage */ > reg = <0x80000000 0x37e00000>; > }; > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > index 27ef515e5640..aff4b8e115bc 100644 > --- a/arch/arm/boot/dts/tegra114.dtsi > +++ b/arch/arm/boot/dts/tegra114.dtsi > @@ -11,8 +11,9 @@ > #address-cells = <1>; > #size-cells = <1>; > > - memory { > + memory@80000000 { > device_type = "memory"; > + reg = <0x80000000 0>; Nit: I'd rather prefer reg = <0x80000000 0x0>; > }; > > host1x@50000000 { > diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi > b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi > index bb67edb016c5..6a7f45651d38 100644 > --- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi > +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi > @@ -15,7 +15,7 @@ > compatible = "toradex,apalis-tk1-v1.2", "toradex,apalis-tk1", > "nvidia,tegra124"; > > - memory { > + memory@0 { > reg = <0x0 0x80000000 0x0 0x80000000>; > }; Unit address combines all address cells, so this should be 80000000 here. See also the device tree spec (v0.2) which has an example in chapter 3.4 /memory node. So this should be: memory@80000000 { ... Same with all the board files below. > > diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi > b/arch/arm/boot/dts/tegra124-apalis.dtsi > index 65a2161b9b8e..e4625abd0a8a 100644 > --- a/arch/arm/boot/dts/tegra124-apalis.dtsi > +++ b/arch/arm/boot/dts/tegra124-apalis.dtsi > @@ -50,7 +50,7 @@ > model = "Toradex Apalis TK1"; > compatible = "toradex,apalis-tk1", "nvidia,tegra124"; > > - memory { > + memory@0 { > reg = <0x0 0x80000000 0x0 0x80000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts > b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > index 6dbcf84dafbc..e23b1159e8fd 100644 > --- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts > +++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts > @@ -24,7 +24,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x0 0x80000000 0x0 0x80000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi > b/arch/arm/boot/dts/tegra124-nyan.dtsi > index 3609367037a6..f45ac668d88c 100644 > --- a/arch/arm/boot/dts/tegra124-nyan.dtsi > +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi > @@ -13,7 +13,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x0 0x80000000 0x0 0x80000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra124-venice2.dts > b/arch/arm/boot/dts/tegra124-venice2.dts > index 89bcc178994d..44492b48e165 100644 > --- a/arch/arm/boot/dts/tegra124-venice2.dts > +++ b/arch/arm/boot/dts/tegra124-venice2.dts > @@ -18,7 +18,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x0 0x80000000 0x0 0x80000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > index 951feea784af..ad9c9cd6fa8a 100644 > --- a/arch/arm/boot/dts/tegra124.dtsi > +++ b/arch/arm/boot/dts/tegra124.dtsi > @@ -13,8 +13,9 @@ > #address-cells = <2>; > #size-cells = <2>; > > - memory { > + memory@0 { > device_type = "memory"; > + reg = <0 0>; > }; This should have two address and two size cells I guess. And DDR for all TK1 start at 0x0 0x80000000... So here with a default length of 0: memory@80000000 { reg = <0x0 0x80000000 0x0 0x0>; }; > > pcie@1003000 { > diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi > b/arch/arm/boot/dts/tegra20-colibri-512.dtsi > index 5c202b3e3bb1..5623ff8d128c 100644 > --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi > +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi > @@ -10,7 +10,7 @@ > rtc1 = "/rtc@7000e000"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x20000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-harmony.dts > b/arch/arm/boot/dts/tegra20-harmony.dts > index 628a55a9318b..1d96d92b72a7 100644 > --- a/arch/arm/boot/dts/tegra20-harmony.dts > +++ b/arch/arm/boot/dts/tegra20-harmony.dts > @@ -18,7 +18,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-paz00.dts > b/arch/arm/boot/dts/tegra20-paz00.dts > index 30436969adc0..ef245291924f 100644 > --- a/arch/arm/boot/dts/tegra20-paz00.dts > +++ b/arch/arm/boot/dts/tegra20-paz00.dts > @@ -19,7 +19,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x20000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts > b/arch/arm/boot/dts/tegra20-seaboard.dts > index 284aae351ff2..f91441683aad 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -18,7 +18,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-tamonten.dtsi > b/arch/arm/boot/dts/tegra20-tamonten.dtsi > index 872046d48709..20137fc578b1 100644 > --- a/arch/arm/boot/dts/tegra20-tamonten.dtsi > +++ b/arch/arm/boot/dts/tegra20-tamonten.dtsi > @@ -15,7 +15,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x20000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-trimslice.dts > b/arch/arm/boot/dts/tegra20-trimslice.dts > index d55c6b240a30..9eb26dc15f6b 100644 > --- a/arch/arm/boot/dts/tegra20-trimslice.dts > +++ b/arch/arm/boot/dts/tegra20-trimslice.dts > @@ -18,7 +18,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20-ventana.dts > b/arch/arm/boot/dts/tegra20-ventana.dts > index ee3fbf941e79..f44551e2d9d0 100644 > --- a/arch/arm/boot/dts/tegra20-ventana.dts > +++ b/arch/arm/boot/dts/tegra20-ventana.dts > @@ -18,7 +18,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@0 { > reg = <0x00000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 88dd1afb5877..55581c0e5105 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -13,8 +13,9 @@ > chosen { }; > aliases { }; > > - memory { > + memory@0 { > device_type = "memory"; > + reg = <0 0>; > }; > > iram@40000000 { > diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi > b/arch/arm/boot/dts/tegra30-apalis.dtsi > index 6f29cbad6e8a..9465fc592b7b 100644 > --- a/arch/arm/boot/dts/tegra30-apalis.dtsi > +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi > @@ -10,8 +10,8 @@ > model = "Toradex Apalis T30"; > compatible = "toradex,apalis_t30", "nvidia,tegra30"; > > - memory { > - reg = <0 0>; > + memory@80000000 { > + reg = <0x80000000 0x40000000>; > }; > > pcie@3000 { > diff --git a/arch/arm/boot/dts/tegra30-beaver.dts > b/arch/arm/boot/dts/tegra30-beaver.dts > index ae52a5039506..1434d50438f9 100644 > --- a/arch/arm/boot/dts/tegra30-beaver.dts > +++ b/arch/arm/boot/dts/tegra30-beaver.dts > @@ -17,7 +17,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@80000000 { > reg = <0x80000000 0x7ff00000>; > }; > > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi > b/arch/arm/boot/dts/tegra30-cardhu.dtsi > index 92a9740c533f..33b73dca16a3 100644 > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi > @@ -40,7 +40,7 @@ > stdout-path = "serial0:115200n8"; > }; > > - memory { > + memory@80000000 { > reg = <0x80000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi > b/arch/arm/boot/dts/tegra30-colibri.dtsi > index c44d8c40c410..9bf3327665d3 100644 > --- a/arch/arm/boot/dts/tegra30-colibri.dtsi > +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi > @@ -10,7 +10,7 @@ > model = "Toradex Colibri T30"; > compatible = "toradex,colibri_t30", "nvidia,tegra30"; > > - memory { > + memory@80000000 { > reg = <0x80000000 0x40000000>; > }; > > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > index 19237c08c166..2b6243b0c6d6 100644 > --- a/arch/arm/boot/dts/tegra30.dtsi > +++ b/arch/arm/boot/dts/tegra30.dtsi > @@ -14,8 +14,9 @@ > chosen { }; > aliases { }; > > - memory { > + memory@80000000 { > device_type = "memory"; > + reg = <0x80000000 0>; Nit: for consistency sake, 0x0 :-) -- Stefan > }; > > pcie@3000 {