Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp805930imm; Wed, 23 May 2018 05:58:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoCSIneXfyX8vz1z2R3+TYIcyVTlifkyAOHRQd+7CkKrHf91C3/ep91DkE4WKyKcPAAgssA X-Received: by 2002:a63:a44a:: with SMTP id c10-v6mr2285523pgp.147.1527080283844; Wed, 23 May 2018 05:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527080283; cv=none; d=google.com; s=arc-20160816; b=xkJp7qageM61Wvv8qLkTV7EVduh/dU79plPezeN9/JeUWnKCW+JlFfsripyfm1CwDJ ipjU5pXqc8Z6tC5t/ddDOnAi8egYRdYdFyp7wDpwkEta/Tuk4fRbrzCORf3h0zICr/1V +/KvoNF2StJsSN7kPIweVgqNiYf7U7U2hlVzO9li8ER/wHAQTLou/86XADJhmus09d/b HoHTQZcaslIgZ0HbPIpuFEGBaY4/IsRf59zp5azL6ij46E74Ck1HMqKBNlGgjCvoGrJp GSeNyyGY9zNI8jS4fExgsE9x+TmQ0+XJ4cQLcsGBu/NnrBPP3n9i6s5QHvyCXc94mSxN Fx3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:arc-authentication-results; bh=UCVZqeYZgYLA9urh8rZX90Qt+WtKuOGvAJ51d5tFpGI=; b=ny7dufgGtk0OCfNNMkxCAh9ew5Mci+V+t5M5/0RK49fDbd6mm17vAeH5kbwpoNapgD vJaquBbQEknAa4kt9WnhyVo8c2uPUi5hIXsHmCM5IF7dQupyz/wh/3/sCZIHQsi+h+GX cQvI5y1Ww52ZVwlFK05hc9EYA3rx+qAmZiydcGJBRsCVfdhM3Hyj8RvHyQRbbL5GMv2n Wsq5ABoBB1j+oQ4zlLdDJMC/U9RphdLPay35Jd3N2q/K9t0azB2qsL3Wh4AhZomE3oOO T0COFt8V5kEY7e1f3fTScH3ZpPoBr3x8FBWZXmFCl5ucYX+9jr9DHSMveGBItvT+AmzG g0YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z86-v6si18992248pfa.120.2018.05.23.05.57.48; Wed, 23 May 2018 05:58:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933004AbeEWM5B (ORCPT + 99 others); Wed, 23 May 2018 08:57:01 -0400 Received: from mga14.intel.com ([192.55.52.115]:31891 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932672AbeEWM45 (ORCPT ); Wed, 23 May 2018 08:56:57 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2018 05:56:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,433,1520924400"; d="scan'208";a="231104467" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.88]) by fmsmga006.fm.intel.com with ESMTP; 23 May 2018 05:56:55 -0700 Date: Wed, 23 May 2018 15:56:55 +0300 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v4 1/4] tpm: migrate tpm2_shutdown() to use struct tpm_buf Message-ID: <20180523125655.GB363@linux.intel.com> References: <20180326121406.14548-1-jarkko.sakkinen@linux.intel.com> <20180326121406.14548-2-jarkko.sakkinen@linux.intel.com> <20180518223032.ihszdef5wesj5nie@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180518223032.ihszdef5wesj5nie@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 18, 2018 at 03:30:32PM -0700, Jerry Snitselaar wrote: > On Mon Mar 26 18, Jarkko Sakkinen wrote: > > In order to make struct tpm_buf the first class object for constructing TPM > > commands, migrate tpm2_shutdown() to use it. In addition, removed the klog > > entry when tpm_transmit_cmd() fails because tpm_tansmit_cmd() already > > prints an error message. > > > > Signed-off-by: Jarkko Sakkinen > > Reviewed-by: Jerry Snitselaar Thanky you Jerry. I'll do one more round for this only to update kdoc. It does not involve code changes so are you OK if you I keep your reviewed-by despite this update? /Jarkko