Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp806540imm; Wed, 23 May 2018 05:58:39 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqLvlucWF86km3bkG1a6r4hUDVX1gFoZs78kP7J8HOdWKvIKI4HLRD9r1tyJ9yqbbEmakaY X-Received: by 2002:a17:902:422:: with SMTP id 31-v6mr2953367ple.320.1527080319383; Wed, 23 May 2018 05:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527080319; cv=none; d=google.com; s=arc-20160816; b=b3/CR3LDIAYkPCLooC5+P+s90CU9IVEeQcUs/XUsw+U4OWhpct5t+HXgvsZwnqZmWF rujAnc3ZixtqgWtH5b887PeYobrXY/h+GIYNEN4OTTy0Lqs2orCqVDCfbMTZsoz4PnmE KutoEDec5U04e7qH+R7eU2Zlm6RDY08vqHp42XQbZGGOWjG9rtyVWhhHCqakB1r4+sJS Kn13dtkM/G2CLEM1xnJ+r9sGZq2piGCwyycFeTx5rx/GBuKVsOoSh6v5g4asIyys8G0T C0xZXZ7OxQqB0ABfnlYmr74/V7tcBo9jQBZTn+O1le3eewUgTl0QU4skUwARGF7J9HJL JIOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=v2ub2FRccNa3lcMWgpRO8FU8lRSwk8TLplKyfgl1e2A=; b=WjetXjVPu0ZMyS85v9dYlh9zPc21T4zhqHSt9iWiQ39g6/DuM4f7/UyhL5lpDb1ESv L0szhNgoZHYhELkepVyp4pfxI6QGsRixltnamT13ePKGvuALYWSIImEFLMeN96vb2Buh fZTWJTT2rIHWRXBSsdcBYBEJxwXfXoBGwPG7H8hB09P55x4XBUB5HEYOqh9+XSiA4BFl tMl1CVtS4nJ1WxvUkFm081L7eX9fA2RuNVvrN/CeQt0rzdmOkjVzpnK2lj1HGpoijqPP 9gM1Bc4CO396XbD2PA1sD5d35eQnsIdT5Pd/lMCwDphb52juecf8w4sPsdn2d+BKBs2m DXrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19-v6si18381091plo.174.2018.05.23.05.58.24; Wed, 23 May 2018 05:58:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933015AbeEWM4J (ORCPT + 99 others); Wed, 23 May 2018 08:56:09 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43985 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932747AbeEWM4D (ORCPT ); Wed, 23 May 2018 08:56:03 -0400 Received: by mail-wr0-f194.google.com with SMTP id r13-v6so13969266wrj.10 for ; Wed, 23 May 2018 05:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=v2ub2FRccNa3lcMWgpRO8FU8lRSwk8TLplKyfgl1e2A=; b=RiM2+frt7KFXncE5KqlOXlT2/40C3mlLMGwTjgiG4azvCupGRd5I6PaqrLijvWaHTR i+ZkwkJZmSefJBa8uDVuBNxL1gDry0m02qREDcIa+By/QqmtRG70EnkjYLv60t6C6aoA A6u5Or0dfC5zZKYOBbcyC/NXnpcOJChLhwslnR/bONV0mVTNbkPAbzGD/xCVEbK3rmpl M4BwIyCEw8MzIyxdLOgjghXvTbxRFRpX8g6PnuV7FTTNjwXfRcAz8V3OtbBjS1HBnM5M 71sxoE0X+b8E9kazMdKQ936AT3zwGW5+XWd8gyjvh3uitiPs+GjHznBC0825qygfREmA ErVw== X-Gm-Message-State: ALKqPwdX3rBM3CvPnTp/6tw5ri93ko5zD4J9V2KNFe1hSaPhNkeZa5q9 qMJATb9PTMr2BmcH59VYJOazOU+P X-Received: by 2002:adf:a0ea:: with SMTP id n39-v6mr2307578wrn.87.1527080162700; Wed, 23 May 2018 05:56:02 -0700 (PDT) Received: from tiehlicka.suse.cz (ip-37-188-135-200.eurotel.cz. [37.188.135.200]) by smtp.gmail.com with ESMTPSA id u89-v6sm2643543wma.4.2018.05.23.05.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 05:56:01 -0700 (PDT) From: Michal Hocko To: Andrew Morton Cc: Oscar Salvador , Vlastimil Babka , Pavel Tatashin , Reza Arbab , Igor Mammedov , Vitaly Kuznetsov , LKML , Subject: [PATCH 0/2] few memory hotplug fixes Date: Wed, 23 May 2018 14:55:53 +0200 Message-Id: <20180523125555.30039-1-mhocko@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Resending with the mailing lists CCed - sorry for spamming] Hi Andrew, Oscar has reported two issue when playing with the memory hotplug [1][2]. The first one seems more serious and patch 1 should address it. In short we are overly optimistic about zone movable not containing any non-movable pages and after 72b39cfc4d75 ("mm, memory_hotplug: do not fail offlining too early") this can lead to a seemingly stuck (still interruptible by a signal) memory offline. Patch 2 fixes an over-eager warning which is not harmful but surely annoying. I know we are late in the release cycle but I guess both would be candidates for rc7. They are simple enough and they should be "obviously" correct. If you would like more time for them for testing then I am perfectly fine postponing to the next merge window of course. [1] http://lkml.kernel.org/r/20180523073547.GA29266@techadventures.net [2] http://lkml.kernel.org/r/20180523080108.GA30350@techadventures.net Michal Hocko (2): mm, memory_hotplug: make has_unmovable_pages more robust mm: do not warn on offline nodes unless the specific node is explicitly requested Diffstat include/linux/gfp.h | 2 +- mm/page_alloc.c | 16 ++++++++++------ 2 files changed, 11 insertions(+), 7 deletions(-)