Received: by 2002:ac0:a594:0:0:0:0:0 with SMTP id m20-v6csp822787imm; Wed, 23 May 2018 06:11:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp0wY4BpcLWQNER5rWx7pWuz7aZNXTH+8Xlsfi28e4SrYq/ADGRC4YwiE6BX3F3c9Hj3wZX X-Received: by 2002:a65:45c7:: with SMTP id m7-v6mr2350867pgr.109.1527081060850; Wed, 23 May 2018 06:11:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527081060; cv=none; d=google.com; s=arc-20160816; b=Adck1V02FavFM72rtZ+a+z/YQuf7G2klC8w1qnQ8br3ltriu3Gdkia45xT7mJaDP9Z ozsFHvcECAw1XJB2VCQtPGYOKZhOve2ouafg3x8o74PJsJNX+y22dlUfYEKSNyK67WRa 7kJmCT2Ww/Z6T0j4vXD7axKhjD8VsOLzPrRf1KAuPr0QFp0yyNZNPDPCtv0AADhgEvZD 4ohN9qLLLPnnlUjD/wcmV7C+/lCocgtoWTUAEGD2GpRSTvv0ov/6DCi1e+i05B4IbBxt C/y9xiT6Jcj4xXJoN76TRTPZfDF4slCX7IBKhhfWYd3EYcVWcuPtm1WNfRolaJNwES7t 0wtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=UKiaDO7YxZFMPpb/fno9NCyUsaxs1feU1AwKrI/rq5g=; b=fVUfFt27HTmsN+ELme8tyDVtel5TPQ97CkOpHC58BYQIeBbf+7XZcvMbQk2tPjITgQ QUbk05NQSGtDMncKEktFy0qidaFliPzDYj7s3FlEwDs8TzavOu8g71s1vFi/9dYFWItE ApqD/BlJQMr7ujyddvmn4Iw15sdIBXmz9M1GrhOnOXDXHGPFrL2+n3ckowjULm217M+f 9ZQhy6BFYJe1dmh/2nR6I6Pd2DnpCpBY5MbpIwGrrM93BvecWvwOy3pICAXV7M2hyOaa CSdd/zpL1yz9yqqK1LRLasvtd4NE+Y+rzoTs+kNRhNPHSa9ULwqNRuMIEbaiVaPpaPpA UJdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HSkqmDMB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 99-v6si18316835plc.362.2018.05.23.06.10.26; Wed, 23 May 2018 06:11:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=HSkqmDMB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932950AbeEWNKB (ORCPT + 99 others); Wed, 23 May 2018 09:10:01 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59602 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932707AbeEWNKA (ORCPT ); Wed, 23 May 2018 09:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UKiaDO7YxZFMPpb/fno9NCyUsaxs1feU1AwKrI/rq5g=; b=HSkqmDMBNrDginJkv5MjKva6k yyDYI5IZ7BqzeEJ65Tp24ZNyoQsUDkyeFicnj9GBwmDeiFCbpNr/gcI32n/C3kYweslHYrdlNC2+Z 9Go/NzvsDzrO9QWBaU5DdV8Nxw8qwrVntTKOTy5ZMJQXBfbQ78ojRO9osTrSq6LkYSsGBgoR8BJZ9 qWBhxgezBU9Mn4xCbBcY1atlzwuLXVknbHPzfxzHWRaNpTNBa0RTxX8SpofL5578ihSNGkSTYD2vZ 05sgknvLJcAZQtQPqQT/3c0UMhZpRAy9oizzA03wDfyCesDJyBCfYrbI9+rMWvhoWp8rkGh/vM/PM rXZ0TRGfw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLTWa-0006sc-GU; Wed, 23 May 2018 13:09:52 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CD5B02029F870; Wed, 23 May 2018 15:09:50 +0200 (CEST) Date: Wed, 23 May 2018 15:09:50 +0200 From: Peter Zijlstra To: Alexey Budankov Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , linux-kernel , linux-perf-users@vger.kernel.org, Andy Lutomirski Subject: Re: [PATCH v2]: perf/x86: store user space frame-pointer value on a sample Message-ID: <20180523130950.GB12217@hirez.programming.kicks-ass.net> References: <31205dc8-b756-e12b-0249-2ed06c2db9c9@linux.intel.com> <20180509145436.GV12217@hirez.programming.kicks-ass.net> <3ecedd91-1c01-6fc5-4648-89eaf5ff0930@linux.intel.com> <20180510101406.GA12217@hirez.programming.kicks-ass.net> <7051f72e-2570-68c8-1488-33ad1b024031@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7051f72e-2570-68c8-1488-33ad1b024031@linux.intel.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 23, 2018 at 01:06:58PM +0300, Alexey Budankov wrote: > Is the patch ready to be up streamed now? Please post a new one where you modify the comment about the syscalls not saving registers and ideally find the commit that made it so. Also; I think Andy would appreciate a comment near the syscall code that refers back to this code and states what registers we rely upon being there (+BP for this patch).