Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 May 2018 15:54:54 +0200
Message-ID: <s5hmuwqpjdd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Guenter Roeck" <groeck@google.com>
Cc:     "Liam Girdwood" <lgirdwood@gmail.com>,
        <alsa-devel@alsa-project.org>,
        "Guenter Roeck" <groeck@chromium.org>,
        "Chintan Patel" <chintan.m.patel@intel.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
In-Reply-To: <20180522165842.233949-1-groeck@google.com>
References: <20180522165842.233949-1-groeck@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 22 May 2018 18:58:42 +0200,
Guenter Roeck wrote:
> 
> +struct skl_dfw_v4_module_caps {
> +	u32 set_params:2;
> +	u32 rsvd:30;
> +	u32 param_id;
> +	u32 caps_size;
> +	u32 caps[HDA_SST_CFG_MAX];
> +};

Missing __packed attribute?

And I'm wondering whether we should move these definitions to uapi
headers.


thanks,

Takashi