Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates
 193.47.165.134 as permitted sender) receiver=protection.outlook.com;
 client-ip=193.47.165.134; helo=mtlcas13.mtl.com;
Subject: Re: [PATCH] nvme: host: core: fix precedence of ternary operator
To:     Ivan Bornyakov <brnkv.i1@gmail.com>,
        <linux-nvme@lists.infradead.org>
CC:     <axboe@fb.com>, <sagi@grimberg.me>, <linux-kernel@vger.kernel.org>,
        <keith.busch@intel.com>, <hch@lst.de>
References: <20180523145611.10297-1-brnkv.i1@gmail.com>
From:   Max Gurtovoy <maxg@mellanox.com>
Message-ID: <2cdc9032-901d-fbec-69e5-63087923e4b1@mellanox.com>
Date:   Wed, 23 May 2018 18:07:15 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180523145611.10297-1-brnkv.i1@gmail.com>
Content-Type: text/plain; charset="windows-1255"; format=flowed
Content-Language: he
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2018 15:07:23.5233
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 763b841b-0f22-43bf-9c71-08d5c0bee38f
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4455
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/23/2018 5:56 PM, Ivan Bornyakov wrote:
> Ternary operator have lower precedence then bitwise or, so 'cdw10' was
> calculated wrong.
> 
> Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
> ---
>   drivers/nvme/host/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b070c659391f..1eba9b0cb9dc 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1577,7 +1577,7 @@ static int nvme_pr_reserve(struct block_device *bdev, u64 key,
>   static int nvme_pr_preempt(struct block_device *bdev, u64 old, u64 new,
>   		enum pr_type type, bool abort)
>   {
> -	u32 cdw10 = nvme_pr_type(type) << 8 | abort ? 2 : 1;
> +	u32 cdw10 = nvme_pr_type(type) << 8 | (abort ? 2 : 1);
>   	return nvme_pr_command(bdev, cdw10, old, new, nvme_cmd_resv_acquire);
>   }
>   
> @@ -1589,7 +1589,7 @@ static int nvme_pr_clear(struct block_device *bdev, u64 key)
>   
>   static int nvme_pr_release(struct block_device *bdev, u64 key, enum pr_type type)
>   {
> -	u32 cdw10 = nvme_pr_type(type) << 8 | key ? 1 << 3 : 0;
> +	u32 cdw10 = nvme_pr_type(type) << 8 | (key ? 1 << 3 : 0);
>   	return nvme_pr_command(bdev, cdw10, key, 0, nvme_cmd_resv_release);
>   }
>   
> 

Looks good,

Reviewed-by: Max Gurtovoy <maxg@mellanox.com>