Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263183AbTIASfk (ORCPT ); Mon, 1 Sep 2003 14:35:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263649AbTIASfk (ORCPT ); Mon, 1 Sep 2003 14:35:40 -0400 Received: from MAIL.13thfloor.at ([212.16.62.51]:33421 "EHLO mail.13thfloor.at") by vger.kernel.org with ESMTP id S263183AbTIASf3 (ORCPT ); Mon, 1 Sep 2003 14:35:29 -0400 Date: Mon, 1 Sep 2003 20:35:27 +0200 From: Herbert Poetzl To: Jan Kara Cc: linux-kernel@vger.kernel.org Subject: Re: [BUG] mtime&ctime updated when it should not Message-ID: <20030901183527.GB21251@DUK2.13thfloor.at> Mail-Followup-To: Jan Kara , linux-kernel@vger.kernel.org References: <20030901181113.GA15672@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030901181113.GA15672@atrey.karlin.mff.cuni.cz> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 40 On Mon, Sep 01, 2003 at 08:11:13PM +0200, Jan Kara wrote: > Hello, > > one user pointed my attention to the fact that when the write fails > (for example when the user quota is exceeded) the modification time is > still updated (the problem appears both in 2.4 and 2.6). According to > SUSv3 that should not happen because the specification says that mtime > and ctime should be marked for update upon a successful completition > of a write (not that it would forbid updating the times in other cases > but I find it at least a bit nonintuitive). > The easiest fix would be probably to "backup" the times at the > beginning of the write and restore the original values when the write > fails (simply not updating the times would require more surgery because > for example vmtruncate() is called when the write fails and it also > updates the times). > So should I write the patch or is the current behaviour considered > correct? hmm, what if the request only partially succeeds? for example echo "five" >/tmp/x will create /tmp/x if inode limit permits it, but will leave it empty if the space limit does not ... personally I wouldn't care about the modification time on such a quota fault ... best, Herbert > Honza > > -- > Jan Kara > SuSE CR Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/